[HOLD for payment 2024-11-20] [$250] Search - Unable to select expenses by tapping and holding

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.59-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5193391
Issue reported by: Applause Internal Team

Action Performed:

Preconditions: User with existing expenses

1. Log in with user from preconditions
2. Tap on Search in the bottom
3. Tap and hold an expense

Expected Result:

Select option should be displayed in the bottom.

Actual Result:

Nothing happens when tapping and holding an expense, user is unable to select expenses in search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6657722_1730992573228.Record_2024-11-07-16-15-10.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021854876478688351316
• Upwork Job ID: 1854876478688351316
• Last Price Increase: 2024-11-23

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021854876478688351316

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[Julesssss]

Hey @tylerkaraszewski, I have made this external to get more eyes on this deploy blocker.

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-11-08 13:46:44 UTC.

Proposal


Please re-state the problem that we are trying to solve in this issue.

Search - Unable to select expenses by tapping and holding

What is the root cause of that problem?

• Offending PR: Fix - Android - Hybrid app - Tags - Tapping a tag and quickly long press it shows "select" option in tag page #51818

• isFocused state is used inside SelectionListWithModal and isFocused will be false in Tab.Screen.
  

  App/src/components/SelectionListWithModal/index.tsx

  Line 33 in bd880d1

  const isFocused = useIsFocused();

  
  

  App/src/components/SelectionListWithModal/index.tsx

  Line 82 in bd880d1

  if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || !isFocused) {

What changes do you think we should make in order to solve the problem?


• We can simply revert the PR. I believe the PR was trying to solve a very minor issue that we could ignore.

What alternative solutions did you explore? (Optional)

• We can introduce a prop isScreenFocused in SelectionListWithModal and use it along with isFocused from useIsFocused();.

        if (!turnOnSelectionModeOnLongPress || !isSmallScreenWidth || item?.isDisabled || item?.isDisabledCheckbox || (!isFocused && !isScreenFocused)) {
            return;
        }

• From Search we will pass the isScreenFocused prop.

    const activeCentralPaneRoute = useActiveCentralPaneRoute();
    const isActiveCentralPaneRoute = activeCentralPaneRoute?.name === SCREENS.SEARCH.CENTRAL_PANE;
    // Prop to "SelectionListWithModal"
    isScreenFocused={isActiveCentralPaneRoute}

• We should also check other components which uses SelectionListWithModal.

Result

[FitseTLT]

Looking into this 👀

[FitseTLT]

Will prepare a fix shortly

[Krishna2323]

I think this is already labeled external and we can go through the regular process. I have already prepared couple of solution here.

[FitseTLT]

PR fixing the regression is raised.

[adelekennedy]

@tylerkaraszewski thoughts on this? Can this be worked on externally or do you see that this needs backend support? Also is this a blocker or can we deprioritize this?

[mountiny]

Yep I think that is reasonable, thanks for help urgently addressing this PR review #52278

[adelekennedy]

thank you @mountiny

PR deployed to prod yesterday - payment due on the 18th

Payouts due:

• $250 @c3024 Upwork

[Krishna2323]

I think a 'regression located bounty' is reasonable here. I commented on #50851 (comment). Let me know if you disagree with this being reasonable.

@Julesssss, I respectfully disagree. I've identified the offending PR and also provided a solution, so I believe the payout should be $125, as I haven't opened a PR myself.

Please review these comments: #51885 (comment) #47054 (comment)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP STAGING] Fix long press search page regression #52278

If no regressions arise, payment will be issued on 2024-11-20. 🎊

For reference, here are some details about the assignees on this issue:

• @eVoloshchak requires payment through NewDot Manual Requests
• @c3024 requires payment (Needs manual offer from BZ)

[melvin-bot]

@eVoloshchak / @c3024 @adelekennedy @eVoloshchak / @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[Julesssss]

@Julesssss, I respectfully disagree. I've identified the offending PR and also provided a solution, so I believe the payout should be $125, as I haven't opened a PR myself.

Okay I agree. These regression fix cases are a bit blurry because solutions can be similar, but I am happy to suggest $125 here.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @eVoloshchak owed $250 via NewDot
• ROLE: @c3024 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1854876478688351316/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

Upwork job price has been updated to $125

[Krishna2323]

@adelekennedy, I have already been paid here.

[c3024]

@adelekennedy

I think this is the only payment due here given that other payments were handled elsewhere.

[melvin-bot]

@eVoloshchak, @Julesssss, @adelekennedy, @c3024 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

Upwork job price has been updated to $250

[adelekennedy]

@c3024 will you apply to the job? https://www.upwork.com/jobs/~021854876478688351316

[c3024]

@adelekennedy , applied. Thanks!

[adelekennedy]

Sent!

[c3024]

Accepted!