Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173

Closed
Julesssss opened this issue Aug 9, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Aug 9, 2024

Allow editing of attendees on existing requests. The key changes here are that we need to handle editing on the item row, AttendeeSelectionPage, and ensure the policy violation limit is recalculated. Additionally the backend will be creating a system action message containing the details of the edit so we need to pass the attendees to the EditMoneyRequest API and optimistically create the system action message.

Screenshot 2024-08-09 at 15 50 46

Requirements

  • Implement editing of attendees on existing requests
  • Recalculate the policy violation limit
  • Optimistically show system message on editing the expense attendees

More details can be found here and elsewhere throughout the design document

@Julesssss
Copy link
Contributor Author

Currently held on the above issues, and is a lower priority task

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@Julesssss
Copy link
Contributor Author

Hey @zfurtak @filip-solecki, for now I'm holding this issue, but feel free to make a start once you need more tasks 👍

@melvin-bot melvin-bot bot added the Overdue label Aug 27, 2024
@Julesssss
Copy link
Contributor Author

This will be the last issue worked on.

@melvin-bot melvin-bot bot removed the Overdue label Aug 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 5, 2024
@Julesssss Julesssss changed the title [HIGH] [Attendee Tracking] Create Attendees item row for requests [HIGH] [Attendee Tracking] Create Attendees item row for editing requests Sep 6, 2024
@zfurtak
Copy link
Contributor

zfurtak commented Sep 6, 2024

Hi @Julesssss, can you assign me to this one? 😊

@Julesssss
Copy link
Contributor Author

Sure, done 👍

@SzymczakJ
Copy link
Contributor

FYI I'll be taking this task from Zuzia as she is OOO tomorrow.

@SzymczakJ
Copy link
Contributor

Is there any way to check violation limit for the transaction? The one source would be to take it from transactionViolations object but it's actually given in a string, so if there was another way I would happily use it @Julesssss

@Julesssss
Copy link
Contributor Author

I think for now we will need to use that string. I will create a backend issue for improving this once we are passing the Onyx data back to the client.

@allgandalf
Copy link
Contributor

@Julesssss Can you please give me access to design doc, I am reviewing this PR, my mail is : whogandalf@gmail.com

@Julesssss
Copy link
Contributor Author

Hey @allgandalf. I just invited you

@allgandalf
Copy link
Contributor

Thanks, Can you please clear up on the reviewer for that PR, please check here

@Julesssss
Copy link
Contributor Author

Ah, I see what you mean now.

Switching to @ZhenjaHorbach who has been reviewing and locating bugs in these flows.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 29, 2024
@melvin-bot melvin-bot bot changed the title [HIGH] [Attendee Tracking] Create Attendees item row for editing requests [HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests Oct 29, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 29, 2024
Copy link

melvin-bot bot commented Oct 29, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. 🎊

For reference, here are some details about the assignees on this issue:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Engineering Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

5 participants