-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173
Comments
Currently held on the above issues, and is a lower priority task |
Hey @zfurtak @filip-solecki, for now I'm holding this issue, but feel free to make a start once you need more tasks 👍 |
This will be the last issue worked on. |
Hi @Julesssss, can you assign me to this one? 😊 |
Sure, done 👍 |
FYI I'll be taking this task from Zuzia as she is OOO tomorrow. |
Is there any way to check violation limit for the transaction? The one source would be to take it from transactionViolations object but it's actually given in a string, so if there was another way I would happily use it @Julesssss |
I think for now we will need to use that string. I will create a backend issue for improving this once we are passing the Onyx data back to the client. |
@Julesssss Can you please give me access to design doc, I am reviewing this PR, my mail is : whogandalf@gmail.com |
Hey @allgandalf. I just invited you |
Thanks, Can you please clear up on the reviewer for that PR, please check here |
Ah, I see what you mean now. Switching to @ZhenjaHorbach who has been reviewing and locating bugs in these flows. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-11-05. 🎊 For reference, here are some details about the assignees on this issue:
|
Allow editing of attendees on existing requests. The key changes here are that we need to handle editing on the item row, AttendeeSelectionPage, and ensure the policy violation limit is recalculated. Additionally the backend will be creating a system action message containing the details of the edit so we need to pass the attendees to the EditMoneyRequest API and optimistically create the system action message.
Requirements
More details can be found here and elsewhere throughout the design document
The text was updated successfully, but these errors were encountered: