[$250] Select date in Submission frequency modal gets dismissed modal after reload page

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.18-7
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1723191970067539

Action Performed:

1. Open account settings
2. Open workspaces and choose any workspace
3. In more features turn on Workflows and open it
4. Turn on Delay submissions and open Submission frequency
5. Choose monthly
6. Open date of month
7. Reload this page
8. Select any date

Expected Result:

Back to the Submission frequency modal

Actual Result:

Submission frequency modal gets dismissed

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

web.mov

Recording.432.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b7f48f34dee22a4a
• Upwork Job ID: 1821971631028523622
• Last Price Increase: 2024-08-09
• Automatic offers:
• dukenv0307 | Reviewer | 103496370

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @dukenv0307

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submission frequency modal gets dismissed

What is the root cause of that problem?

When the user reloads the page, the navigation stack is cleared
And the function onSelectDayOfMonth we just call the function Navigation.goBack()

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Lines 68 to 71 in 87c116b

	const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
	Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
	Navigation.goBack();
	};

So it will close that modal

What changes do you think we should make in order to solve the problem?

1. Add fallback route as a param to function Navigation.goBack();

Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? ''));

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Lines 68 to 71 in 87c116b

	const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
	Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
	Navigation.goBack();
	};

2. Do the same with the function Navigation.goBack in the header back button

App/src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx

Line 90 in 87c116b

onBackButtonPress={Navigation.goBack}

What alternative solutions did you explore? (Optional)

[dukenv0307]

@isabelastisser I'm reporter, so I can take this as C+

[BhuvaneshPatil]

that was quick @daledah 🚀

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b7f48f34dee22a4a

[melvin-bot]

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

[wildan-m]

Edited by proposal-police: This proposal was edited at 2024-08-10 10:17:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Select date in Submission frequency modal gets dismissed modal after reload page

What is the root cause of that problem?

We don't send backTo param when navigate to WORKFLOWS_AUTO_REPORTING_MONTHLY_OFFSET

What changes do you think we should make in order to solve the problem?

Key difference with prev proposal:

• Submit backTo to the url

In src/ROUTES.ts add backTo param

    WORKSPACE_WORKFLOWS_AUTOREPORTING_MONTHLY_OFFSET: {
        route: 'settings/workspaces/:policyID/workflows/auto-reporting-frequency/monthly-offset',
        getRoute: (policyID: string, backTo?: string) => getUrlWithBackToParam(`settings/workspaces/${policyID}/workflows/auto-reporting-frequency/monthly-offset`, backTo),
    },

In src/pages/workspace/workflows/WorkspaceAutoReportingFrequencyPage.tsx call navigate with backTo param value

            <MenuItem
                title={translate('workflowsPage.submissionFrequencyDateOfMonth')}
                titleStyle={styles.textLabelSupportingNormal}
                description={getDescriptionText()}
                descriptionTextStyle={styles.textNormalThemeText}
                wrapperStyle={styles.pr3}
                onPress={() => Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_MONTHLY_OFFSET.getRoute(policy?.id ?? '', ROUTES.WORKSPACE_WORKFLOWS_AUTOREPORTING_FREQUENCY.getRoute(policy?.id ?? '')))}

In src/pages/workspace/workflows/WorkspaceAutoReportingMonthlyOffsetPage.tsx read navigateBackTo from route

...
   const onSelectDayOfMonth = (item: WorkspaceAutoReportingMonthlyOffsetPageItem) => {
        Policy.setWorkspaceAutoReportingMonthlyOffset(policy?.id ?? '-1', item.isNumber ? parseInt(item.keyForList, 10) : (item.keyForList as AutoReportingOffsetKeys));
        Navigation.goBack(navigateBackTo);
    };
...

                   <HeaderWithBackButton
                        title={translate('workflowsPage.submissionFrequency')}
                        onBackButtonPress={() => Navigation.goBack(navigateBackTo)}
                    />

Branch for this solution

What alternative solutions did you explore? (Optional)

[dukenv0307]

Thanks for your solutions, both of them are to add fallbackUrl to Navigation.goBack, so I prefer the first one

Let's go with @daledah's proposal

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @MonilBhavsar, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@dukenv0307 This PR is ready for review.

[isabelastisser]

any updates here? @dukenv0307 @daledah

thanks!

[dukenv0307]

The PR was merged 1 week ago @isabelastisser

[isabelastisser]

Thanks for the heads up @dukenv0307! It looks like the payment automation failed.

[isabelastisser]

@daledah, can you please apply for this job in Uprwork or share your Upwork profile here? Thanks!

[daledah]

@isabelastisser My profile is https://www.upwork.com/freelancers/~0138d999529f34d33f thx

[isabelastisser]

Thanks @daledah, I sent you the offer in Upwork now.

[isabelastisser]

@dukenv0307, I processed your payment in Upwork yesterday.
@daledah, please accept the offer and I will process the payment.

All set!

[daledah]

@isabelastisser I accepted it

[isabelastisser]

@daledah, payment approved in Upwork. Thanks!