[HOLD for payment 2024-09-06][Search v2.1] Keep user on Search page if expense is created from Search page

[shawnborton]

Problem

If you are on the Search page and you create an expense, you get taken back to the Inbox page. This is jarring because the user would actually expect to remain on the Search page and see the expense show up in the Search table.

Solution

Let's make it so that if you were on the Search page and you create an expense, you land back on the Search page. We could make it so that you just return to the Search table and see the table populate with the new expense, or we could open up the report or workspace chat in the RHP.

Note: right now we have the ability to open up a report or expense in the RHP on Search but I don't think we can open up a workspace chat in the RHP on the Search page?

cc @Expensify/design @trjExpensify @JmillsExpensify @luacmartins

@trjExpensify - can you file this one where you want it?

Issue Owner

Current Issue Owner: @trjExpensify

[luacmartins]

This is related to #41020, since the nav refactor would have to handle both the RHP and main pane navs

[trjExpensify]

Should we put this in #wave-control then with everything else Search related?

Let's make it so that if you were on the Search page and you create an expense, you land back on the Search page. We could make it so that you just return to the Search table and see the table populate with the new expense, or we could open up the report or workspace chat in the RHP.

Maybe the v1 pre-refactor is landing back on the table with the new expense row created highlighted for emphasis or something?

[shawnborton]

I could totally get down with that as a v1.

[dannymcclain]

Same, I think that'd be nice as a v1.

[luacmartins]

@adamgrzybowski @WojtekBoman since you're more familiar with navigation logic, how involved do you think it'd be to implement this?

[JmillsExpensify]

Zooming out a bit, given the navigation refactors required for this issue, I think I'd still choose prioritizing Search 2.3 and 2.4 ahead of this initiative. Still down to see how "big" of an effort it is regardless though.

[adamgrzybowski]

@luacmartins I did some quick research and we call the dismissModal function with the reportID argument on confirm.

If we call this without argument, the user should stay on the search page.

We can conditionally remove the argument if the topmost central pane is the search page.

[luacmartins]

That sounds good. If it's an easy fix, let's go for it.

[trjExpensify]

Nice, let's do it. ❤️

[JmillsExpensify]

Awesome, agreed

[adamgrzybowski]

Should somebody from SWM or I take care of that?

[luacmartins]

Yea, would love if you could work on this one @adamgrzybowski. You're already assigned to the issue, so please go ahead.

[adamgrzybowski]

@luacmartins ready for review ⬆️

[s77rt]

Can you handle the case when editing report fields as well #47554

[ikevin127]

I dropped a comment in the PR to ask whether we're going to address that issue in the already opened PR before merge.

[adamgrzybowski]

Hey, I added the changes for the EditReportFiledPage.tsx. Can someone please double check that it is working now? Thanks! 🙇

[ikevin127]

Can you handle the case when editing report fields as well #47554

✅ Issue was addressed, tests well #47721 (comment) and PR will be merged soon 🤞

[trjExpensify]

Exciting!

[luacmartins]

Coming from this comment, we should add the new transaction to the list. We don't optimistically create this data in the search Onyx key and we should keep it that way. I think we might need to just trigger a reload of the page given the existing filters may or may not show the new transation.

[trjExpensify]

PR hit staging yesterday, assigning myself for my sins BZ duty.

[luacmartins]

PR was deployed to prod in v9.0.26-6.

[melvin-bot]

@trjExpensify, @luacmartins, @ikevin127, @adamgrzybowski Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Payment is due here!

• $250 to @ikevin127 for the C+ review (offer sent!).

As a follow-up, I think we should consider some kind of highlight/flash of the newly added expense row in the table. Maybe @ikevin127 you'd fancy taking that on?

[trjExpensify]

#48716 - here's the follow up issue I have in planning if you're keen for this one, Kevin.

[ikevin127]

@trjExpensify Offer accepted, thank you!

Sure, I don't mind reviewing the other issue as well ✌️

[trjExpensify]

Oh right, I was more so wondering if you want to hatch a plan and implement it. :)

[ikevin127]

@trjExpensify I can do that as well, will look into the issue today and try to come up with a proposal.

In the meantime, do you mind finalizing the payment on this issue ? I accepted the offer, thank you!

[trjExpensify]

Yep, I just paid it.

[trjExpensify]

will look into the issue today and try to come up with a proposal.

Sounds good, let's chat on the other issue. 👍