[Search v2.1] Keep user on search page if expense is created from Search page #47721

adamgrzybowski · 2024-08-20T14:56:48Z

Details

We check what is the topmost central pane to decide if we want to dismiss with reportID or undefined.

We want to stay on search if this is the topmost central pane page.

Fixed Issues

$ #47179
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

1 Make sure that you are on the inbox tab (you can see a report or report list)
2. Press the + button.
3. Split expense
4. Press the "next" button
5. Select a person and press the "next" button
6. Press the "split" button
7. RHP is closed and you are on the report screen. 🟢

1 Make sure that you are on the search tab
2. Press the + button.
3. Split expense
4. Press the "next" button
5. Select a person and press the "next" button
6. Press the "split" button
7. RHP is closed and you are still on the search page. 🟢

You should test different IOU types e.g. "Track expense", "Submit expense" etc.

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

androidWeb.mp4

iOS: Native

ios.mp4

iOS: mWeb Safari

iosWeb.mp4

MacOS: Chrome / Safari

web.mp4

MacOS: Desktop

desktop.mp4

melvin-bot · 2024-08-20T14:56:53Z

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ikevin127 · 2024-08-20T18:10:32Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.webm

Android: mWeb Chrome

android-mweb.webm

iOS: Native

ios.mp4

iOS: mWeb Safari

ios-mweb.mp4

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

luacmartins

LGTM! NAB should we add isSearchTopmostCentralPane directly into dismissModal? That way we don't need to make the changes everywhere.

ikevin127

🟢 LGTM, tests well on all platforms!

I think the ❌ Jest Unit Tests failing are not related to this PR as I've seen the tests failing on other PRs as well, but I might be wrong.

luacmartins

LGTM

ikevin127 · 2024-08-22T00:42:34Z

@luacmartins We might want to HOLD on merge to address #47179 (comment) if you think it's within scope for this PR.

luacmartins

LGTM

luacmartins · 2024-08-22T14:58:31Z

@adamgrzybowski it seems like the jest failures are related to this PR. I see several of these in the logs:

actions/IOU › deleteMoneyRequest › update the moneyRequestPreview to show [Deleted expense] when appropriate

    TypeError: Cannot read properties of undefined (reading 'getRootState')

       5 |
       6 | const isSearchTopmostCentralPane = (): boolean => {
    >  7 |     const rootState = navigationRef.getRootState() as State<RootStackParamList>;

luacmartins

Let's fix the failing tests

ikevin127 · 2024-08-22T19:17:19Z

@adamgrzybowski Thanks for addressing the report fields issue 🚀 Tests well, fixed the issue:

Video

[| Before | After |
| ------------- | ------------- |
|

Screen.Recording.2024-08-22.at.12.14.25.mov

🟢 Approved once again, ready to merge once the failing tests are addressed 👍

trjExpensify · 2024-08-23T09:55:04Z

CC: @Expensify/design if you want eyes on this one! :)

adamgrzybowski · 2024-08-23T10:28:23Z

@luacmartins tests should be fixed

github-actions · 2024-08-23T10:32:11Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/47721/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/47721/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/47721/NewExpensify.dmg	https://47721.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

shawnborton · 2024-08-23T11:34:02Z

This definitely keeps you on the Search page after you make the expense, but I had to refresh the page to actually see the new expense I just created. Is there a way to make that happen automatically? And bonus - can we somehow highlight (animate or slide) the new expense so it's super obvious it was just added?

luacmartins · 2024-08-23T13:55:59Z

The only way to do that with the search design we have is to trigger another API request which would refresh the search page, since we don't optimistically add/update/delete data in search. So we can trigger the additional request, but that would trigger a loading skeleton, so no animation.

luacmartins

LGTM

luacmartins · 2024-08-23T14:55:31Z

I'll merge this PR as is. I'll add the comments above to the issue.

OSBotify · 2024-08-23T15:13:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-26T23:19:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2024-08-27T00:09:40Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.25-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

keep user on search page if expense is created from Search page

4edc518

adamgrzybowski requested a review from a team as a code owner August 20, 2024 14:56

melvin-bot bot requested review from ikevin127 and removed request for a team August 20, 2024 14:56

luacmartins self-requested a review August 20, 2024 15:26

luacmartins approved these changes Aug 20, 2024

View reviewed changes

ikevin127 approved these changes Aug 20, 2024

View reviewed changes

melvin-bot bot requested a review from luacmartins August 20, 2024 22:50

luacmartins previously approved these changes Aug 21, 2024

View reviewed changes

ikevin127 mentioned this pull request Aug 22, 2024

[HOLD for payment 2024-09-06][Search v2.1] Keep user on Search page if expense is created from Search page #47179

Closed

fix dismissModal on EditReportFiledPage

12ed400

adamgrzybowski dismissed luacmartins’s stale review via 12ed400 August 22, 2024 13:51

luacmartins approved these changes Aug 22, 2024

View reviewed changes

luacmartins requested changes Aug 22, 2024

View reviewed changes

This comment was marked as outdated.

Sign in to view

ikevin127 mentioned this pull request Aug 22, 2024

[$250] Search - App returns to expense report on Inbox after editing report field in Search #47554

Closed

6 tasks

trjExpensify added the Ready To Build label Aug 23, 2024

fix tests

9e1b2db

luacmartins approved these changes Aug 23, 2024

View reviewed changes

luacmartins merged commit 64cdaad into Expensify:main Aug 23, 2024
15 checks passed

github-actions bot mentioned this pull request Aug 26, 2024

Deploy Checklist: New Expensify 2024-08-26 #48035

Closed

ikevin127 mentioned this pull request Oct 4, 2024

[HOLD for payment 2024-10-11] [HOLD for payment 2024-10-10] [$250] [Search v2.2] Reload the page and highlight the newly added expense when adding a new expense from the search page #48716

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Search v2.1] Keep user on search page if expense is created from Search page #47721

[Search v2.1] Keep user on search page if expense is created from Search page #47721

adamgrzybowski commented Aug 20, 2024

melvin-bot bot commented Aug 20, 2024

ikevin127 commented Aug 20, 2024 •

edited

Loading

luacmartins left a comment

ikevin127 left a comment

luacmartins left a comment

ikevin127 commented Aug 22, 2024

luacmartins left a comment

luacmartins commented Aug 22, 2024

luacmartins left a comment

This comment was marked as outdated.

ikevin127 commented Aug 22, 2024

trjExpensify commented Aug 23, 2024

adamgrzybowski commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

shawnborton commented Aug 23, 2024

luacmartins commented Aug 23, 2024

luacmartins left a comment

luacmartins commented Aug 23, 2024

OSBotify commented Aug 23, 2024

OSBotify commented Aug 26, 2024

OSBotify commented Aug 27, 2024

[Search v2.1] Keep user on search page if expense is created from Search page #47721

[Search v2.1] Keep user on search page if expense is created from Search page #47721

Conversation

adamgrzybowski commented Aug 20, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 20, 2024

ikevin127 commented Aug 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

luacmartins left a comment

Choose a reason for hiding this comment

ikevin127 left a comment

Choose a reason for hiding this comment

luacmartins left a comment

Choose a reason for hiding this comment

ikevin127 commented Aug 22, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Aug 22, 2024

luacmartins left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

ikevin127 commented Aug 22, 2024

trjExpensify commented Aug 23, 2024

adamgrzybowski commented Aug 23, 2024

github-actions bot commented Aug 23, 2024

shawnborton commented Aug 23, 2024

luacmartins commented Aug 23, 2024

luacmartins left a comment

Choose a reason for hiding this comment

luacmartins commented Aug 23, 2024

OSBotify commented Aug 23, 2024

OSBotify commented Aug 26, 2024

OSBotify commented Aug 27, 2024

ikevin127 commented Aug 20, 2024 •

edited

Loading