[Workspace Feeds] Web - Card - Added bank account isn't showing for Expensify Card

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Can't check
Issue was found when executing this PR #46860
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Expensifail account
3. Create a workspace
4. Navigate to Workspace settings - More features
5. Enable "Expensify Card"
6. Enable "Workflows"
7. Navigate to Workflows - Connect bank account
8. Add Regions bank with plaid
9. Navigate to Workspace settings - Expensify Card
10. Click on the "Issue new card" button

Expected Result:

I should be able to see and choose the existing bank account.

Actual Result:

Added bank account isn't showing for Expensify Card. I can add the missing bank account if I go a step further and click on "Add a new bank account". The bank account also shows up after a relog.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6569878_1723469823410.bandicam_2024-08-12_15-24-30-297.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 2

[mountiny]

@IuliiaHerets Can you please check if this is reliably repro by other testers or across platforms?

cc @koko57 @VickyStash for viz

[mountiny]

Happy to take over Robert if you want

[IuliiaHerets]

@mountiny As soon as the team has checked, I'll get back to you with an answer

[koko57]

looks like the same root cause like in this one: #45729
so either we don't receive a properly formatted data or the account is not eligible (but in the second case we should be redirected to VBBA, it should have been fixed by my last merged PR #46564)

[IuliiaHerets]

@mountiny QA Team still can reproduce the issue on different platforms (Web, iOS app, Android app). Build - v9.0.19-9

DFVL1178.MP4

bandicam.2024-08-13.12-04-39-384.mp4

az_recorder_20240813_121312.mp4

[koko57]

The problem is definitely with the format we get from AcceptACHContractForBankAccount and OpenPaymentsPage API calls - we don't get a bank account with type and allowDebit properties - that's why we get an empty list. Before we've filtered out eligible bank account we had the problem described in this issue #45729

here's how we get the data for AcceptACHContractForBankAccount

and for OpenPaymentsPage

We could possibly call OpenPaymentsPage when we click Issue New Card, but it would be much better to unify how the data is sent from the backend and maybe change the onyx method in the OpenPaymentsPage from set to merge

cc @mountiny

[mountiny]

I will have a look thanks!

[mountiny]

PR is up here https://github.com/Expensify/Auth/pull/12043 that should start returning these properties

[mountiny]

@koko57 @DylanDylann @allgandalf could you please retest this? Now the AcceptACHContractForBankAccount should return the bank account with the type and allowDebit too

[koko57]

I will retest it today

[koko57]

@mountiny
So this issue is solved - we get type and allowDebit and the account is showing in the account list.

We still have the #45729 problem, because we still don't get accountNumber in the AcceptACHContractForBankAccount. But this can be solved by using mask property from additionalData.

cc @s77rt

[melvin-bot]

@abekkala, @mountiny Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@abekkala, @mountiny Still overdue 6 days?! Let's take care of this!

[mountiny]

@koko57 The backend changes for this are deployed now, can you check if you can still repro your issue?

[koko57]

@mountiny accountNumber is sent now but not the same way it is sent in OpenPaymentsPage - we get this in accountData in OpenPaymentsPage when in AcceptACHContractForBankAccount in the bankAccount object

[mountiny]

@koko57 damn ok updating this, I must have mixed it up in the previous screenshots.

[koko57]

@mountiny please let me know when it's ready to retest

[mountiny]

@koko57 This is ready to test, can you please have a look?

[koko57]

Confirming it's working - bank account is showing after adding it.

cc @mountiny

[mountiny]

So I believe we can close this one now, thank you for confirming