-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Clean up] Update the OpenPaymentsPage command to return bank details and card details from Auth #47944
Comments
Triggered auto assignment to @kadiealexander ( |
This is just a polish |
@mountiny @kadiealexander this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Not focusin gon this yet as its just polish |
Havent got around yet |
This issue has not been updated in over 15 days. @nkuoch, @kadiealexander eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
@nkuoch not sure now, but is this fully completed? Or do we have one PR left? |
I need to do 1 last cleanup to remove the transition code. OOO this week. So will do it on tuesday |
Thank you for clarifying |
Ah no, I also need to migrate fundList, userWallet and cardList formatting auth side. On it! |
le legende |
this is done I believe |
Problem
We are massaging the response data for the
OpenPaymentsPage
in Web. We end up sending the card details and bank account details in a different format than in other Auth commands, which leads to confusion. Example is here #47239 where the allowDebit, bank accounttype
and accountNumber were missing in response from theAcceptACHContractForBankAccount
command### Solution
Start returning the card and bank account details for OpenPaymentsPage from Auth so we can use the same methods as we do in other commands like in OpenCardDetailsPage
The text was updated successfully, but these errors were encountered: