[hold for payment 2024-08-27] [$250] Distance -Distance rate is not grayed out after editing "Tax rate" & "Tax reclaimable" offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.19-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4849591
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• Tax is enabled.
• Distance rates are enabled.
• Track tax in DIstance rates is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings.
3. Go to Distance rates.
4. Go offline.
5. Tap on any rate.
6. Edit "Tax rate" and "Tax reclaimable on".
7. Return to distance rate list.

Expected Result:

The distance rate will be grayed out after editing "Tax rate" or "Tax reclaimable on" offline.

Actual Result:

The distance rate is not grayed out after editing "Tax rate" or "Tax reclaimable on" offline.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6570933_1723555038821.20240813_211339.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01495987645fc6b7df
• Upwork Job ID: 1823734401301545382
• Last Price Increase: 2024-08-14
• Automatic offers:
• ikevin127 | Reviewer | 103534987
• FitseTLT | Contributor | 103534988

Issue Owner

Current Issue Owner: @ikevin127

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[FitseTLT]

Edited by proposal-police: This proposal was edited at 2024-08-13 14:31:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance rate is not grayed out after editing "Tax rate" & "Tax reclaimable" offline

What is the root cause of that problem?

Here we are missing taxClaimablePercentage and taxRateExternalID

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 115 to 120 in cc2efc6

	pendingAction:
	value.pendingAction ??
	value.pendingFields?.rate ??
	value.pendingFields?.enabled ??
	value.pendingFields?.currency ??
	(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

What changes do you think we should make in order to solve the problem?

We need to add pendingFields taxClaimablePercentage and taxRateExternalID to the checks here

App/src/pages/workspace/distanceRates/PolicyDistanceRatesPage.tsx

Lines 115 to 120 in cc2efc6

	pendingAction:
	value.pendingAction ??
	value.pendingFields?.rate ??
	value.pendingFields?.enabled ??
	value.pendingFields?.currency ??
	(policy?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD ? policy?.pendingAction : undefined),

                        value.pendingFields?.taxRateExternalID ??
                        value.pendingFields?.taxClaimablePercentage ??

What alternative solutions did you explore? (Optional)

[joekaufmanexpensify]

Reproduced. I also verified that we generally do grey out the main option row if there is an offline change to a setting associated with it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01495987645fc6b7df

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[ikevin127]

@FitseTLT's proposal LGTM. The RCA is correct and the proposed solution fixes the issue according to the Expected result.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @flodnv, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[joekaufmanexpensify]

@FitseTLT is there an ETA for PR here?

[joekaufmanexpensify]

PR pending

[FitseTLT]

PR ready

[joekaufmanexpensify]

TY! I see it's merged now

[ikevin127]

⚠️ PR was just deployed to production ~10 minutes ago but automation failed to add the hold -> this should be on [HOLD for Payment 2024-08-27] according to today's production deploy from #47591 (comment).

cc @joekaufmanexpensify

[joekaufmanexpensify]

Sounds good!

[joekaufmanexpensify]

Payments here are:

• $250 to @FitseTLT for PR via upwork.
• $250 to @ikevin127 for C+ via upwork.

[joekaufmanexpensify]

All set to issue payment!

[joekaufmanexpensify]

@FitseTLT $250 sent and contract ended!

[joekaufmanexpensify]

@ikevin127 $250 sent and contract ended!

[joekaufmanexpensify]

Upwork job closed.

[joekaufmanexpensify]

All set, thanks everyone!