Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2024-09-23] Make medium the default button size #47454

Closed
luacmartins opened this issue Aug 14, 2024 · 13 comments
Closed

[HOLD for payment 2024-09-23] Make medium the default button size #47454

luacmartins opened this issue Aug 14, 2024 · 13 comments
Assignees
@luacmartins @adelekennedy @mkhutornyi
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Aug 14, 2024 •
edited
Loading

Coming from here, medium should be our default button size

Issue OwnerCurrent Issue Owner: @adelekennedy
Issue OwnerCurrent Issue Owner: @adelekennedy
@luacmartins luacmartins added the Daily KSv2 label Aug 14, 2024
@luacmartins luacmartins self-assigned this Aug 14, 2024
@luacmartins luacmartins mentioned this issue Aug 14, 2024
Merged
50 tasks
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Aug 14, 2024
@luacmartins luacmartins added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 14, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 14, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Aug 14, 2024
@luacmartins luacmartins added the Internal Requires API changes or must be handled by Expensify staff label Aug 14, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 22, 2024

@luacmartins, @adelekennedy, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 26, 2024

@luacmartins, @adelekennedy, @mkhutornyi Still overdue 6 days?! Let's take care of this!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Aug 28, 2024

@luacmartins, @adelekennedy, @mkhutornyi Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@mkhutornyi
Copy link
Contributor

@luacmartins is working on PR

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 5, 2024

@luacmartins, @adelekennedy, @mkhutornyi Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 9, 2024

@luacmartins, @adelekennedy, @mkhutornyi Still overdue 6 days?! Let's take care of this!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 11, 2024

@luacmartins, @adelekennedy, @mkhutornyi Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 13, 2024

@luacmartins, @adelekennedy, @mkhutornyi 10 days overdue. I'm getting more depressed than Marvin.

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 14, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot removed the Daily KSv2 label Sep 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Sep 18, 2024

This issue has not been updated in over 14 days. @luacmartins, @adelekennedy, @mkhutornyi eroding to Weekly issue.

@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 18, 2024
@adelekennedy adelekennedy added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 1, 2024
@adelekennedy
Copy link

This was deployed to prod on the 16th I think payment is due here for @mkhutornyi - sent offer on Upwork

@luacmartins luacmartins changed the title Make medium the default button size [HOLD for payment 2024-09-23] Make medium the default button size Oct 1, 2024
@luacmartins luacmartins removed the Reviewing Has a PR in review label Oct 1, 2024
@melvin-bot melvin-bot bot added the Overdue label Oct 1, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Oct 1, 2024
@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 1, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 4, 2024
@mkhutornyi
Copy link
Contributor

@adelekennedy I haven't received payment yet.
Reason: https://expensify.slack.com/archives/C01GTK53T8Q/p1728319262830679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luacmartins luacmartins

@adelekennedy adelekennedy

@mkhutornyi mkhutornyi

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@luacmartins @adelekennedy @mkhutornyi