Bank account - "Continue setup" text is smaller than "Start over"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #49173
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace settings > Workflows.
3. Click Connect bank account > Connect manually.
4. Proceed the set up and quit it halfway.
5. Click Connect bank account.

Expected Result:

"Continue setup" will have the same font style as "Start over".

Actual Result:

"Continue setup" text is smaller than "Start over".
On production, it uses "Continue with setup" instead of "Continue setup"
This issue also happens in "Yes, let's chat" button during bank account setup.

Workaround:

Unknoown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6603147_1726286520680.20240914_115825.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Bank account - "Continue setup" text is smaller than "Start over"

What is the root cause of that problem?

large prop is not passed to the Button component.

App/src/pages/ReimbursementAccount/ContinueBankAccountSetup.tsx

Lines 64 to 74 in 0c618ac

	<Button
	iconStyles={[styles.customMarginButtonWithMenuItem]}
	text={translate('workspace.bankAccount.continueWithSetup')}
	onPress={onContinuePress}
	icon={Expensicons.Bank}
	style={[styles.mv4]}
	shouldShowRightIcon
	innerStyles={[styles.pr2, styles.pl4, styles.h13]}
	success
	isDisabled={!!pendingAction || !isEmptyObject(errors)}
	/>

What changes do you think we should make in order to solve the problem?


Pass large prop to the Button component.

What alternative solutions did you explore? (Optional)

Result

[ishpaul777]

IMO not a blocker very minor issue, this file is not even changed in a while so not sure if its even a bug

[CyberAndrii]

Offending PR: #47238

[mountiny]

cc @luacmartins @mkhutornyi as the offending PR

[luacmartins]

PR up #49237

[luacmartins]

Fixed on staging