[$250] Workflows - Back button on workspace editor reopens Workflows after adding workflow

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.20-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

Precondition:

• Workspace is under Control plan.
• Workspace has a few members.

1. Launch New Expensify app.
2. Go to workspace settings > Workflows.
3. Tap Add approval workflow.
4. Go through the setup and tap Add workflow on the confirmation page.
5. On Workflows page, tap on app back button.
6. On workspace editor page, tap on app back button.

Expected Result:

App will return to workspace list.

Actual Result:

App reopens Workflows page when tapping on back button on workspace editor page after adding workflow.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6572333_1723664222742.w_57b3cc356d3fcdff84e08e75aed1e34f10be7b0b-2024-08-14_19_31_55.679.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0122ee0f611f968eaa
• Upwork Job ID: 1824121720115141860
• Last Price Increase: 2024-08-22

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

We think this issue might be related to the #wave-control

[izarutskaya]

Production

Screen_Recording_20240814_225656_Chrome.mp4

[tgolen]

This feature is behind a beta so I am removing the feature flag cc @blazejkustra @DylanDylann

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After submitting a new approval workflow, pressing back from the workspace reopens the workflow page again.

What is the root cause of that problem?

When we are creating a new approval workflow, we go from selecting members step -> selecting approver step. At this point, the rhp nav stack is: [select member, select approver]. When we go next again, both screens are removed and replaced with the confirmation page.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 186 to 188 in 57ef25c

	if (approvalWorkflow?.action === CONST.APPROVAL_WORKFLOW.ACTION.CREATE) {
	Navigation.goBack();
	Navigation.navigate(ROUTES.WORKSPACE_WORKFLOWS_APPROVALS_NEW.getRoute(route.params.policyID), CONST.NAVIGATION.TYPE.UP);

So, the confirm page will be the only one in the RHP stack. When we submit the confirmation, the app will call goBack with a fallback to the workflow page.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsCreatePage.tsx

Lines 47 to 48 in 57ef25c

	Workflow.createApprovalWorkflow(route.params.policyID, approvalWorkflow);
	Navigation.goBack(ROUTES.WORKSPACE_WORKFLOWS.getRoute(route.params.policyID));

Because the confirm page is the only screen in the RHP, the confirm page will be replaced with the fallback route, so there is a duplicate workflow page in the nav stack.

This happens too if we refresh the page while on the confirm page.

What changes do you think we should make in order to solve the problem?

We should remove the fallback route, so till be just goBack().

It's the same as we did when editing the approval.

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsEditPage.tsx

Lines 53 to 54 in 57ef25c

	Workflow.updateApprovalWorkflow(route.params.policyID, approvalWorkflow, membersToRemove);
	Navigation.goBack();

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0122ee0f611f968eaa

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[DylanDylann]

@blazejkustra it seems this relates to the navigation bug that we discussed before. Should we want to take over this one with a navigation bug here

cc @JmillsExpensify

[shubham1206agra]

@DylanDylann I am not sure that the fix will be simple since I encountered this problem before too. And @bernhardoj's proposal fixes the issue without any side effects. So lets go with that right now.

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @blimpich is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[shubham1206agra]

@DylanDylann Thread for reference https://expensify.slack.com/archives/C01GTK53T8Q/p1719319215720149

[DylanDylann]

@shubham1206agra @bernhardoj You mean that we should remove naviagte function and only use goBack, right?

[shubham1206agra]

No remove fallback route

[DylanDylann]

When we are creating a new approval workflow, we go from selecting members step -> selecting approver step. At this point, the rhp nav stack is: [select member, select approver]. When we go next again, both screens are removed and replaced with the confirmation page.

@tgolen @blazejkustra I believe that this bug has the same RCA as the navigation bug that we discussed in previous PR

@blimpich @shubham1206agra Maybe the navigation in the approval workflow feature will be updated soon and this bug will no longer reproduce. Let's wait for a thought from @blazejkustra

[blazejkustra]

I agree with @DylanDylann, let's wait with this issue for now.

[isabelastisser]

On hold!

[DylanDylann]

Hold: #47697

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[blazejkustra]

Should be resolved now with #47845 merged

[blimpich]

@shubham1206agra @bernhardoj are either of you able to reproduce the issue here?

[bernhardoj]

It's not reproducible anymore.

[isabelastisser]

Thanks for confirming, @bernhardoj! Closing this.