Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search - To field shows fallback avatar without name when submitting expense as employee #47551

Closed
6 tasks done
IuliiaHerets opened this issue Aug 16, 2024 · 12 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@IuliiaHerets
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.21-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User is invited to the workspace.
  • The following steps will be performed by the invited user.
  1. Go to staging.new.expensify.com
  2. Go to the workspace chat.
  3. Submit an expense.
  4. Go to Search.
  5. Note the receiver in To field.

Expected Result:

The receiver in To field will show the name and avatar of the workspace admin.

Actual Result:

The receiver in To field does not show name and it shows fallback avatar.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6573672_1723793471674.20240816_152719.mp4

View all open jobs on GitHub

@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 16, 2024
Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @grgia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 16, 2024

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 16, 2024
@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 16, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@daledah
Copy link
Contributor

daledah commented Aug 16, 2024

This is a BE issue.

Since PR #47424, we decided to show the workspace's approver/admin info in the receiver column instead of workspace info. And that's based on managerID.

const to = data.personalDetailsList?.[transactionItem.managerID];

The snapshot data from BE is missing personalDetailsList data for those managerIDs.

@rayane-djouah
Copy link
Contributor

cc @luacmartins

@grgia grgia added Internal Requires API changes or must be handled by Expensify staff and removed DeployBlockerCash This issue or pull request should block deployment labels Aug 16, 2024
@grgia
Copy link
Contributor

grgia commented Aug 16, 2024

Removing deploy blocker label given

The snapshot data from BE is missing personalDetailsList data for those managerIDs.

@grgia grgia added Daily KSv2 and removed Hourly KSv2 labels Aug 16, 2024
@grgia
Copy link
Contributor

grgia commented Aug 16, 2024

Could you confirm @luacmartins

@luacmartins luacmartins assigned luacmartins and unassigned grgia Aug 16, 2024
@luacmartins
Copy link
Contributor

Yea, it seems like we're missing the managerID details for the report. I wonder if this happens with open reports. I'll look into this on Monday when I'm back from ooo.

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

@luacmartins, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

@Christinadobrzyn
Copy link
Contributor

Hi @luacmartins can you provide an update for Melvin?

@melvin-bot melvin-bot bot removed the Overdue label Aug 20, 2024
@luacmartins
Copy link
Contributor

This was fixed here. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants