Deploy Checklist: New Expensify 2024-08-15

[github-actions]

Release Version: 9.0.21-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

• feat: empty ui for create flows #42413
• fix: Skeleton and arrow appears when login via concierge #45460
• Refactor UpdatePolicyConnectionConfiguration to be 1:1:1 (Part 1) #46234
• Navigate to singleExpenseReport #46324
• Update eslint config package #46625
• fix: billing card currency form wait until request has finished before closing #46635
• navigate back to report details on back from group name #46702
• Update held transactions styles #46754
• perf: Improve get icons #46886
• Using useOnyx to get session #46932
• fix: inconsistent Navigation After Creating Workspace #46939
• [Search] Add From & To advanced filters #46962
• fix: Numbers are displayed when editing an email mention #47024
• fix: Remove member confirmation is same for approver as well as member #47026
• fix: Android web is giving option to record audio and video #47028
• fix: report title is incorrect for IOU grouped expense in search page #47029
• fix: prevent user from editing receipt #47031
• Sage intacct offline error patterns #47079
• Add new error message in selection pages #47091
• Feature: Integrate OpenPolicyEditCardLimitTypePage api command to the app #47092
• Fix tax rate and amount are empty when creating split distance #47128
• fix: remove accent char check for legal name #47130
• fix: NetSuite - 'Select existing' invoice item option isn't highlighted when selected. #47144
• fix: markdown parser cause ios crash #47199
• Fix - Incorrect member count in report details after commenting or inviting another member #47207
• Fix When we set description of a room for the first time, optimistically it is shown as a comment in the LHN and later updates to system message  #47208
• Fix/ date picker on confirmation page does not show the selected date #47210
• fix: Not here page displayed in the background after a refresh #47212
• fix: update transaction filename in getTrackExpenseInformation #47216
• [No QA] Clarify pattern B errors behavior #47221
• feat: show last message while loading others #47243
• fix: LHN missing space #47268
• Delete docs/articles/new-expensify/connections/xero/Xero-Troubleshooting #47284
• Update Xero-Troubleshooting.md #47285
• Add images to repo for updated QBO and Xero docs #47286
• fix: Individual workspace is in 'Send from' field #47288
• fix: Preferred exporter check-mark is missing #47290
• fix: Selecting yourself as the assignee should default Share somewhere to your self-DM #47291
• Fix: Track expense - Report View Briefly Displayed for Single Expense #47330
• [No QA] Implement OpenCardDetailsPage api call #47333
• Fix/unaccessible chat stuck in lhn #47340
• Use Share instead of Share Somewhere #47361
• fix: Mark down format is not copied from description system message with mark down #47365
• Revert "Update held transactions styles" #47368
• fix: split into 2 sections if multiple selection is allow #47386
• fix: prevent user from renaming duplicate name tags #47388
• [No QA] Implement UpdateExpensifyCardTitle API call #47394
• fix: update safe padding bottom style #47395
• Update held transactions styles #47397
• Fix UI allowing edits by submitters to paid reports in Control #47398
• Fullstory unmask Web all components. #47401
• cleanup: remove unused betas params #47419
• Show user instead of workspace #47424
• Adding MLT tag files to help site #47436
• Show primary workspace chat first when creating expense #47437
• fix notification preference issue in offline mode #47450
• Add 'eyeroll' keyword to emoji list for rolling_eyes #47477
• Open enable payments URL in external browser on desktop app #47492
• [CP Staging] fix: Workspace switcher - Empty workspace switcher does not have 'Create a workspace' modal. #47527
• [No QA] Fix prod deploy GitHub comments #47530
• [CP Staging] Prevent overflow empty UI and space above skeleton #47555
• [CP Staging] Fix headerMessage wrapper render logic #47634

Deploy Blockers:

• Submit expense - Empty space between input field and loading skeleton in participant list #47524
• [Awaiting payment some time in the past] [$250] Workspace switcher - Empty workspace switcher does not have "Create a workspace" modal #47525
• Search - Own email address is displayed twice on /search/filters page #47537
• Search-Expense report opens instead of transaction thread when expense with comment is deleted #47538
• Search - To field shows fallback avatar without name when submitting expense as employee #47551
• Illustration gets hidden behind the search field #47553
• Android- Subscription -Unable to Change Payment Card and Currency #47557
• [$125] Workspace switcher - Back button returns to Inbox when creating new workspace in Search page #47562
• [HOLD for payment 2024-08-26] Workspace switcher - Huge gap between "Create a workspace" modal and "Workspaces" title #47601

Deployer verifications:

• I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
• I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
• I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

[OSBotify]

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.0.21-0 🚀

[grgia]

demoted #47551 as it's internal

[mvtglobally]

Regression
Crit/High TCs - 95% completed
Med/Low TCs - 0% completed

PRs:
#46324 - Failing with #45408
#46635 is failing with #47557
#46939 is failing with KI #46816. repro in PROD, checking off
#47028 - Failing with #46336
#47091 - Pass-bug only on iOS with #47550. checking off
#47092 - Pending validation on all platforms
#47144 - Pass-bug on Android/iOS only with known issue #46228 checking off
#47243 - Pending validation on IOS
#47288 is failing #47572
#47340 - Pending validation on all platforms
#47368 & #47397 seem to be conflicting. Which one should we QA?
#47450 - Failing with original KI #44829 on Web/mWeb/Desktop. Pending validation on IOs and Android
#47527 - Pending validation on all platforms

Blockers
#47524
#47525
#47538
#47553
#47557

[Beamanator]

#47538 was demoted

[Beamanator]

#47557 was closed as NAB 👍

[Beamanator]

#47368 & #47397 seem to be conflicting. Which one should we QA?

I commented in #47397 that we should QA #47397, NOT #47368 👍 so I'll check #47368 off the list

[mvtglobally]

Regression
Crit/High TCs - 100% completed
Med/Low TCs - 70% completed

[Beamanator]

#47525 marked NAB (probably b/c it was fixed in #47527 which was CP'd

[Beamanator]

Checking off #46635 b/c its blocker was marked NAB

[Beamanator]

Similarly, checking off #46324 b/c its blocker (#47538) was marked nAB

[Beamanator]

Checking off #47288 b/c the bug it's failing with (#47572) is reproducible in prod

[mvtglobally]

Regression
Crit/High TCs - 100% completed
Med/Low TCs - 95% completed

[mvtglobally]

Regression is completed

PRs:
#47028 - Failing with #46336
#47092 - Can you pls QA internally?
#47340 - Pending validation on Web
#47555 - Pending validation on all platforms

Blockers
#47524
#47553
#47601

[Beamanator]

#47553 fixed by #47555

• Only checking off the deploy blocker b/c the PR is also supposed to fix a 2nd blocker

[Beamanator]

#47524 was also fixed by #47555 - checking both off!

[Beamanator]

#47028 doesn't look like it caused a new bug, it just didn't completely solve the bug it was trying to fix - so we can check it off

• I commented in the issue, asking if there was any bigger issue found, but it doesn't look like it

[Beamanator]

Just saw that #47092 can be checked off!

[Beamanator]

Checking off #47450 as well b/c it doesn't cause new bugs, it just didn't quite fix the original bug & notification preference structure (in Onyx) is currently being updated anyway

[Beamanator]

QA verified in slack here that #47397 passed on all platforms! checking it off!

[Beamanator]

#47340 confirmed working in web & all other platforms here

[Beamanator]

#47562 was demoted, checking it off

[luacmartins]

Checking #47601 off. Fixed in staging!

[Beamanator]

Looking good! shipping!

[Beamanator]