Submit expense - Empty space between input field and loading skeleton in participant list

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.21-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Submit expense > Manual
3. Enter amount
4. Click Next

Expected Result:

There should not be empty space between input field and the loading skeleton in participant list.

Actual Result:

There is empty space between input field and the loading skeleton in participant list.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

ecc4.1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @AndrewGable (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

Production:

98.1.mp4

[lanitochka17]

We think that this bug might be related to #vip-vsp

[AndrewGable]

Ah OK so it seems like this space

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Submit expense - Empty space between input field and loading skeleton in participant list

What is the root cause of that problem?

The condition to render the header message is incorrect, it renders the header message element even if flattenedSections.allOptions.length === 0 is true.

App/src/components/SelectionList/BaseSelectionList.tsx

Lines 690 to 694 in 5b83a4b

	{(((!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound')) && !!headerMessage) || flattenedSections.allOptions.length === 0) && (
	<View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}>
	<Text style={[styles.textLabel, styles.colorMuted]}>{headerMessage}</Text>
	</View>
	)}

What changes do you think we should make in order to solve the problem?

We should only render the content when !!headerMessage is true.

                    {(!isLoadingNewOptions || headerMessage !== translate('common.noResultsFound') || flattenedSections.allOptions.length === 0) && !!headerMessage && (
                        <View style={headerMessageStyle ?? [styles.ph5, styles.pb5]}>
                            <Text style={[styles.textLabel, styles.colorMuted]}>{headerMessage}</Text>
                        </View>
                    )}

What alternative solutions did you explore? (Optional)

[AndrewGable]

@mountiny @tienifr @allroundexperts - Seems like this is a regression from #42413

[tienifr]

I'll raise the PR fix in a hour

[Beamanator]

Looks like this was fixed in staging! https://expensify.slack.com/archives/C01GTK53T8Q/p1724077613257529?thread_ts=1723755541.991329&cid=C01GTK53T8Q

[Beamanator]

closing b/c PR author & C+ were on the original PR that caused the regression (no payment needed)