[$125] Workspace switcher - Back button returns to Inbox when creating new workspace in Search page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.21-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Search
3. Open workspace switcher
4. Click on the create workspace button
5. Click on the app back button

Expected Result:

App will return to Search page with workspace switcher panel opened

Actual Result:

App returns to Inbox page with workspace switcher panel opened

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6573301_1723754483501.20240816_042927.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017ecb2af50a3c8e0d
• Upwork Job ID: 1825547542380258833
• Last Price Increase: 2024-09-24

Issue Owner

Current Issue Owner: @parasharrajat

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

We think that this bug might be related to #vip-vsp

[cead22]

App returns to Inbox page with workspace switcher panel opened

I'm not sure this is the expected behavior, so we should confirm on slack. I think the right label to apply here would be DeployBlockerCash and not DeployBlocker

[melvin-bot]

Triggered auto assignment to @stitesExpensify (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[cead22]

I don't think this should block the App deploy either, cc @chiragsalian

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~017ecb2af50a3c8e0d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[Krishna2323]

Edited by proposal-police: This proposal was edited at 2024-08-19 15:40:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace switcher - Back button returns to Inbox when creating new workspace in Search page

What is the root cause of that problem?

• The active route is always /workspace-switcher.
  

  App/src/pages/WorkspaceSwitcherPage/WorkspacesSectionHeader.tsx

  Lines 35 to 38 in 9cfe9c1

  	onPress={() => {
  	const activeRoute = Navigation.getActiveRouteWithoutParams();
  	interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt('', '', false, false, activeRoute));
  	}}

What changes do you think we should make in order to solve the problem?

We should check if the topmost central pane is search screen, if true we will update the active route.

                    onPress={() => {
                        let activeRoute = Navigation.getActiveRouteWithoutParams();
                        const topmostCentralPaneRoute = getTopmostCentralPaneRoute(navigationRef.getRootState() as State<RootStackParamList>);
                        if (topmostCentralPaneRoute?.name === SCREENS.SEARCH.CENTRAL_PANE) {
                            const currentSearchParams = getCurrentSearchParams();
                            if (currentSearchParams) {
                                const {q, ...rest} = currentSearchParams;
                                const policy = PolicyUtils.getPolicy(currentSearchParams?.policyIDs);
                                activeRoute = ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: q, ...rest, policyIDs: policy ? currentSearchParams?.policyIDs : undefined});
                            }
                            activeRoute = ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: CONST.SEARCH.TAB.EXPENSE.ALL});
                        }
                        interceptAnonymousUser(() => App.createWorkspaceWithPolicyDraftAndNavigateToIt('', '', false, false, activeRoute));
                    }}

We can create a util function to check topmostCentralPaneRoute and create workspace, the function should be used everywhere we need to check for topmostCentralPaneRoute.

What alternative solutions did you explore? (Optional)

We can update the /workspace-switcher route to also include backTo param, and when navigating to /workspace-switcher we will pass the activeRoute to /workspace-switcher route function and then to createWorkspaceWithPolicyDraftAndNavigateToIt.

Result

Monosnap.screencast.2024-08-20.01-03-34.mp4

[greg-schroeder]

Thanks @parasharrajat, let me know where you land

[parasharrajat]

Still debugging this.

[greg-schroeder]

Sounds good

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Rajat is still debugging

[parasharrajat]

Couldn't spend time on it yesterday. I will analyze this further on the weekend.

[melvin-bot]

@parasharrajat @greg-schroeder this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[greg-schroeder]

Rajat will get to this during the week

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[greg-schroeder]

Bump @parasharrajat :)

[greg-schroeder]

Bump @parasharrajat

[parasharrajat]

@greg-schroeder Thanks for the bump. I looked into the proposal and issue. It seems to be much more involved than I expected. I am worried about touching the navigation code which affects the whole app. Let me see what is best here.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@parasharrajat, @greg-schroeder Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tushar-a-b]

Proposal Updated

• Added an alternative solution that avoids modifying the navigation code.

[greg-schroeder]

Still in proposal review

[melvin-bot]

@parasharrajat, @greg-schroeder 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[greg-schroeder]

#vip-vsb is now fully paused/closed, so I'm going to close this as it doesn't really fit in #newdot-quality or any other active project.