-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Xero-Troubleshooting.md #47285
Conversation
Adding contents to Xero-Troubleshooting Help Site page, as discussed in this GH - Expensify/Expensify#413228
@yuwenmemon Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://9f25469a.helpdot.pages.dev ⚡️ |
@yuwenmemon could you please review this? 🙏 |
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
docs/articles/new-expensify/connections/xero/Xero-Troubleshooting.md
Outdated
Show resolved
Hide resolved
Yuwen has just returned from ooo so I'm reassigning this |
@ Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@VictoriaExpensify I'm confused... I just reviewed this 😄 |
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
I'm so sorry @yuwenmemon ! I have definitely created confusion here. Please ignore my comment about reassigning 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some more edits to apply from my review.
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
…ing.md Co-authored-by: Yuwen Memon <yuwen@expensify.com>
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.0.21-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.0.21-4 🚀
|
Adding contents to Xero-Troubleshooting Help Site page, as discussed in this GH - https://github.com/Expensify/Expensify/issues/413228
Details
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop