[HOLD for payment 2024-08-29] iOS - Expense report jumps when returning from transaction thread

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.22-3
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47096
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit three expenses with receipt.
4. Tap on the expense preview to go to expense report.
5. Tap on the first expense preview to go to transaction thread.
6. Tap on the back button.

Expected Result:

The expense report will not jump when returning from transaction thread.

Actual Result:

The expense report jumps when returning from transaction thread.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6576348_1724092355663.ScreenRecording_08-20-2024_02-24-42_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[ishpaul777]

This is very minor issue, possibly from a PR #47096 @kirillzyusko and me worked on, i dont think this needs be a deployblocker we can work on it as a follow up.

[arosiclair]

This is very minor issue, possibly from a PR #47096 @kirillzyusko and me worked on, i dont think this needs be a deployblocker we can work on it as a follow up.

Agreed this is super minor. Removing the label and assigning you @ishpaul777

[arosiclair]

Also assigning @marcochavezf since you were managing the bug for #47096

[ishpaul777]

please assign @kirillzyusko as well also i think we are going to revert the PR #47669 so we might just close it if its resolved with revert

[dylanexpensify]

@ishpaul777 we need @kirillzyusko to comment here to do so, once done - we will assign

[ishpaul777]

ah.. got it 👍

[neil-marcellini]

@IuliiaHerets @marcochavezf the revert is done, would you please test on staging and confirm it's fixed?

[IuliiaHerets]

@neil-marcellini Issue was fixed, not repro already

ScreenRecording_08-21-2024.00-20-14_1.MP4

[kirillzyusko]

we need @kirillzyusko to comment here to do so

Commenting to be assigned 👋

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.23-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "fix: use KeyboardAvoidingView from react-native-keyboard-controller" #47669

If no regressions arise, payment will be issued on 2024-08-29. 🎊

For reference, here are some details about the assignees on this issue:

• @kirillzyusko does not require payment (Contractor)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ishpaul777] Determine if we should create a regression test for this bug.
• [@ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[dylanexpensify]

Payment summary:

Contributor+: @ishpaul777 $250 via Upwork

Please apply/request!

[ishpaul777]

@dylanexpensify No payment here i was not involved in the PR

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @kirillzyusko is from an agency-contributor and not due payment
• ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@dylanexpensify)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

@marcochavezf, @kirillzyusko, @dylanexpensify, @ishpaul777 Eep! 4 days overdue now. Issues have feelings too...

[marcochavezf]

Closing this one in favor of #44514