fix: use `KeyboardAvoidingView` from `react-native-keyboard-controller` #47096

kirillzyusko · 2024-08-08T17:04:41Z

Details

All possible solutions I listed in:

In this PR we are using 3rd approach. Before we already merged PR #46513 but it caused some issues. This PR is a very similar to previous one, but in this PR I fixed some issues in react-native-keyboard-controller upstream and use version from main. If we agree to merge this PR (i. e. we don't find any new issues) then I can prepare a new release to npm and we will not use a version from GitHub directly.

This PR will help in implementation for #42143

Fixed Issues

$ #44514
PROPOSAL: #44514 (comment)

Tests

Submit a couple of expenses in a workspace chat
Open the expense report
Tap on the first expense
Navigate back to the expense report
Be sure there is no layout jump/glitches
Test all other places in the application where we use a keyboard
Verify that Chat - Conversation doesn't expand to full view after completing editing a message #46743 Search - Keyboard overlaps the conversation opened from search results/start chat #46744 [$250] Bank account - Date of birth page is not full screen if keyboard is not previously dismissed #46745 are not reproducible as well

Offline tests

N/A

QA Steps

Submit a couple of expenses in a workspace chat
Open the expense report
Tap on the first expense
Navigate back to the expense report
Be sure there is no layout jump/glitches
Test all other places in the application where we use a keyboard
Verify that Chat - Conversation doesn't expand to full view after completing editing a message #46743 Search - Keyboard overlaps the conversation opened from search results/start chat #46744 [$250] Bank account - Date of birth page is not full screen if keyboard is not previously dismissed #46745 are not reproducible as well

PR Author Checklist

Screenshots/Videos

Android: Native

Only native iOS affected.

Android: mWeb Chrome

Only native iOS affected.

iOS: Native

Screen.Recording.2024-08-08.at.19.03.40.mov

iOS: mWeb Safari

Only native iOS affected.

MacOS: Chrome / Safari

Only native iOS affected.

MacOS: Desktop

Only native iOS affected.

melvin-bot · 2024-08-08T17:04:47Z

@ishpaul777 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ishpaul777 · 2024-08-10T20:20:18Z

This on my list for Monday :D

ishpaul777 · 2024-08-10T20:20:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Only native iOS affected.

Android: mWeb Chrome

Only native iOS affected.

iOS: Native

trim.5DF30DF7-DCC0-4513-8AD1-B0AE0EEEE7A9.MOV

trim.A1BDFF02-5618-4A03-B7F7-5F3935F22D8D.MOV

iOS: mWeb Safari

Only native iOS affected.

MacOS: Chrome / Safari

Only native iOS affected.

MacOS: Desktop

Only native iOS affected.

ishpaul777 · 2024-08-12T16:01:44Z

reviewing now 👀

ishpaul777 · 2024-08-12T17:23:43Z

Everything works great in my testing, but i have noticed there is wobbling of button when it slides up with the keyboard, do you think that is something related @kirillzyusko

RPReplay_Final1723483032.MP4

kirillzyusko · 2024-08-13T07:48:39Z

@ishpaul777 did you compare debug and release variant? Basically yes, right now there will be some wobbling in debug builds and it should be less noticeable in release builds. Also after reanimated 3.15.0 there shouldn't be wobbling at all, because they optimized ShadowTree traverse algorithm a lot 👀

github-actions · 2024-08-13T18:26:07Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the android build failed	The QR code can't be generated, because the iOS build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/47096/NewExpensify.dmg	https://47096.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ishpaul777 · 2024-08-13T19:30:42Z

@kirillzyusko I have tested the rest of application, it looks and feels pretty good to me, feel free to prepare a upstream release of package.

kirillzyusko · 2024-08-14T09:20:44Z

feel free to prepare a upstream release of package.

@ishpaul777 doing it now!

kirillzyusko · 2024-08-16T09:58:18Z

@ishpaul777 done, now using version from npm!

marcochavezf

LGTM, thanks guys!

OSBotify · 2024-08-16T19:43:08Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-08-19T16:14:36Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.22-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-19T17:11:16Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.22-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

IuliiaHerets · 2024-08-19T19:02:18Z

This PR is failing for iOS app because of issue #47656

kirillzyusko · 2024-08-19T19:10:20Z

This PR is failing for iOS app because of issue #47656

Okay, I think it's the same issue as #44514

It seems like release iOS works faster and there could be a chance, that we switch enable variable faster, than needed and because of that we can see such micro-jump.

In development it wasn't the case, so I missed that 🙈

…avoiding-view-from-keyboard-controller-v2"

techievivek · 2024-08-20T07:29:16Z

Hi, @kirillzyusko @ishpaul777 Could this PR be the reason for the ios bug on older OS versions here #47679, can you please take a look into it?

OSBotify · 2024-08-20T22:44:15Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.22-9 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-20T22:58:28Z

🚀 Deployed to staging by https://github.com/marcochavezf in version: 9.0.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-08-22T17:11:51Z

🚀 Deployed to production by https://github.com/chiragsalian in version: 9.0.23-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: use KeyboardAvoidingView from react-native-keyboard-controller

f3bbd01

kirillzyusko requested a review from a team as a code owner August 8, 2024 17:04

melvin-bot bot requested review from ishpaul777 and removed request for a team August 8, 2024 17:04

kirillzyusko added 2 commits August 8, 2024 19:42

fix: synchronize Podfile.lock

28efb6c

fix: bump keyboard-controller and fix CI

bdf829d

kirillzyusko mentioned this pull request Aug 12, 2024

[$250] react-native-keyboard-controller migration plan #37203

Open

greg-schroeder mentioned this pull request Aug 13, 2024

[HOLD for payment 2024-08-29] [$500] previous view is shown quickly after navigating back to expense report #44514

Closed

6 tasks

luacmartins added the Ready To Build label Aug 13, 2024

chore: use version from npm

7db099c

ishpaul777 approved these changes Aug 16, 2024

View reviewed changes

melvin-bot bot requested a review from marcochavezf August 16, 2024 17:34

marcochavezf approved these changes Aug 16, 2024

View reviewed changes

marcochavezf merged commit d123de5 into Expensify:main Aug 16, 2024
18 checks passed

This was referenced Aug 16, 2024

Investigate workflow job failing on main: e2ePerformanceTests / Build apk from delta ref #47587

Closed

Deploy Checklist: New Expensify 2024-08-19 #47639

Closed

IuliiaHerets mentioned this pull request Aug 19, 2024

[HOLD for payment 2024-08-29] iOS - Expense report jumps when returning from transaction thread #47656

Closed

6 tasks

neil-marcellini mentioned this pull request Aug 19, 2024

[HOLD for payment 2024-08-22] [$250] iOS - Large part of a public rooms sign in screen is overlapped by green background #47662

Closed

6 tasks

situchan added a commit to situchan/Expensify that referenced this pull request Aug 19, 2024

Revert "Merge pull request Expensify#47096 from margelo/fix/keyboard-…

a6b4f17

…avoiding-view-from-keyboard-controller-v2"

techievivek mentioned this pull request Aug 20, 2024

[HOLD for payment 2024-08-29] iOS-chat-Composer is hidden behind keyboard after copying a message on iOS 15 #47679

Closed

6 tasks

github-actions bot mentioned this pull request Aug 20, 2024

Deploy Checklist: New Expensify 2024-08-20 #47760

Closed

38 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use `KeyboardAvoidingView` from `react-native-keyboard-controller` #47096

fix: use `KeyboardAvoidingView` from `react-native-keyboard-controller` #47096

kirillzyusko commented Aug 8, 2024

melvin-bot bot commented Aug 8, 2024

ishpaul777 commented Aug 10, 2024

ishpaul777 commented Aug 10, 2024 •

edited

Loading

ishpaul777 commented Aug 12, 2024

ishpaul777 commented Aug 12, 2024

kirillzyusko commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

ishpaul777 commented Aug 13, 2024 •

edited

Loading

kirillzyusko commented Aug 14, 2024

kirillzyusko commented Aug 16, 2024

marcochavezf left a comment

OSBotify commented Aug 16, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

IuliiaHerets commented Aug 19, 2024

kirillzyusko commented Aug 19, 2024

techievivek commented Aug 20, 2024

OSBotify commented Aug 20, 2024

OSBotify commented Aug 20, 2024

OSBotify commented Aug 22, 2024

fix: use KeyboardAvoidingView from react-native-keyboard-controller #47096

fix: use KeyboardAvoidingView from react-native-keyboard-controller #47096

Conversation

kirillzyusko commented Aug 8, 2024

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 8, 2024

ishpaul777 commented Aug 10, 2024

ishpaul777 commented Aug 10, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

ishpaul777 commented Aug 12, 2024

ishpaul777 commented Aug 12, 2024

kirillzyusko commented Aug 13, 2024

github-actions bot commented Aug 13, 2024

ishpaul777 commented Aug 13, 2024 • edited Loading

kirillzyusko commented Aug 14, 2024

kirillzyusko commented Aug 16, 2024

marcochavezf left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 16, 2024

OSBotify commented Aug 19, 2024

OSBotify commented Aug 19, 2024

IuliiaHerets commented Aug 19, 2024

kirillzyusko commented Aug 19, 2024

techievivek commented Aug 20, 2024

OSBotify commented Aug 20, 2024

OSBotify commented Aug 20, 2024

OSBotify commented Aug 22, 2024

fix: use `KeyboardAvoidingView` from `react-native-keyboard-controller` #47096

fix: use `KeyboardAvoidingView` from `react-native-keyboard-controller` #47096

ishpaul777 commented Aug 10, 2024 •

edited

Loading

ishpaul777 commented Aug 13, 2024 •

edited

Loading