[$250] Bank account - Date of birth page is not full screen if keyboard is not previously dismissed #46745
Comments
lanitochka17
added
DeployBlockerCash
|
Triggered auto assignment to @Beamanator ( |
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Beamanator
added
External
|
Job added to Upwork: https://www.upwork.com/jobs/~01808a7973a2a6bf8a |
melvin-bot
bot
changed the title
melvin-bot
bot
added
the
Help Wanted
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 ( |
|
This could also be related to #46513 maybe 🤔 |
|
I'll work on a revert PR to see if that fixes 2 blockers |
Beamanator
removed
the
Help Wanted
melvin-bot
bot
added
Reviewing
|
Confirmed this is fixed with revert Screen.Recording.2024-08-03.at.12.52.38.AM.mov |
|
📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
Amazing, mind checking if #46744 is fixed too @ishpaul777 ? 🙏 |
|
Fixed Screen.Recording.2024-08-03.at.12.57.19.AM.mov |
|
Hello 46353.ios.1.mp4 |
|
@lanitochka17 ooh that sounds veryyyyy similar to #46743, so the fix that is being deployed to staging should hopefully fix that too 🙏 |
Beamanator
removed
the
DeployBlockerCash
|
Confirmed fixed in staging! |
@lanitochka17 may I ask you to give me these numbers? 😅 I need them to verify that in a new fix for #44514 that issues doesn't happen anymore 🙈 |
|
Thank you @ishpaul777 👍 |
…om space (#539) ## 📜 Description Fixed a case when `KeyboardAvoidingView` is not getting resized back when keyboard is hidden instantly. ## 💡 Motivation and Context The condition: ```tsx if (e.duration === 0) { progress.value = e.progress; height.value = e.height; } ``` prevented view to restore its initial position when keyboard is hidden instantly. When such thing happens we have next events: ```bash LOG onStart {"duration": 250, "eventName": "onKeyboardMoveStart", "height": 0, "progress": 0, "target": 7054} 1723043957135 LOG onEnd {"duration": 250, "eventName": "onKeyboardMoveEnd", "height": 0, "progress": 0, "target": -1} 1723043957142 ``` So technically we had to set our `height`/`progress` to `0`. But we skip it, because `event` actually has non-zero duration (it's 250ms). We can't simply remove the code that I added before because it'll bring old bug back, so I was thinking a lot on how to resolve the problem. ### 1️⃣ Add more conditions The first idea was to modify condition to be like ```tsx if (e.duration === 0 || e.target === -1) {} ``` However I don't like it because: - it adds more complexity to the code; - we have to remember about that case and use this condition in every hook; - this code doesn't feel cross-platform; - I'm not sure if it's a correct fix, because we may have a new situation, where this condition will lead to unexpected results; So I started to think about other approaches. ### 2️⃣ Native code modification At some of point of time I realized, that we expect `onEnd` to report an actual keyboard height that is currently visible on the screen (at least in `keyboardDidAppear` method). And if we rely on this fact then we can remove the condition from `onEnd` handler. So I decided to try to re-work the code and instead of re-forwarding the data from a notification I decided to grab a real data from the `keyboardVIew` (its real coordinates) and send them. Turned out that this fixes old bug and doesn't introduce new one, so I think I'll stick with this approach. Also all e2e tests passes without any modification and I think it's a good sign that I do everything properly 😅 > [!NOTE] > It's also safe to read frame inside this particular handler, because we know, that keyboard stopped its movement and has a final frame, so we don't need to predict next frame based on a current one etc. - we can simply read frame data and be sure it's exact number what user sees on the screen. A new fix for #327 Also fixes: Expensify/App#46743 and Expensify/App#46745 ## 📢 Changelog <!-- High level overview of important changes --> <!-- For example: fixed status bar manipulation; added new types declarations; --> <!-- If your changes don't affect one of platform/language below - then remove this platform/language --> ### JS - removed `if (e.duration === 0)` condition in `KeyboardAvoidingView` hook; ### iOS - added new `framePositionInWindow` extension to `UIView`; - take an actual keyboard height (based on `keyboardView`) in `keyboardDidAppear` method. ## 🤔 How Has This Been Tested? Tested manually on iPhone 15 Pro (iOS 17.4). ## 📸 Screenshots (if appropriate): |Before|After| |-------|-----| |<video src="https://github.com/user-attachments/assets/19b3ac39-bd8e-4d47-bc34-a6ba7f3478b3">|<video src="https://github.com/user-attachments/assets/f7492e25-ccaa-42f0-870a-60eafe912a7d">| I also checked that #327 is not reproducible anymore. ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.16-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4806926
Email or phone of affected tester (no customers): applausetester+vd_ios080224.2@applause.expensifail.com
Issue reported by: Applause - Internal Team
Action Performed:
Pre-requisite: user must have created a workspace and have enabled Workflows
Expected Result:
Date of birth page should be displayed in full screen
Actual Result:
Date of birth page is not displayed on full screen. If the user goes back, all of the app screens are not displayed on full screen
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6560422_1722621917080.Mmcn3431_1_.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @dukenv0307The text was updated successfully, but these errors were encountered: