[$250] Group chat-Member invited, made admin & removed in offline is showed on returning online.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.22
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4872013
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab -- start chat -- select a user
3. Create a group
4. Tap header -- member
5. Go offline
6. Invite a member
7. Make him admin by long pressing the member and selecting make admin
8. Then remove the same user by long pressing the member and selecting remove member
9. Go online
10. Tap back

Expected Result:

In group chat, member removed in offline must not be showed on returning online.

Actual Result:

In group chat, member invited, made admin & removed in offline is showed on returning online.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6576435_1724097752273.Screenrecorder-2024-08-20-01-23-47-366_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~015e13003200e6f595
• Upwork Job ID: 1825933817898137464
• Last Price Increase: 2024-08-20
• Automatic offers:
• dominictb | Contributor | 103626792

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #vip-vsb

[IuliiaHerets]

@puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[dominictb]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• In group chat, member invited, made admin & removed in offline is showed on returning online.

What is the root cause of that problem?

• In offline, when we invite a new user, we create a random accountID for it.

• Then if we try to remove that user, we just tell BE to remove that random accountID, so the real accountID that BE returns is not removed.

What changes do you think we should make in order to solve the problem?

• We should disable member that have isOptimisticPersonalDetail. So we cannot "Make admin" or "Remove" that user as we did in:
  

  App/src/pages/workspace/WorkspaceMembersPage.tsx

  Lines 348 to 350 in 0e4f02e

  	isDisabled:
  	!!details.isOptimisticPersonalDetail ||
  	(isPolicyAdmin && (policyEmployee.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !isEmptyObject(policyEmployee.errors))),

• So:
  

  App/src/pages/ReportParticipantsPage.tsx

  Line 85 in 0e4f02e

  isDisabled: pendingChatMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,

  
  will be:

                isDisabled: pendingChatMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !!details.isOptimisticPersonalDetail,

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~015e13003200e6f595

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[aimane-chnaif]

@dominictb's proposal looks good.
We should disable removing/making admin for optimistic members in group chat, as we did in workspace members.

🎀👀🎀 C+ reviewed

workspace.members.mp4

[melvin-bot]

Current assignee @puneetlath is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @puneetlath, @aimane-chnaif, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[puneetlath]

What happened with this issue @dominictb @aimane-chnaif? Did we finish it?

[dominictb]

PR merged but Melvin did not send deploy notifications :/ I think it was merged around 3 weeks ago #48035 (comment) so we should issue payment now.

[puneetlath]

Got it. I've paid @dominictb.

@aimane-chnaif can you complete the checklist?

[aimane-chnaif]

Offending PR with comment: https://github.com/Expensify/App/pull/40758/files#r1770809745
Regression test already exists: https://expensify.testrail.io/index.php?/tests/view/4872013

[puneetlath]

Payment summary:

• C - @dominictb - $250 - paid via Upwork
• C+ - @aimane-chnaif - $250 - to be paid via NewDot

Thanks y'all!

[aimane-chnaif]

@puneetlath I am still using upwork. Can you please reopen and sort payment? Thanks

[puneetlath]

Ah ok got it. Offer is here: https://www.upwork.com/nx/wm/offer/104341792. Please ping me on this issue when you've accepted.

[aimane-chnaif]

Accepted thanks

[puneetlath]

Paid!