[HOLD for payment 2024-10-25] Migrate changes in react-native-qrcode-svg-old to react-native-qrcode-svg

[grgia]

See https://expensify.slack.com/archives/C01GTK53T8Q/p1724159312329299?thread_ts=1697098846.087309&cid=C01GTK53T8Q

Background

• We took ownership of react-native-qrcode-svg and renamed our fork react-native-qrcode-svg-old
• We had pushed changes to our fork and app has dependencies on these changes so this can be a breaking change

Goal

• Let's point to old fork for now - [HOLD for payment 2024-08-29] Update link to fork for react-native-qrcode-svg #47713
• Look at our forked changes and decide if any of them would be useful to the open source community
• Create a path forward to fully deprecate react-native-qrcode-svg-old

Issue Owner

Current Issue Owner: @bfitzexpensify

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[grgia]

cc @Kicu - Do you think someone else from SWM would be interested in looking into this? Otherwise I can extend out to one of our other agencies

[melvin-bot]

Current assignee @bfitzexpensify is eligible for the NewFeature assigner, not assigning anyone new.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @shawnborton (NewFeature)

[grgia]

Not really a bug not really a new feature... more of an improvement

[grgia]

Posted in SWM https://expensify.slack.com/archives/C04878MDF34/p1724176578092919

[Kicu]

Because Expensify is now the owner of this open source library I think we should try to keep commits and PRs clean and self contained.

Because of this my suggestion would be to migrate the two PRs that we did on the original fork separately:

• adding svgs by me: Allow displaying an SVG logo using svg source react-native-qrcode-svg-old#1 - this changes public api so should result in a minor bump for the package release
• adding example app code: Example app react-native-qrcode-svg-old#2 - this one just adds examples to be run for devs and would not result in any api changes - no new release needed

If we do that, then later when testing or if anything breaks we can easily revert the svg code, while the example app should stay as it helps with development a lot.

I can migrate the two separately and open them on https://github.com/Expensify/react-native-qrcode-svg/

[Kicu]

CC @grgia @luacmartins

[luacmartins]

Agree with that. Let's do it.

[Kicu]

PR that adds the Example app: Expensify/react-native-qrcode-svg#206
Unsure who is responsible now for reviewing and merging this - is it anyone working in Expensify? I can call on some friends that work on Open Source in SWM to also take a look at the PR if you guys want it.

Will followup soon with another PR that adds the SVG changes that we need in Expensify App

[Kicu]

I also have the SVG changes nicely cleaned up with like 2 extra commits locally, so I will open the 2nd PR with the SVG code on Monday, and this issue should be solved :)

[luacmartins]

Nice! Thank you ❤️

[grgia]

Thank you @Kicu !

[luacmartins]

I pinged someone to look into the branch rules for the new repo, hopefully we can get this fixed soon.

[slafortune]

Since you are back, I'll unassign myself @bfitzexpensify

[grgia]

@luacmartins do you have an update on #47711 (comment)

[luacmartins]

Yea, we solved the branch rules but now we have the npm auth issue we were discussing in Slack

[grgia]

bumped in slack

[Kicu]

Is there any way I can help with this one?

[luacmartins]

It seems like we still have permissions issues with npm. Asking infra if they have npm package access so we can update the permissions

[luacmartins]

We published the latest version 6.3.11 to npm. Let's update App.

[Kicu]

nice 👍 I can take care of that

[Kicu]

@luacmartins @grgia this PR updates the version in App #50875

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Bump react-native-qrcode-svg to latest version #50875

If no regressions arise, payment will be issued on 2024-10-25. 🎊

For reference, here are some details about the assignees on this issue:

• @Kicu does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Kicu] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[bfitzexpensify]

This is back-end work that QA won't touch, so I don't see the need for a regression test.

Payment not needed. Closing this out.