Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing period from the copy on the preference page after pinned items at top #4772

Closed
parasharrajat opened this issue Aug 20, 2021 · 13 comments
Assignees
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@parasharrajat
Copy link
Member

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Open Preference page on NewDot.
  2. Check the copy under the Priority Mode.

Expected Result:

There should be a period after the full sentence.

Actual Result:

No Period.

Workaround:

Non.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number:
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
image

Expensify/Expensify Issue URL:

View all open jobs on GitHub

@parasharrajat parasharrajat added AutoAssignerTriage Auto assign issues for triage to an available triage team member Daily KSv2 labels Aug 20, 2021
@MelvinBot
Copy link

Triggered auto assignment to @arielgreen (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

@MelvinBot MelvinBot removed the AutoAssignerTriage Auto assign issues for triage to an available triage team member label Aug 20, 2021
@parasharrajat
Copy link
Member Author

A slack discussion where we met an agreement of adding this https://expensify.slack.com/archives/C01GTK53T8Q/p1629496662087100

@arielgreen arielgreen removed their assignment Aug 20, 2021
@arielgreen arielgreen added Improvement Item broken or needs improvement. Engineering labels Aug 20, 2021
@MelvinBot
Copy link

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@alex-mechler
Copy link
Contributor

Thanks for reporting this! Spun up a quick pr that adds it!

@botify botify closed this as completed Aug 24, 2021
@Beamanator Beamanator added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@Beamanator
Copy link
Contributor

@jliexpensify I added External b/c @parasharrajat deserves a "Reported & fixed by someone else" reward - internal discussion here. We'll update the proper documentation based on this very soon 👍

@jliexpensify
Copy link
Contributor

Cool, will whip up something soon. Looks like we're paying $250 to Rajat?

@jliexpensify
Copy link
Contributor

Internal - https://www.upwork.com/ab/applicants/1431380037292875776/job-details
External - https://www.upwork.com/jobs/~01f5bd71c77b6a1e2a

@parasharrajat please feel free to apply and comment in this GH and I'll pay and close the job.

@arielgreen
Copy link
Contributor

@jliexpensify you can send him an offer directly, he doesn't need to go through the application step.

@jliexpensify
Copy link
Contributor

Done!

@parasharrajat
Copy link
Member Author

Thank you, guys.

@jliexpensify
Copy link
Contributor

Paid and cancelled contract. Thanks Rajat!

@botify
Copy link

botify commented Aug 30, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.88-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

7 participants