Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Period is missing in payments section text - Reported by: @parasharrajat #5817

Closed
isagoico opened this issue Oct 13, 2021 · 9 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@isagoico
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Action Performed:

  1. Log in to app
  2. Navigate to payments.

Expected Result:

There should be a period at the end of the text.

Actual Result:

Period missing at the en of the text.

Workaround:

N/A, visua issue.

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: 1.1.7-3

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

image

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1634061472198600

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @NikkiWines (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@parasharrajat
Copy link
Member

Proposal.

  1. Add the . to the sentencece in the translations files.

@NikkiWines
Copy link
Contributor

Thanks for reporting this! Spun up a quick pr that adds it!

Added External label since @parasharrajat should be compensated for "Reported & fixed by someone else", following the convention from this issue.

@NikkiWines NikkiWines added the External Added to denote the issue can be worked on by a contributor label Oct 14, 2021
@MelvinBot
Copy link

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@NikkiWines NikkiWines added Weekly KSv2 Reviewing Has a PR in review and removed Daily KSv2 labels Oct 14, 2021
@jliexpensify
Copy link
Contributor

@jliexpensify
Copy link
Contributor

Hey @parasharrajat - I closed to job to try and pay you, but I'm not sure what's happened: I swear that I hired you. I might need to recreate this post again.

@jliexpensify
Copy link
Contributor

@parasharrajat actually, do you mind accepting the job? I hope that then allows me to pay you.

If you can't, or are getting an error - let me know and I'll recreate the job and invite you.

@parasharrajat
Copy link
Member

@jliexpensify done

@jliexpensify
Copy link
Contributor

Paid Rajat and contract closed, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

5 participants