-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Search - Dropdown and Filters button have no spacing between each other #48069
Comments
Triggered auto assignment to @lakchote ( |
Triggered auto assignment to @strepanier03 ( |
We think that this bug might be related to #wave-control |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Edited by proposal-police: This proposal was edited at 2024-08-27 11:19:28 UTC. ProposalOffending PR: #47931 Please re-state the problem that we are trying to solve in this issue.Dropdown and Filters button have no spacing between each other What is the root cause of that problem?We are not providing margin left for filter button component here App/src/components/Search/SearchPageHeader.tsx Lines 315 to 319 in d5cfecf
What changes do you think we should make in order to solve the problem?We should pass a margin left to the styles prop of the button style={[styles.ml2]} What alternative solutions did you explore? (Optional)We should add <View style={[styles.reportOptions, styles.flexRow, styles.pr5, styles.alignItemsCenter, styles.gap2]}>{children}</View>
|
@etCoderDysto could you try to use gap ( I think it would be a bit cleaner |
Edited by proposal-police: This proposal was edited at 2024-08-27 10:40:21 UTC. ProposalPlease re-state the problem that we are trying to solve in this issue.Web - Search - Dropdown and Filters button have no spacing between each other What is the root cause of that problem?We are no adding any gap What changes do you think we should make in order to solve the problem?We should wrap button and dropdown menu in a App/src/components/Search/SearchPageHeader.tsx Lines 303 to 319 in bea22ee
We can adjust the gap and other styles according to design. What alternative solutions did you explore? (Optional) |
Checking @Kicu |
@Kicu Can you check my proposal? These are the styles we are using in other pages |
|
@Kicu I have updated my alternative solution according to your suggestion |
Thanks for the updates. However I work as a consultant and I'm not a Contributor+ so I cannot officially assign you to this task. Calling @lakchote could you take a look at this? |
Hey! fixed this in a pr I am working on |
@289Adam289 has a PR under review that fixes it that is already approved, using the Thanks for having taken the time to review the proposal even if you're not a C+. Sorry @etCoderDysto but since the other PR is already approved, and a C+ is currently going through the reviewer checklist, I'm assigning @289Adam289 to the issue. |
No worries @lakchote 👍 |
This is fixed in staging after the CP. Closing. |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.25-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh050806@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
Dropdown and Filters button will have some spacing between each other.
Actual Result:
Dropdown and Filters button have no spacing between each other
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6583774_1724725699215.20240827_102615.mp4
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: