[HOLD for payment 2024-09-25] [$125] Chat - App crashes after selecting Flag as offensive

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

1. Go to https://staging.new.expensify.com/ and log in as user A
2. Navigate to a chat with user B
3. Right click on any message from user B
4. From the context menu select Flag as offensive

Expected Result:

The RHP is opened with the reasons for flagging

Actual Result:

The app crashes

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

2708_1.log

Bug6583781_1724726491694.Recording__720.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011311fecba3ab9bf4
• Upwork Job ID: 1828397176278986997
• Last Price Increase: 2024-08-27
• Automatic offers:
• nkdengineer | Contributor | 103700093

Issue Owner

Current Issue Owner: @getusha

[melvin-bot]

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The app crashes

What is the root cause of that problem?

connection here can be undefined then the app crashes

https://github.com/Expensify/react-native-onyx/blob/11b36cc6ea54b2e58806fde99ae16b9deb0cfced/lib/OnyxConnectionManager.ts#L230

What changes do you think we should make in order to solve the problem?

Safely check for connection.id in addToEvictionBlockList and removeFromEvictionBlockList by changing connection.id to connection?.id or we can return early if connection is undefined or not call these function if connection is undefined

https://github.com/Expensify/react-native-onyx/blob/11b36cc6ea54b2e58806fde99ae16b9deb0cfced/lib/OnyxConnectionManager.ts#L230

What alternative solutions did you explore? (Optional)

[nkdengineer]

This problem comes from this PR.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~011311fecba3ab9bf4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

Super small change, @nkdengineer can you raise the PR quickly?

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

@nkdengineer can you also check if there are any other places we might have missed the connection change? cc @fabioh8010 @ikevin127

[nkdengineer]

@mountiny Sure, will raise the PR soon.

[nkdengineer]

@mountiny The react-native-onyx PR here.

[mountiny]

@nkdengineer can you raise app pr please?

[nkdengineer]

Sure

[nkdengineer]

@mountiny The App PR is here. I have some problems with native app building after RN upgrade.

[puneetlath]

I just tested the CP'd fix on web and it seems to be working. Going to go ahead and demote.

[melvin-bot]

This issue has not been updated in over 15 days. @lschurr, @mountiny, @getusha, @nkdengineer eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mountiny]

@lschurr the automation failed this is ready for payment

[mountiny]

$125 to @getusha and to @nkdengineer

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lschurr]

@muttmuure I'm OOO from 9/23-10/4. Can you handle payment on 9/25 for me? #48070 (comment)

Thank you!!

[melvin-bot]

@mountiny, @muttmuure, @getusha, @nkdengineer Whoops! This issue is 2 days overdue. Let's get this updated quick!