Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-02] [$750] Implement Debug mode for the App #48071

Closed
mountiny opened this issue Aug 27, 2024 · 18 comments
Closed

[HOLD for payment 2024-10-02] [$750] Implement Debug mode for the App #48071

mountiny opened this issue Aug 27, 2024 · 18 comments
Assignees
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 27, 2024

Proposal

Implement a debug mode for the App, where user can inspect and tweak the report and report action data of live account (locally only) to test various changes or to try to see why certain ui is showing for a report or report action by seeing the underlying data.

These are the features that are showcased in my POC:

  • Toggle debug mode in Troubleshoot page
  • Check your accountID on Settings page
  • On a report, you’re able to debug it by pressing on the chat header and then pressing on Debug, just below Private Notes
  • On this new report debug page, you’re able to modify each property of the report object, in the details tab
  • In the JSON tab, you can check the JSON representation of the report
  • In the actions tab, you can see the list of all report actions associated with the current report
  • You’re able to create a new report action, where you just need to insert the JSON that represent the report action that you want to test and preview how it will look like in the chat
  • By pressing an existing report action, you’re redirected to a new report action debug page, where you can modify each property of the report action object, in the details tab
  • In the JSON tab, you can check the JSON representation of the report action
  • And in the preview tab, you can preview what the report action looks like in the chat
  • Besides the features present in the POC, we could also add the ability to debug other parts of the app, like connecting bank accounts, test expensify cards, etc.

Coming from here

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841961814182501474
  • Upwork Job ID: 1841961814182501474
  • Last Price Increase: 2024-10-03
Issue OwnerCurrent Issue Owner: @mallenexpensify
@mountiny mountiny added Daily KSv2 NewFeature Something to build that is a new item. AutoAssignerNewDotQuality Used to assign quality issues to engineers labels Aug 27, 2024
@mountiny mountiny changed the title Implement Debug mode Implement Debug mode for the App Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Current assignees @chiragsalian and @mountiny are eligible for the AutoAssignerNewDotQuality assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@pac-guerreiro
Copy link
Contributor

Hi! I’m Pedro Guerreiro from Callstack - expert contributor group. I’d like to work on this task!

@mountiny mountiny added the Reviewing Has a PR in review label Aug 27, 2024
@muttmuure muttmuure moved this to MEDIUM in [#whatsnext] #quality Aug 27, 2024
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

This issue has not been updated in over 15 days. @chiragsalian, @jliexpensify, @mountiny, @pac-guerreiro, @DylanDylann eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@DylanDylann
Copy link
Contributor

Hi @mountiny,

This issue is ready for payment. However, before proceeding, I’d like to request an increase in the payment amount, possibly by $500. The pull request is quite large (involving 43 changed files with +3,193 new lines and -121 lines). It took considerable time to review and test everything thoroughly.

I’d appreciate hearing your thoughts. Thank you!

cc @jliexpensify

@jliexpensify
Copy link
Contributor

I'll let @mountiny decide if that's approporiate as I have no context. I will be headed OOO after tomorrow so if possible, I'd like to pay this ASAP so it's not reassigned to someone else.

@DylanDylann is a checklist needed for this issue?

@DylanDylann
Copy link
Contributor

@DylanDylann is a checklist needed for this issue?

I think the checklist isn't required for this issue

@mountiny mountiny changed the title Implement Debug mode for the App [$750] Implement Debug mode for the App Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@mountiny
Copy link
Contributor Author

mountiny commented Oct 2, 2024

Yeah, I agree this was a massive PR, so increased bounty is reasonable. $750 to @DylanDylann

@mountiny mountiny added Daily KSv2 and removed Reviewing Has a PR in review Monthly KSv2 labels Oct 2, 2024
@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 2, 2024
@mountiny mountiny changed the title [$750] Implement Debug mode for the App [HOLD for payment 2024-10-02] [$750] Implement Debug mode for the App Oct 2, 2024
Copy link

melvin-bot bot commented Oct 2, 2024

Payment Summary

Upwork Job

  • Contributor: @pac-guerreiro is from an agency-contributor and not due payment
  • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@jliexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@jliexpensify
Copy link
Contributor

Hi, am OOO but just saw the notification for this - assigning @mallenexpensify to help with $750 payment to @DylanDylann . Thank you Matt!

@mallenexpensify mallenexpensify added the External Added to denote the issue can be worked on by a contributor label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021841961814182501474

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 3, 2024
Copy link

melvin-bot bot commented Oct 3, 2024

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@mallenexpensify
Copy link
Contributor

@DylanDylann can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~021841961814182501474

@DylanDylann
Copy link
Contributor

@mallenexpensify Done 🙏 The offer was for $250 so I guess an extra $500 will be released as a bonus.

Thanks

@melvin-bot melvin-bot bot added the Overdue label Oct 7, 2024
@mallenexpensify
Copy link
Contributor

Contributor: @DylanDylann paid $750 via Upwork

Thanks for the ping @DylanDylann , I might not have noticed cuz the job was created via automation and I haven't seen an instance in a while where the price in the title wasn't what the Upwork job price was. Please post in #contributor-plus if you see this again.

I'm assuming we don't need a regression test for this. Closing

@github-project-automation github-project-automation bot moved this from MEDIUM to Done in [#whatsnext] #quality Oct 7, 2024
@melvin-bot melvin-bot bot removed the Overdue label Oct 7, 2024
@mallenexpensify
Copy link
Contributor

Upwork bug, payment didn't go through, @DylanDylann , can you confirm you've been paid now? I issued a $750 bonus and it's showing you were paid

@DylanDylann
Copy link
Contributor

@mallenexpensify Yes I was paid now, thank you

@melvin-bot melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoAssignerNewDotQuality Used to assign quality issues to engineers Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

6 participants