[$250] Expense - Banner shows "transaction pending" when there is no pending Ecard transaction

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.25
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh2508001@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to https://staging.chat.expensify.com
2. Go to workspace chat
3. Submit a manual expense
4. Click on the expense preview

Expected Result:

The banner will not show "Transaction pending. It may take a few days to post." because there is no pending Ecard transaction

Actual Result:

The banner shows "Transaction pending. It may take a few days to post."

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

20240827_131711.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dfc30aa1d4201062
• Upwork Job ID: 1828526591139483595
• Last Price Increase: 2024-08-27
• Automatic offers:
• rojiphil | Reviewer | 103709050
• Nodebrute | Contributor | 103709053

Issue Owner

Current Issue Owner: @rojiphil

[Nodebrute]

Edited by proposal-police: This proposal was edited at 2024-08-27 13:34:39 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Banner shows "transaction pending" when there is no pending Ecard transaction

What is the root cause of that problem?

ReportUtils.getTransactionsWithReceipts returns an empty array, which causes this to be true.

App/src/components/MoneyReportHeader.tsx

Line 109 in c2e7f40

const hasOnlyPendingTransactions = ReportUtils.getTransactionsWithReceipts(moneyRequestReport?.reportID).every(

What changes do you think we should make in order to solve the problem?

First, we need to check if ReportUtils.getTransactionsWithReceipts(moneyRequestReport?.reportID) returns a non-empty array. Only if it's not empty then we should use every method on it. If the array is empty, we should return false.

App/src/components/MoneyReportHeader.tsx

Line 109 in c2e7f40

const hasOnlyPendingTransactions = ReportUtils.getTransactionsWithReceipts(moneyRequestReport?.reportID).every(

We can create a utility function to check if hasTransactionsWithReceipts if it returns true only then we should use ReportUtils.getTransactionsWithReceipts(moneyRequestReport?.reportID).

We have two options here: either make changes directly in getTransactionsWithReceipts or update all the places where this function is used.

We are doing the same here where we have two functions

App/src/libs/actions/IOU.ts

Lines 6997 to 6998 in 492b884

	if (full && hasHeldExpenses) {
	const heldTransactions = ReportUtils.getAllHeldTransactions(expenseReport?.reportID);

If this issue appears elsewhere, we should fix it there as well

What alternative solutions did you explore? (Optional)

[Nodebrute]

@lanitochka17 Could you add the labels again? no one is assigned here.

[melvin-bot]

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dfc30aa1d4201062

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[luacmartins]

Likely a regression from #47821 cc @grgia @dangrous

[luacmartins]

@Nodebrute are you available to work on a fix?

[Nodebrute]

@luacmartins Yes, I can raise a pr right now.

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @Nodebrute 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[luacmartins]

Cool, all yours then

[Nodebrute]

The PR will be done in about 30 minutes.

[dangrous]

oh i think we already have a fix for this maybe? #47941

We noticed this last week but hasn't been fully reviewed yet

[luacmartins]

@Nodebrute please hold on working on the PR as it seems like we already had a fix in place - #47941

[luacmartins]

This is fixed in staging. Closing.