Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] iOS - Expense - Payment button shows black gradient #48103

Closed
1 of 6 tasks
IuliiaHerets opened this issue Aug 27, 2024 · 29 comments
Closed
1 of 6 tasks

[$250] iOS - Expense - Payment button shows black gradient #48103

IuliiaHerets opened this issue Aug 27, 2024 · 29 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Aug 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.25-3
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/4895183
Email or phone of affected tester (no customers): applausetester+kh05081@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Updated reproduction steps here and listed below:

  1. Launch New Expensify app.
  2. Create a workspace.
  3. Connect it to QBO.
  4. Disable auto-sync.
  5. submit a report and pay it.
  6. Navigate to export button.

Expected Result:

Export button will not have black gradient.

Actual Result:

Export button shows black gradient.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6584280_1724773991771!IMG_4669

Bug6584280_1724773878573.ScreenRecording_08-27-2024_23-49-11_1.1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01c3743ad146431654
  • Upwork Job ID: 1828483486548366437
  • Last Price Increase: 2024-09-10
Issue OwnerCurrent Issue Owner: @dukenv0307
@IuliiaHerets IuliiaHerets added DeployBlockerCash This issue or pull request should block deployment Bug Something is broken. Auto assigns a BugZero manager. labels Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Aug 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@IuliiaHerets
Copy link
Author

We think that this bug might be related to #wave-collect - Release 1

Copy link

melvin-bot bot commented Aug 27, 2024

📣 @GoldenCaterpie! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@caineblood
Copy link

The above comment asking you to download a file is malware to steal your account; do not under any circumstances download or run it. The post needs to be removed. If you have attempted to run it please have your system cleaned and your account secured immediately.

Copy link

melvin-bot bot commented Aug 27, 2024

📣 @caineblood! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@joekaufmanexpensify
Copy link
Contributor

@caineblood Thanks for flagging! We have removed that user from being able to interact with GH issues.

@yuwenmemon yuwenmemon added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024
@melvin-bot melvin-bot bot changed the title iOS - Expense - Payment button shows black gradient [$250] iOS - Expense - Payment button shows black gradient Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01c3743ad146431654

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@Expensify Expensify deleted a comment from GoldenCaterpie Aug 27, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 27, 2024
@bondydaa
Copy link
Contributor

@allroundexperts could you take a look here, we thought maybe it's related to this #37174

we're having issues with some of our iOS sims locally so can you see if 1. you can reproduce on main and if so if 2. this revert fixes it? #48117

@IuliiaHerets
Copy link
Author

@bondydaa Done, issue also repro with a light mode, build v9.0.25-8
IMG_4689

ScreenRecording_08-28-2024.04-40-44_1.MP4

@yuwenmemon
Copy link
Contributor

Okay testing with the adhoc build in #48117, the gradient does indeed go away:

Screenshot 1 Screenshot 2
IMG_5447 IMG_5449

Sorry folks, but it looks like we may need to revert, unless @IuliiaHerets or @brandonhenry want to take a stab at fixing it quick?

@yuwenmemon yuwenmemon added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment labels Aug 27, 2024
@yuwenmemon
Copy link
Contributor

This has been deployed and is now fixed on staging.

@lanitochka17
Copy link

Issue is still reproducible

ScreenRecording_08-28-2024.22-01-26_1.MP4

@bondydaa
Copy link
Contributor

We're going to revert this revert PR since that didn't seem to actually fix this problem #48117

I wonder if this is something related to the react native bump we had and a default style was updated?

I think we take this off of reviewing and see what contributors can figure out to fix this, though it seems it's hard to reproduce locally 🤷

@bondydaa bondydaa removed the Reviewing Has a PR in review label Aug 29, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Sep 2, 2024
@bondydaa
Copy link
Contributor

bondydaa commented Sep 2, 2024

curious @lanitochka17 is this only showing on Staging still? Or does it appear on production now?

I would assume it would be showing up on production by now if #48117 wasn't the cause since we've done fully deploys since the revert anyways.

I wonder if this is something strange just happening on staging?

@bondydaa bondydaa removed the Reviewing Has a PR in review label Sep 2, 2024
@IuliiaHerets
Copy link
Author

@bondydaa Issue happens when the button has a dropdown. It requires different repro steps now. You can connect to QBO and disable Auto sync then it can repro with the Export button with dropdown. Stg and prod - the same.
IMG_7FC5080A4C91-1 (1)

ScreenRecording_09-03-2024.09-16-20_1.MP4

Copy link

melvin-bot bot commented Sep 3, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@bondydaa
Copy link
Contributor

bondydaa commented Sep 3, 2024

Ah thank you!

@joekaufmanexpensify
Copy link
Contributor

Still waiting for proposals. Updated reproduction steps and posted in slack here!

Copy link

melvin-bot bot commented Sep 10, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@HezekielT
Copy link
Contributor

@joekaufmanexpensify I was not able to reproduce this issue on the latest main.

Screenshot 2024-09-10 at 7 19 22 in the evening

@joekaufmanexpensify
Copy link
Contributor

Got it. @IuliiaHerets are you still able to reproduce this?

Copy link

melvin-bot bot commented Sep 10, 2024

@yuwenmemon @joekaufmanexpensify @dukenv0307 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 10, 2024
@yuwenmemon
Copy link
Contributor

I was not able to reproduce this time.

@joekaufmanexpensify
Copy link
Contributor

Same, I can't reproduce either. Closing for now as this doesn't appear to be consistently reproducible any longer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

8 participants