Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for Payment 2024-09-6][$250] iOS - Scan - After taking picture, image is not displayed on confirmation screen #48118

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 27, 2024 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: .0.25-8
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+vd_ios082724@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Open New Expensify app
  2. Go to a chat
  3. Tap on the "+" button and select "Submit expense"
  4. On the Scan tab, take a picture

Expected Result:

The taken picture should be displayed on the confirmation screen

Actual Result:

The taken picture is not displayed on the confirmation screen, an empty space is displayed instead

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6584474_1724784788375.Rpreplay_Final1724783767.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cc5d61efd7cbd67d
  • Upwork Job ID: 1828531357538423188
  • Last Price Increase: 2024-08-27
  • Automatic offers:
    • ishpaul777 | Contributor | 103724404
Issue OwnerCurrent Issue Owner: @adelekennedy
@lanitochka17 lanitochka17 added DeployBlocker Indicates it should block deploying the API DeployBlockerCash This issue or pull request should block deployment labels Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to @neil-marcellini (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@neil-marcellini neil-marcellini added the External Added to denote the issue can be worked on by a contributor label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01cc5d61efd7cbd67d

@melvin-bot melvin-bot bot changed the title iOS - Scan - After taking picture, image is not displayed on confirmation screen [$250] iOS - Scan - After taking picture, image is not displayed on confirmation screen Aug 27, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 27, 2024
Copy link

melvin-bot bot commented Aug 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

@neil-marcellini
Copy link
Contributor

I'm suspicious of this PR On paste file add file extension if not found, so I'm going to put up a revert, create an adhoc build, and see if the issue is solved. I'll also work on this locally.

@s77rt
Copy link
Contributor

s77rt commented Aug 27, 2024

That PR can't be the culprit as it's only related to pasting image in the composer

@stitesExpensify
Copy link
Contributor

Removing the regular deployblocker label since this is an iOS only bug

@stitesExpensify stitesExpensify removed the DeployBlocker Indicates it should block deploying the API label Aug 27, 2024
@neil-marcellini
Copy link
Contributor

I ran into a bunch of problems trying to get App running on my iPhone, so I'll have to check back tomorrow.

@shubham1206agra
Copy link
Contributor

Maybe its the RN upgrade.

Can you please check @MrRefactor @WoLewicki?

@neil-marcellini
Copy link
Contributor

I finally got the App running on my iPhone and I'm able to reproduce. I'll try reverting the RN upgrade now.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Hourly KSv2 labels Aug 28, 2024
@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

📣 @ishpaul777 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@neil-marcellini
Copy link
Contributor

I found the root cause and had @ishpaul777 author and test the fix. We didn't use another C+. Assigning a BZ member to handle payment.

@neil-marcellini neil-marcellini added the Bug Something is broken. Auto assigns a BugZero manager. label Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@neil-marcellini
Copy link
Contributor

Verified fixed here

@neil-marcellini neil-marcellini added Awaiting Payment Auto-added when associated PR is deployed to production and removed DeployBlockerCash This issue or pull request should block deployment Reviewing Has a PR in review labels Aug 28, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 2, 2024
@ishpaul777
Copy link
Contributor

not overdue, [HOLD for Payment 2024-09-6]

Copy link

melvin-bot bot commented Sep 3, 2024

@neil-marcellini, @adelekennedy, @ishpaul777 Huh... This is 4 days overdue. Who can take care of this?

@adelekennedy adelekennedy changed the title [$250] iOS - Scan - After taking picture, image is not displayed on confirmation screen [HOLD for Payment 2024-09-6][$250] iOS - Scan - After taking picture, image is not displayed on confirmation screen Sep 3, 2024
@adelekennedy
Copy link

Updated title

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels Sep 3, 2024
@ishpaul777
Copy link
Contributor

ishpaul777 commented Sep 5, 2024

not overdue Paydate is tomorrow!

@adelekennedy
Copy link

adelekennedy commented Sep 6, 2024

Payouts due:

Upwork job is here.

@adelekennedy
Copy link

Closing!

@ishpaul777
Copy link
Contributor

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

8 participants