-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On paste file add file extension if not found #47953
Conversation
@ahmedGaber93 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@s77rt The issue still reproduced, and I think the current fix shouldn't fix the issue. The root cause of the issue is clicking "paste" action on composer will trigger two actions
I think we don't need to fix the freeze issue here (maybe will fix here #46766) we need to prevent pasting the decoded long text while we have an image in clipboard, and deal with it by our patch only Screen_Recording_20240825_040012_New.Expensify.Dev.mp4 |
@ahmedGaber93 This PR is not meant to fix that issue. It's only for fixing the missing file extension case. That issue needs more investigation, primary why this happens only on some devices. I was not able to reproduce it, it's possible that the bug is in Android and it was fixed recently.
I can do that but I prefer to find the root cause first before jumping into a solution |
Thanks for clarification. |
BeforeScreen_Recording_20240825_202543_New.Expensify.mp4AfterScreen_Recording_20240825_213900_New.Expensify.Dev.mp4 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeScreen_Recording_20240825_213900_New.Expensify.Dev.mp4Android: mWeb Chrome20240825121659723.mp4iOS: Nativei.mp4iOS: mWeb Safariiw.mp4MacOS: Chrome / Safari20240825120535865.mp4MacOS: Desktopd.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks, LGTM |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Performance Comparison Report 📊Significant Changes To Duration
Show details
Meaningless Changes To DurationShow entries
Show details
|
@Expensify/mobile-deployers 📣 Please look into this performance regression as it's a deploy blocker. |
False positive ^ This PR has no connection to the chat finder page |
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.25-0 🚀
|
1 similar comment
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.0.25-0 🚀
|
Details
In Android the pasted file's uri may not include the file extension e.g.
content://media/external/images/media/1000008715
. In this case the attachment modal will not display the file correctly as we use the file extension to determine which loader to use (image, video, pdf, etc.). This PR adds the file extension to the filename if not found. The used file extension is based on the file's mime type.Fixed Issues
$ #41239
Tests
Offline tests
Same
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
mweb-chrome.mov
iOS: Native
ios.mov
iOS: mWeb Safari
mweb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov