[PAYMENT DUE 2024-10-08][$500] Update Mozilla/pdf.js and remove patch

[thienlnam]

Tracking issue to remove the patches we've added for mozila/pdf.js

• [HOLD for payment 2023-11-30] [$500] Web - Attachment - Console error shows up when closing the PDF view while it is loading #31209
• [$250] Web - Attachment - "Worker was terminated" console error when closing a PDF #47810

We'll need an upstream PR to fix this issue wojtekmaj/react-pdf#1062
And then verify the new version fixes this old issue we had from here, then to upgrade the version and remove the patches

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d46938f37bc659b7
• Upwork Job ID: 1828539622745768358
• Last Price Increase: 2024-09-16
• Automatic offers:
• CyberAndrii | Contributor | 103986598

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d46938f37bc659b7

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[github-actions]

@user Your proposal will be dismissed because you did not follow the proposal template.

[thienlnam]

We're looking for someone to make the upstream fix here

[sudomf]

Hey @thienlnam. Can I get this as my first contribution to Expensify?

[melvin-bot]

📣 @sudomf! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[sudomf]

Contributor details
Your Expensify account email: mayke.sargento@gmail.com
Upwork Profile Link: https://www.upwork.com/freelancers/~0117f5b3f18d3179e9

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[thienlnam]

@sudomf If you're interested, please read through the contributing guide - you'll need to submit a proposal and get selected by the C+ if you're interested in taking this on

[CyberAndrii]

I looked into this, and the loadingTask._worker.destroy(); workaround no longer works on the main branch. I think something might have changed in the pdf.js library. My changes so far: wojtekmaj/react-pdf@b4c9594

[melvin-bot]

@thienlnam, @jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?

[jayeshmangwani]

Not Overdue, we’re still awaiting proposals.

bumped on Slack

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jayeshmangwani]

No proposals so far.

@thienlnam What do you suggest—bringing in someone from an expert agency or raising the bounty to attract more attention 👀 ?

[thienlnam]

@CyberAndrii Are you still looking into this?

[CyberAndrii]

No, I didn’t find a solution.

[melvin-bot]

@thienlnam, @jayeshmangwani Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

📣 @CyberAndrii 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jayeshmangwani]

@CyberAndrii PR merged upstream 🥳 , Thanks.

[wojtekmaj]

...and released as react-pdf v9.1.1.

[melvin-bot]

📣 @wojtekmaj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[jayeshmangwani]

...and released as react-pdf v9.1.1.

Thanks Wojciech, for promptly releasing the version.

[jayeshmangwani]

@CyberAndrii Now we can remove the patch and update the react-pdf version. Please feel free to raise a PR.

[thienlnam]

Woo awesome! Nice work 🎉

[CyberAndrii]

react-fast-pdf PR is ready in case you missed it.

@thienlnam please you run the workflows

[jayeshmangwani]

Thanks for the ping, @CyberAndrii . I’m checking the react-fast-pdf PR now.

[jayeshmangwani]

@CyberAndrii We're good to move the PR out of draft.

[CyberAndrii]

Payment is due 2024-10-08

#49527 (comment)

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thienlnam]

Payment also due here cc @trjExpensify

[trjExpensify]

Confirming payments as follows:

• $500 to @CyberAndrii for the fix
• $500 to @jayeshmangwani for the C+ review

Is that right?

[trjExpensify]

@CyberAndrii paid, @jayeshmangwani feel free to request. Closing!

[garrettmknight]

$500 approved for @jayeshmangwani