Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-11-30] [$500] Web - Attachment - Console error shows up when closing the PDF view while it is loading #31209

Closed
1 of 6 tasks
kbecciv opened this issue Nov 10, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Nov 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 1.3.98.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Go to chat.
  3. Click + > Add attachment.
  4. Upload a PDF.
  5. After upload is done, click on the PDF.
  6. While the PDF is still loading, close the PDF view with ESC key.

Expected Result:

No console error will show up.

Actual Result:

Console error 'Uncaught (in promise) Error: Worker was terminated' shows up.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6271763_1699647492404.20231111_030636.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01cba1c5a184872fe2
  • Upwork Job ID: 1723074341611794432
  • Last Price Increase: 2023-11-10
  • Automatic offers:
    • shubham1206agra | Contributor | 27707739
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot changed the title Web - Attachment - Console error shows up when closing the PDF view while it is loading [$500] Web - Attachment - Console error shows up when closing the PDF view while it is loading Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Job added to Upwork: https://www.upwork.com/jobs/~01cba1c5a184872fe2

Copy link

melvin-bot bot commented Nov 10, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 10, 2023
Copy link

melvin-bot bot commented Nov 10, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @narefyev91 (External)

@vladimir-8
Copy link

This error is emitted by react-pdf library. I found it's already been reported in their repository: wojtekmaj/react-pdf#1062 I guess the best solution is to patch it there

@shubham1206agra
Copy link
Contributor

shubham1206agra commented Nov 11, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue

Web - Attachment - Console error shows up when closing the PDF view while it is loading

What is the root cause of that problem?

This is because loadingTask.destroy() is not working correctly which is explained in detail in mozilla/pdf.js#11595.

What changes do you think we should make in order to solve the problem?

We can patch the unmounting method in the Document by adding

if (this.loadingTask) {
    this.loadingTask._worker.destroy();
    this.loadingTask.destroy();
}

in the react-pdf library.

What alternative solutions did you explore? (Optional)

We can try to upgrade to v7 for react-pdf but its known to have some problems in re-render.

@melvin-bot melvin-bot bot added the Overdue label Nov 13, 2023
@narefyev91
Copy link
Contributor

Proposal from @shubham1206agra looks good to me #31209 (comment)
Based on the comments in react-pdf - issue still reproduced in v7 - my concern will be to make a patch and apply changes to fix error in console.
🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Nov 13, 2023

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@trjExpensify
Copy link
Contributor

Over to you Franc for the secondary proposal review!

@francoisl
Copy link
Contributor

LGTM

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Nov 16, 2023
Copy link

melvin-bot bot commented Nov 16, 2023

📣 @shubham1206agra 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Nov 17, 2023
@melvin-bot melvin-bot bot changed the title [$500] Web - Attachment - Console error shows up when closing the PDF view while it is loading [HOLD for payment 2023-11-30] [$500] Web - Attachment - Console error shows up when closing the PDF view while it is loading Nov 23, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 23, 2023
Copy link

melvin-bot bot commented Nov 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.2-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-11-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Nov 23, 2023

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@narefyev91 / @shubham1206agra] The PR that introduced the bug has been identified. Link to the PR:
  • [@narefyev91 / @shubham1206agra] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
  • [@narefyev91 / @shubham1206agra] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
  • [@narefyev91 / @shubham1206agra] Determine if we should create a regression test for this bug.
  • [@narefyev91 / @shubham1206agra] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
  • [@trjExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Nov 30, 2023
@trjExpensify
Copy link
Contributor

👋 Checklist time please! :).

@narefyev91
Copy link
Contributor

  • The PR that introduced the bug has been identified. Link to the PR - no regression - new implementation
  • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment - N/A
  • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion - N/A
  • Determine if we should create a regression test for this bug - N/A

@melvin-bot melvin-bot bot added the Overdue label Dec 4, 2023
@trjExpensify
Copy link
Contributor

Thanks, agreed. @shubham1206agra paid!

@melvin-bot melvin-bot bot removed the Overdue label Dec 4, 2023
@AlfredMadere
Copy link

I'm still getting this exact issue on v9. I am not loading the workerSrc locally as shown below due to some annoying project requirements. Is it possible that this fix only works if you use the local script method?

pdfjs.GlobalWorkerOptions.workerSrc = `//unpkg.com/pdfjs-dist@${pdfjs.version}/build/pdf.worker.min.mjs`

Copy link

melvin-bot bot commented Jun 21, 2024

📣 @AlfredMadere! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

7 participants