Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-11-13] Enable Bridgeless mode #48163

Closed
mountiny opened this issue Aug 28, 2024 · 26 comments
Closed

[HOLD for payment 2024-11-13] Enable Bridgeless mode #48163

mountiny opened this issue Aug 28, 2024 · 26 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Aug 28, 2024

Problem

We have updated the app to the 0.75 RN version now which allows us to use bridgeless mode. You can read more about what this mode is here. We have not enabled it yet, though, so we are missing out on the benefits that this mode brings. The main benefit should be improved performance, although we still need to test and measure how much performance gains there are for us in the App.

Solution

Enable the Bridgeless mode in the App and compare the performance with the mode on and off

Issue OwnerCurrent Issue Owner: @abekkala
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Current assignee @abekkala is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Aug 28, 2024
@roryabraham
Copy link
Contributor

thanks for creating this @mountiny!

@mountiny
Copy link
Contributor Author

mountiny commented Sep 9, 2024

This will take some time to enable, swm is working on this

@melvin-bot melvin-bot bot removed the Overdue label Sep 9, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 17, 2024
@mountiny
Copy link
Contributor Author

We will want to post a proper problem solution to the channel before we make more progress on this one @WoLewicki @j-piasecki I will try to see if I can help with that

@melvin-bot melvin-bot bot removed the Overdue label Sep 17, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@mountiny
Copy link
Contributor Author

updated proposal was shared in slack and I think we are good to move forward https://expensify.slack.com/archives/C05LX9D6E07/p1727354565454709

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Weekly KSv2 labels Sep 27, 2024
@roryabraham roryabraham removed their assignment Oct 4, 2024
@abekkala
Copy link
Contributor

@mountiny is there a PR for this one yet?

I'm going ooo until Oct 20 - I'd like to assign a buddy to watch this one until I return. But I'd like to better understand the progress status of this one first.

@WoLewicki
Copy link
Contributor

Here it is: #48160

Copy link

melvin-bot bot commented Oct 29, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-05. 🎊

Copy link

melvin-bot bot commented Oct 29, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 29, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Daily KSv2 and removed Weekly KSv2 labels Oct 29, 2024
@abekkala
Copy link
Contributor

abekkala commented Nov 5, 2024

PAYMENT SUMMARY FOR NOV 13

Copy link

melvin-bot bot commented Nov 5, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Nov 6, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-11-05] Enable Bridgeless mode [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-05] Enable Bridgeless mode Nov 6, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Nov 6, 2024
Copy link

melvin-bot bot commented Nov 6, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Nov 6, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-11-13. 🎊

Copy link

melvin-bot bot commented Nov 6, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mountiny] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@abekkala abekkala changed the title [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-05] Enable Bridgeless mode [HOLD for payment 2024-11-13] Enable Bridgeless mode Nov 6, 2024
Copy link

melvin-bot bot commented Nov 13, 2024

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@abekkala
Copy link
Contributor

No Payments needed:

  • Fix: SWM
  • PR Review: internal (Vit)

No regressions, closing this issue

@fedirjh
Copy link
Contributor

fedirjh commented Nov 13, 2024

@abekkala I was C+ on this PR : #48160 . Correct payment summary is #48163 (comment)

@mountiny mountiny reopened this Nov 13, 2024
@abekkala
Copy link
Contributor

Thanks, @fedirjh. That's what I thought - Melvin's post after me confused me a bit. In this case their post was not helpful> Back to my original payment summary lol


PAYMENT SUMMARY FOR NOV 13

@garrettmknight
Copy link
Contributor

$250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Weekly KSv2
Projects
Development

No branches or pull requests

7 participants