Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] Card - Double RHP animation gets shown when clicking on Issue New Card #48204

Closed
1 of 6 tasks
lanitochka17 opened this issue Aug 28, 2024 · 22 comments
Closed
1 of 6 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause

Comments

@lanitochka17
Copy link

lanitochka17 commented Aug 28, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.25-10
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+nl466@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Sign in with a new Expensifail account
  3. Create a workspace
  4. Make the default currency of the workspace "USD"
  5. Go to more features and enable expensify cards
  6. Go to Expensify Card and click on Issue card
  7. Click outside the RHP to close the RHP
  8. Click on Issue New Card again and observe the RHP

Expected Result:

One RHP opening animation is displayed

Actual Result:

Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6585108_1724840589161.bandicam_2024-08-28_13-20-42-842.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01639b582438af2409
  • Upwork Job ID: 1829560063821054093
  • Last Price Increase: 2024-08-30
  • Automatic offers:
    • dukenv0307 | Reviewer | 103782679
    • dominictb | Contributor | 103782680
Issue OwnerCurrent Issue Owner: @dukenv0307
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Aug 28, 2024
Copy link

melvin-bot bot commented Aug 28, 2024

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@lanitochka17
Copy link
Author

We think that this bug might be related to #wave-collect - Release 2

@dominictb
Copy link
Contributor

dominictb commented Aug 29, 2024

Edited by proposal-police: This proposal was edited at 2024-08-29 04:47:44 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Double RHP opening animation is displayed. It seems like two RHP opened with a small delay from each other

What is the root cause of that problem?

When users press Issue new card, we trigger the following logic with stepToOpen is empty string

Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('', policy?.id, ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1')));

-> the url is bank-account?backTo....

In ReimbursementAccountPage page, we will navigate to the actual step

Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(getRouteForCurrentStep(currentStep), policyID, backTo));

-> the url is bank-account/new?backTo....

So we can see the flicker

What changes do you think we should make in order to solve the problem?

We should use new for stepToOpen params same as what we already did in here since we want to start the flow, so the step should be new

            Navigation.navigate(ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute('new', policy?.id, ROUTES.WORKSPACE_EXPENSIFY_CARD.getRoute(policy?.id ?? '-1')));

What alternative solutions did you explore? (Optional)

We should check other places too

@CortneyOfstad
Copy link
Contributor

Attempted to recreate, but experiencing another bug within my expensifail.com account. That is linked here

In the meantime, going to get eyes on this.

@CortneyOfstad CortneyOfstad added External Added to denote the issue can be worked on by a contributor Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause labels Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01639b582438af2409

@melvin-bot melvin-bot bot changed the title Card - Double RHP animation gets shown when clicking on Issue New Card [$250] Card - Double RHP animation gets shown when clicking on Issue New Card Aug 30, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 30, 2024
Copy link

melvin-bot bot commented Aug 30, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@Nodebrute
Copy link
Contributor

Issue not reproducible on latest main

Screen.Recording.2024-08-30.at.9.44.58.PM.mov

@dukenv0307
Copy link
Contributor

I still can reproduce

@dukenv0307
Copy link
Contributor

@dominictb's proposal LGTM

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Sep 2, 2024

Triggered auto assignment to @tgolen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 2, 2024
Copy link

melvin-bot bot commented Sep 2, 2024

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

Copy link

melvin-bot bot commented Sep 2, 2024

📣 @dominictb 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Sep 5, 2024
@melvin-bot melvin-bot bot added the Weekly KSv2 label Sep 5, 2024
@CortneyOfstad
Copy link
Contributor

PR has not been deployed to staging yet, so will continue to keep an eye on things!

@CortneyOfstad
Copy link
Contributor

QA is still on-going!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@dominictb
Copy link
Contributor

@CortneyOfstad PR deployed to production 3 weeks ago. Should be ready for payment now. Please add [HOLD for payment] to the title.

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Sep 30, 2024
Copy link

melvin-bot bot commented Sep 30, 2024

This issue has not been updated in over 15 days. @tgolen, @CortneyOfstad, @dukenv0307, @dominictb eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@dominictb
Copy link
Contributor

@CortneyOfstad Please handle payment for this.

@CortneyOfstad CortneyOfstad added Awaiting Payment Auto-added when associated PR is deployed to production and removed Reviewing Has a PR in review labels Oct 14, 2024
@CortneyOfstad
Copy link
Contributor

Payment Summary

@dominictb — paid $250 via Upwork
@dukenv0307 — paid $250 via Upwork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Monthly KSv2 Needs Reproduction Reproducible steps needed retest-weekly Apply this label if you want this issue tested on a Weekly basis by Applause
Projects
None yet
Development

No branches or pull requests

8 participants