[HOLD for payment 2024-09-24] [$125] Import categories - Error message for multiple GL code mappings displays "glCode"

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47827
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Control workspace settings > Categories.
3. Click 3-dot menu.
4. Click Import spreadsheet.
5. Import a CSV file that has multiple columns.
6. Map Name, Enabled.
7. Map GL code a few times.
8. Click Import.

Expected Result:

The error message for multiple GL code mappings will display "GL code".

Actual Result:

The error message for multiple GL code mappings displays "glCode".

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592371_1725411660394.20240904_074708.mp4

Bug6592371_1725411660406!Independent.-.Multi.Level.tags.csv

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016b3b7ee11227810d
• Upwork Job ID: 1831261318645362164
• Last Price Increase: 2024-09-04

Issue Owner

Current Issue Owner: @mkhutornyi

[melvin-bot]

Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The error message for multiple GL code mappings displays "glCode".

What is the root cause of that problem?

In Onyx, columns are stored as column values, not column text:

Then in

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 56 in 562d7b4

const columns = Object.values(spreadsheet?.columns ?? {});

and

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 66 to 73 in 562d7b4

	} else {
	const duplicate = findDuplicate(columns);
	if (duplicate) {
	errors.duplicates = translate('spreadsheet.singleFieldMultipleColumns', duplicate);
	} else {
	errors = {};
	}
	}

We use column value to display duplicate error instead of column text, which result in the error displayed as glCode, meanwhile when displaying missing column error in

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Lines 59 to 65 in 562d7b4

	if (!requiredColumns.every((requiredColumn) => columns.includes(requiredColumn.value))) {
	// eslint-disable-next-line rulesdir/prefer-early-return
	requiredColumns.forEach((requiredColumn) => {
	if (!columns.includes(requiredColumn.value)) {
	errors.required = translate('spreadsheet.fieldNotMapped', requiredColumn.text);
	}
	});

we use column text, which results in correct message.

What changes do you think we should make in order to solve the problem?

Get column text from the column value using columnRoles here

Change this:

App/src/pages/workspace/categories/ImportedCategoriesPage.tsx

Line 69 in 562d7b4

errors.duplicates = translate('spreadsheet.singleFieldMultipleColumns', duplicate);

to:

        const duplicateColumn = columnRoles.find((role) => role.value === duplicate);
        errors.duplicates = translate('spreadsheet.singleFieldMultipleColumns', duplicateColumn?.text ?? '');

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016b3b7ee11227810d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[madmax330]

@daledah can you find the offending PR?

[shubham1206agra]

@madmax330 It is #47827
cc @filip-solecki @rushatgabhane.

I think this feature is behind beta. Can someone confirm?

[mountiny]

cc @filip-solecki @rushatgabhane @rlinoz coming from the import spreadsheet PR

[mountiny]

This feels super minor so demoting

[melvin-bot]

Upwork job price has been updated to $125

[madmax330]

@rushatgabhane seems like you are familiar with this, can you chime in here?

[greg-schroeder]

Waiting to see what Rushat has to say!

[rushatgabhane]

yeah this seems very minor.

@daledah's proposal should work

[rushatgabhane]

cc: @madmax330

[melvin-bot]

📣 @daledah You have been assigned to this job!
Please apply to the Upwork job and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Once you apply to this job, your Upwork ID will be stored and you will be automatically hired for future jobs!
Keep in mind: Code of Conduct | Contributing 📖

[daledah]

@rushatgabhane PR is ready.

[trjExpensify]

CSV import is a #wave-control project, moving this over.

[greg-schroeder]

Oops. sorry, thanks @trjExpensify

[greg-schroeder]

PR is merged and has been deployed to staging. awaiting deploy to prod

[greg-schroeder]

Prod automation didn't work, updated title/payment date

[greg-schroeder]

Payment summary:

Contributor: @daledah - $125 - Will be paid via Upwork on 9/24
C+: @rushatgabhane - $125 - Can make a manual request on ND on 9/24

[garrettmknight]

$125 approved for @rushatgabhane

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @rushatgabhane owed $125 via NewDot
• ROLE: @daledah paid $125 via Upwork

BugZero Checklist (@greg-schroeder)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1831261318645362164/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[greg-schroeder]

@daledah can you please follow the requested steps here so I can pay you? thanks

[greg-schroeder]

NVM, offer sent via Upwork, I believe I found your profile. Will pay ASAP once you accept

[daledah]

Will pay ASAP once you accept

@greg-schroeder Done that thanks

[greg-schroeder]

paid