[WAITING ON CHECKLIST - RUSHAT] [$250] Desktop - Categories - App crashes after importing categories and clicking Got it

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #47827
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify desktop app.
2. Go to workspace settings > Categories.
3. Click 3-dot menu.
4. Click Import spreadsheet.
5. Import the following csv file. (app only crashes with this file)
6. Map Name, Enabled and GL code.
7. Click Import.
8. Click Got it.

Expected Result:

App will not crash.

Actual Result:

App crashes after importing categories and clicking Got it.
This issue is only reproducible on desktop app.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

0409_1.txt
Bug6592389_1725413369885!--1725413225174.txt
Bug6592389_1725413369824!Independent.-.Multi.Level.tags (1).csv

Bug6592389_1725413369808.20240904_092636.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021831378368788118300
• Upwork Job ID: 1831378368788118300
• Last Price Increase: 2024-09-04
• Automatic offers:
• nkdengineer | Contributor | 103821693

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @iwiznia (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[mountiny]

@filip-solecki @rlinoz @rushatgabhane a proper deploy blocker

[mountiny]

Lets try to catch the error with parsing the file and show error message to the user that the file is not supported instead of crashing the app

[filip-solecki]

Hi! I am Filip from SWM and I'd like to work on this!

[mountiny]

@filip-solecki says this is because the categories are array at first, and the onyx merge causes this error. I have created a web fix to make sure the categories are not empty array but empty object https://github.com/Expensify/Web-Expensify/pull/43372

[m-natarajan]

Tester is still able to reproduce

20240905_003743.mp4

[mountiny]

@filip-solecki seems like there must be some other root cause for this issue as we are now returning the categories as empty object

Looking for proposals

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021831378368788118300

[melvin-bot]

Current assignee @rushatgabhane is eligible for the External assigner, not assigning anyone new.

[rushatgabhane]

let's assign @nkdengineer ?

[roryabraham]

The fact that this can be fixed by adding an optional chain operator, and that wasn't automatically detected, suggests to me that we have incorrect types somewhere

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Thanks @nkdengineer what is your eta for the pr?

[nkdengineer]

@mountiny The PR is ready.

[rushatgabhane]

The fact that this can be fixed by adding an optional chain operator, and that wasn't automatically detected, suggests to me that we have incorrect types somewhere

We're trying to access a value in columns: Record<number, string> using a dynamic key -> columns[columnIndex].

The type is correct. This code is just unsafe in TS. The problem here is that we should ideally have typecheck catch this idk how tho because index is a number

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.29-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix app crash when clicking on got it button #48609

If no regressions arise, payment will be issued on 2024-09-12. 🎊

For reference, here are some details about the assignees on this issue:

• @rushatgabhane requires payment through NewDot Manual Requests
• @filip-solecki does not require payment (Contractor)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@rushatgabhane] Determine if we should create a regression test for this bug.
• [@rushatgabhane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@jliexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[jliexpensify]

Payment Summary

• C: @nkdengineer $250
• C+: @rushatgabhane - no need to pay

Upwork job

[jliexpensify]

Paid via Upworks and job closed

[rushatgabhane]

Hello 👋

I've been overpaid $250 by mistake in another issue.

So please don't pay me for this issue. Thank you for understanding

[jliexpensify]

Cool, all good - will remove this from the summary! Thanks!

[jliexpensify]

@rushatgabhane just waiting on a checklist, if one is needed

[rushatgabhane]

not needed here. it is covered by existing regression steps