Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-07] [$250] Track - Loading spinner appears on a Track your expenses video modal #48650

Closed
1 of 6 tasks
lanitochka17 opened this issue Sep 5, 2024 · 37 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor

Comments

@lanitochka17
Copy link

lanitochka17 commented Sep 5, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a2069@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to FAB> Track
  2. Verify that video modal appears

Expected Result:

There should be no loading spinner over the video modal

Actual Result:

Loading spinner appears on a Track your expenses video modal and remains to the end of the video

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6593462_1725483841193.Recording__3883.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021832057700758749301
  • Upwork Job ID: 1832057700758749301
  • Last Price Increase: 2024-09-20
  • Automatic offers:
    • HezekielT | Contributor | 104122623
Issue OwnerCurrent Issue Owner: @hungvu193
@lanitochka17 lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Sep 5, 2024
Copy link

melvin-bot bot commented Sep 5, 2024

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@lanitochka17
Copy link
Author

@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

@nyomanjyotisa
Copy link
Contributor

nyomanjyotisa commented Sep 5, 2024

Edited by proposal-police: This proposal was edited at {current_timestamp}.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Loading spinner appears on a Track your expenses video modal

What is the root cause of that problem?

The loading spinner is controlled by setIsLoading and relies on status.durationMillis here. And sometime the expo-av video player might not be providing valid values for durationMillis

What changes do you think we should make in order to solve the problem?

Update the setIsLoading logic to handle both durationMillis and positionMillis, only set isLoading to true if status.durationMillis is NaN and status.positionMillis is 0

setIsLoading(Number.isNaN(status.durationMillis) && status.positionMillis === 0);

This ensures that the spinner disappears when the video starts playing

What alternative solutions did you explore? (Optional)

@bfitzexpensify bfitzexpensify added the External Added to denote the issue can be worked on by a contributor label Sep 6, 2024
@melvin-bot melvin-bot bot changed the title Track - Loading spinner appears on a Track your expenses video modal [$250] Track - Loading spinner appears on a Track your expenses video modal Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021832057700758749301

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

@bfitzexpensify
Copy link
Contributor

I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence.

Current status: waiting on proposals

@bfitzexpensify bfitzexpensify added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 6, 2024
Copy link

melvin-bot bot commented Sep 6, 2024

Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new.

@hungvu193
Copy link
Contributor

@nyomanjyotisa Are you sure?
If you used nullish coalescing operator, it's only return the right-hand side operand if the left-hand side is null or undefined.

setIsLoading(Number.isNaN(status.durationMillis) ?? status.positionMillis > 0);

is the same with

setIsLoading(Number.isNaN(status.durationMillis) )

Beacuse Number.isNaN return bool.

@shubham1206agra
Copy link
Contributor

This looks super weird to me. @bfitzexpensify Can we ask someone from an expert agency to look into this to avoid a workaround?

@nyomanjyotisa
Copy link
Contributor

Proposal updated

@hungvu193
Copy link
Contributor

I'll take closer look today.

@hungvu193
Copy link
Contributor

Can't reproduce on latest main:

Screen.Recording.2024-09-12.at.09.58.09.mov

Copy link

melvin-bot bot commented Sep 13, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@hungvu193
Copy link
Contributor

Can you retest this one @lanitochka17 ?

Copy link

melvin-bot bot commented Sep 19, 2024

@hungvu193 @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 19, 2024
Copy link

melvin-bot bot commented Sep 19, 2024

@hungvu193, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hungvu193
Copy link
Contributor

little bump @bfitzexpensify

@melvin-bot melvin-bot bot removed the Overdue label Sep 20, 2024
Copy link

melvin-bot bot commented Sep 20, 2024

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

Copy link

melvin-bot bot commented Sep 23, 2024

@hungvu193, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

@hungvu193
Copy link
Contributor

hungvu193 commented Sep 25, 2024

Thanks for the proposals, everyone. It looks like on Android, sometimes the isBuffering is set incorrectly

Android buffering
Screen.Recording.2024-09-25.at.14.16.17.mov

I'd go with @HezekielT 's proposal that it has the correct RCA and I agree we shouldn't show the loading indicator while it's playing.

🎀 👀 🎀 C+ reviewed.

Copy link

melvin-bot bot commented Sep 25, 2024

Triggered auto assignment to @MarioExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@MarioExpensify
Copy link
Contributor

@HezekielT proposal LGTM! Thanks @HezekielT and @hungvu193

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 25, 2024
Copy link

melvin-bot bot commented Sep 25, 2024

📣 @HezekielT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Sep 25, 2024
@HezekielT
Copy link
Contributor

@hungvu193 PR is ready!

@MarioExpensify MarioExpensify changed the title [$250] Track - Loading spinner appears on a Track your expenses video modal [HOLD for payment 2024-10-07] [$250] Track - Loading spinner appears on a Track your expenses video modal Oct 4, 2024
@MarioExpensify MarioExpensify added Daily KSv2 Awaiting Payment Auto-added when associated PR is deployed to production Weekly KSv2 and removed Weekly KSv2 Daily KSv2 Reviewing Has a PR in review labels Oct 4, 2024
@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@bfitzexpensify
Copy link
Contributor

Payment summary:

@HezekielT to be paid $250 for contributor work - @HezekielT, can you confirm the payment via Upwork went through? They've been having some issues processing payments
@hungvu193 to be paid $250 via manual request

@garrettmknight
Copy link
Contributor

$250 approved for @hungvu193

@HezekielT
Copy link
Contributor

can you confirm the payment via Upwork went through?

Yes, I have received the payment. Thanks @bfitzexpensify

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 10, 2024
Copy link

melvin-bot bot commented Oct 15, 2024

@hungvu193, @bfitzexpensify, @HezekielT, @MarioExpensify Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Oct 15, 2024
@MarioExpensify
Copy link
Contributor

Hey @bfitzexpensify can we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests

10 participants