-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-07] [$250] Track - Loading spinner appears on a Track your expenses video modal #48650
Comments
Triggered auto assignment to @bfitzexpensify ( |
@bfitzexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
Edited by proposal-police: This proposal was edited at {current_timestamp}. ProposalPlease re-state the problem that we are trying to solve in this issue.Loading spinner appears on a Track your expenses video modal What is the root cause of that problem?The loading spinner is controlled by What changes do you think we should make in order to solve the problem?Update the
This ensures that the spinner disappears when the video starts playing What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~021832057700758749301 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 ( |
I am heading out of office until September 21st, so assigning a buddy to watch over this in my absence. Current status: waiting on proposals |
Current assignee @bfitzexpensify is eligible for the Bug assigner, not assigning anyone new. |
@nyomanjyotisa Are you sure? setIsLoading(Number.isNaN(status.durationMillis) ?? status.positionMillis > 0); is the same with
Beacuse |
This looks super weird to me. @bfitzexpensify Can we ask someone from an expert agency to look into this to avoid a workaround? |
I'll take closer look today. |
Can't reproduce on latest main: Screen.Recording.2024-09-12.at.09.58.09.mov |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Can you retest this one @lanitochka17 ? |
@hungvu193 @bfitzexpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
@hungvu193, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
little bump @bfitzexpensify |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@hungvu193, @bfitzexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Thanks for the proposals, everyone. It looks like on Android, sometimes the Android bufferingScreen.Recording.2024-09-25.at.14.16.17.movI'd go with @HezekielT 's proposal that it has the correct RCA and I agree we shouldn't show the loading indicator while it's playing. 🎀 👀 🎀 C+ reviewed. |
Triggered auto assignment to @MarioExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@HezekielT proposal LGTM! Thanks @HezekielT and @hungvu193 |
📣 @HezekielT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
@hungvu193 PR is ready! |
Issue not reproducible during KI retests. (First week) |
Payment summary: @HezekielT to be paid $250 for contributor work - @HezekielT, can you confirm the payment via Upwork went through? They've been having some issues processing payments |
$250 approved for @hungvu193 |
Yes, I have received the payment. Thanks @bfitzexpensify |
@hungvu193, @bfitzexpensify, @HezekielT, @MarioExpensify Huh... This is 4 days overdue. Who can take care of this? |
Hey @bfitzexpensify can we close this one? |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): gocemate+a2069@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
There should be no loading spinner over the video modal
Actual Result:
Loading spinner appears on a Track your expenses video modal and remains to the end of the video
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6593462_1725483841193.Recording__3883.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @hungvu193The text was updated successfully, but these errors were encountered: