Netsuite-App crashes when connecting to Netsuite with incorrect credentials

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.0.30-7
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+shsb223455@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Log in to new dot with a new account and create a new workspace
2. Navigate to settings > workspace > More features > Enable accounting
3. Go to Accounting > Connect to Netsuite > Upgrade to Control > Got it
4. When the Netsuite Setup RHP opens proceed with the setup
5. Enter incorrect credentials when prompted and connect

Expected Result:

"Can't connect to NetSuite." error appears and app does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

0609.log

Bug6594941_1725595347741.2024-09-06_06_54_27.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[etCoderDysto]

Proposal

Offending PR: #46667

I can raise a quick PR if the author is not available at the time

Please re-state the problem that we are trying to solve in this issue.

Netsuite-App crashes when connecting to Netsuite with incorrect credentials

What is the root cause of that problem?

We are not applying optional chaining on options

App/src/pages/workspace/accounting/utils.tsx

Line 51 in da8370f

const netsuiteConfig = policy?.connections?.netsuite?.options.config;

What changes do you think we should make in order to solve the problem?

Use optional chaining on options

const netsuiteConfig = policy?.connections?.netsuite?.options?.config;

What alternative solutions did you explore? (Optional)

[war-in]

Ah sorry for this one 🙈
@etCoderDysto thanks for the proposal, I checked it and it's working correctly!
I can create a PR in a moment or you can do this if you want. Please let me know 🙏

[etCoderDysto]

@war-in You are welcome! I think you can raise a PR since you are available.

[Julesssss]

PR fix merged. I'm going to CP to staging to resolve the blocker.

[Julesssss]

CP successful, I marked it off the checklist

[Pujan92]

@war-in I am seeing the crash while connecting Netsuite.

[war-in]

@war-in I am seeing the crash while connecting Netsuite.

@Pujan92 is there an issue for this bug? Or could you create one and add some reproduction steps? 🙏
It'd be nice to have a dedicated place to discuss it :)