Offline and error patterns in NetSuite integration #46667

war-in · 2024-08-01T15:21:49Z

Details

Fixed Issues

$ #45406 - partially fixed
PROPOSAL:

Tests

Test errors:

Set Simulate failing network in Troubleshooting (you can set MAX_REQUEST_RETRIES to 0 to get errors faster).
Go to Settings -> Workspaces -> your NetSuite workspace -> Accounting.
Go through every page and try changing values.
See that there are RBRs and error messages when request fails.

Offline tests

Go to Settings -> Workspaces -> your NetSuite workspace -> Accounting.
Go through every page and try changing values.
See that changed values are on opacity 50%.

QA Steps

Test errors:

Set Simulate failing network in Troubleshooting (you can set MAX_REQUEST_RETRIES to 0 to get errors faster).
Go to Settings -> Workspaces -> your NetSuite workspace -> Accounting.
Go through every page and try changing values.
See that there are RBRs and error messages when request fails.

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-06.at.14.57.34.mov

Android: mWeb Chrome

iOS: Native

Screen.Recording.2024-08-06.at.14.19.53.mov

Screen.Recording.2024-08-06.at.14.57.34.mov

iOS: mWeb Safari

Screen.Recording.2024-08-06.at.14.25.17.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-06.at.13.45.02.mov

Screen.Recording.2024-08-06.at.13.39.54.mov

MacOS: Desktop

Screen.Recording.2024-08-06.at.15.05.42.mov

…suite

src/pages/workspace/accounting/PolicyAccountingPage.tsx

shubham1206agra · 2024-08-22T08:08:26Z

@war-in I am unable to edit anything in custom segment.

war-in · 2024-08-22T08:15:58Z

@shubham1206agra I think this is the expected behaviour for the offline state (and should be reproducible on the main too)

shubham1206agra · 2024-08-22T08:39:27Z

@war-in But I am online

war-in · 2024-08-23T10:13:19Z

@shubham1206agra Thanks again for catching this 🙏 Please let me know if my latest commit fixed the bug

shubham1206agra · 2024-08-23T12:26:44Z

Screen.Recording.2024-08-23.at.5.54.10.PM.mov

@war-in Can you see why the value was not reverted back here?

shubham1206agra · 2024-08-23T12:48:51Z

Screen.Recording.2024-08-23.at.6.16.43.PM.mov

@war-in I think error is being shown in wrong place here.

shubham1206agra · 2024-08-23T13:44:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

Screen.Recording.2024-08-23.at.6.35.58.PM.mov

iOS: Native

Screen.Recording.2024-08-23.at.7.09.44.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-23.at.6.21.38.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-23.at.6.02.24.PM.mov

MacOS: Desktop

Screen.Recording.2024-08-23.at.6.59.37.PM.mov

war-in · 2024-08-26T09:49:18Z

@war-in I think error is being shown in wrong place here.

@shubham1206agra I thought so too but the design team prefers showing it in both places (check this comment and thread).
We select the option and it changes the values which are changed by the toggles too so the error should be shown there too (because we can fix it there)

war-in · 2024-08-26T09:50:50Z

@war-in Can you see why the value was not reverted back here?

@shubham1206agra Fixed!

war-in · 2024-08-28T08:09:42Z

@shubham1206agra Kind bump :)

…suite

shubham1206agra · 2024-08-29T10:21:59Z

@deetergp Bump on the merge now

shubham1206agra · 2024-08-29T15:12:44Z

@war-in Can you fix lint here?

war-in · 2024-08-30T08:08:08Z

@shubham1206agra done!

war-in · 2024-09-02T09:10:00Z

@deetergp Kind bump :)

deetergp · 2024-09-04T15:50:10Z

Sorry, I was OOO for a few days. Looks good to me, thanks for the hard work!

OSBotify · 2024-09-04T16:07:46Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-05T19:40:05Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.0.30-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

war-in added 17 commits July 30, 2024 14:37

fix error placement in subsidiary selection

9907ba5

fix error in mappings

3135e77

fix error in mappings

f21036f

fix errors in import page

a457a37

update export page

1b4b9fc

update invoice config pages

d112600

Merge branch 'refs/heads/main' into war-in/offline-error-patterns-net…

9bfabdc

…suite

add errors in export -> tax posting account

9776986

move sync options errors and pending fields to the top

cf2d602

use universal pending action function on advanced page

7df165c

use proper function

6c587e5

Merge branch 'refs/heads/main' into war-in/offline-error-patterns-net…

f7a0e06

…suite

after-merge fixes

622b168

show list empty component in the middle

c3ee944

show list empty component in the middle

79277ec

propagate errors from (non)reimbursable expenses

22c2b86

propagate errors from entire export page

0582270

war-in mentioned this pull request Aug 2, 2024

[HOLD for payment 2024-09-17] [$250] Add Offline and Error Patterns to Remaining Integrations #45406

Closed

war-in added 7 commits August 2, 2024 12:48

update import mappings

8219f29

show RBR for import tax toggle

0f0b941

fix lint

3c16601

add errors to custom fields

5a3419a

fix pending action for custom fields

1724a48

Merge branch 'refs/heads/main' into war-in/offline-error-patterns-net…

e925a95

…suite

unify netsuite commands

3112a48

war-in commented Aug 5, 2024

View reviewed changes

src/pages/workspace/accounting/PolicyAccountingPage.tsx Outdated Show resolved Hide resolved

war-in added 4 commits August 6, 2024 11:27

use correct pending field in custom field edit

bd14365

propagate custom fields settings to PolicyAccountingPage

df2bfa0

add errorRowStyles to remaining screens

43778fd

revert max request retries

401707c

war-in added 2 commits August 21, 2024 14:36

fix sync options onyx data

44cb1ff

do not optimistically remove segment/list field

ce8b057

fix disabled custom field edit

da772ec

fallback to the previous value

c10ee9a

shubham1206agra approved these changes Aug 28, 2024

View reviewed changes

melvin-bot bot requested a review from deetergp August 28, 2024 11:42

war-in added 2 commits August 29, 2024 12:09

Merge branch 'refs/heads/main' into war-in/offline-error-patterns-net…

bf7b49a

…suite

fix not working Import customers toggle

bdbe3fa

fix lint

e95b465

deetergp approved these changes Sep 4, 2024

View reviewed changes

deetergp merged commit 312a11c into Expensify:main Sep 4, 2024
15 checks passed

github-actions bot mentioned this pull request Sep 5, 2024

Deploy Checklist: New Expensify 2024-09-05 #48664

Closed

69 tasks

etCoderDysto mentioned this pull request Sep 6, 2024

Netsuite-App crashes when connecting to Netsuite with incorrect credentials #48682

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Offline and error patterns in NetSuite integration #46667

Offline and error patterns in NetSuite integration #46667

war-in commented Aug 1, 2024 •

edited

Loading

shubham1206agra commented Aug 22, 2024

war-in commented Aug 22, 2024

shubham1206agra commented Aug 22, 2024

war-in commented Aug 23, 2024 •

edited

Loading

shubham1206agra commented Aug 23, 2024

shubham1206agra commented Aug 23, 2024

shubham1206agra commented Aug 23, 2024

war-in commented Aug 26, 2024

war-in commented Aug 26, 2024

war-in commented Aug 28, 2024

shubham1206agra commented Aug 29, 2024

shubham1206agra commented Aug 29, 2024

war-in commented Aug 30, 2024

war-in commented Sep 2, 2024

deetergp commented Sep 4, 2024

OSBotify commented Sep 4, 2024

OSBotify commented Sep 5, 2024

Offline and error patterns in NetSuite integration #46667

Offline and error patterns in NetSuite integration #46667

Conversation

war-in commented Aug 1, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

shubham1206agra commented Aug 22, 2024

war-in commented Aug 22, 2024

shubham1206agra commented Aug 22, 2024

war-in commented Aug 23, 2024 • edited Loading

shubham1206agra commented Aug 23, 2024

shubham1206agra commented Aug 23, 2024

shubham1206agra commented Aug 23, 2024

Reviewer Checklist

Screenshots/Videos

war-in commented Aug 26, 2024

war-in commented Aug 26, 2024

war-in commented Aug 28, 2024

shubham1206agra commented Aug 29, 2024

shubham1206agra commented Aug 29, 2024

war-in commented Aug 30, 2024

war-in commented Sep 2, 2024

deetergp commented Sep 4, 2024

OSBotify commented Sep 4, 2024

OSBotify commented Sep 5, 2024

war-in commented Aug 1, 2024 •

edited

Loading

war-in commented Aug 23, 2024 •

edited

Loading