Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD] [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. #49035

Open
1 of 6 tasks
m-natarajan opened this issue Sep 12, 2024 · 25 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2

Comments

@m-natarajan
Copy link

m-natarajan commented Sep 12, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072125690969

Action Performed:

  1. Visit the login page on Android App

Expected Result:

No console warning

Actual Result:

Console Warning

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Screenshot 2024-09-11 at 7 37 18 PM

Add any screenshot/video evidence

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @paultsimura
@m-natarajan m-natarajan added Daily KSv2 Needs Reproduction Reproducible steps needed Bug Something is broken. Auto assigns a BugZero manager. labels Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@MelvinBot
Copy link

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@mkzie2
Copy link
Contributor

mkzie2 commented Sep 12, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console Warning: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead.

What is the root cause of that problem?

This problem happens after RN 0.74 when you use the old component's defaultProps:

Screenshot 2024-09-12 at 15 03 43

What changes do you think we should make in order to solve the problem?

I see in the latest code base, they attempted removing defaultProps in this PR meliorence/react-native-render-html#658 but it has not been released yet.

In the meantime, we can apply a patch as suggested in this thread to solve the issue, not only in TRenderEngineProvider but also in other components.

@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
@muttmuure muttmuure added the External Added to denote the issue can be worked on by a contributor label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 17, 2024
Copy link

melvin-bot bot commented Sep 17, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura (External)

Copy link

melvin-bot bot commented Sep 17, 2024

@muttmuure Eep! 4 days overdue now. Issues have feelings too...

@paultsimura
Copy link
Contributor

The proposal by @mkzie2 looks OK, but it means adding a new patch, which we aim to avoid if possible.

Seems like the react-native-render-html is looking for new maintainers, so we have 2 options here:

  1. Use the suggested patch
  2. Make the upstream fix and wait for it to be merged after a new maintainer is assigned
  3. Wait for the upstream fix to be done without our participation

I'll let the assigned Engineer decide.

🎀👀🎀 C+ reviewed

Copy link

melvin-bot bot commented Sep 18, 2024

Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

Copy link

melvin-bot bot commented Sep 23, 2024

@paultsimura, @lakchote, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Sep 23, 2024
@paultsimura
Copy link
Contributor

@lakchote bump on #49035 (comment), please

@melvin-bot melvin-bot bot removed the Overdue label Sep 23, 2024
@blazejkustra
Copy link
Contributor

@lakchote @paultsimura They found a new maintainer, potentially we can wait for it to be fixed upstream

@lakchote
Copy link
Contributor

@lakchote @paultsimura They found a new maintainer, potentially we can wait for it to be fixed upstream

Alright, let's wait for it to be fixed directly from the upstream.

@muttmuure
Copy link
Contributor

Not overdue

Copy link

melvin-bot bot commented Sep 26, 2024

@paultsimura @lakchote @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2024
@paultsimura
Copy link
Contributor

Not overdue. Holding for meliorence/react-native-render-html#661

Copy link

melvin-bot bot commented Sep 30, 2024

@paultsimura, @lakchote, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 30, 2024
@paultsimura
Copy link
Contributor

Not overdue, holding for meliorence/react-native-render-html#661 👀

@paultsimura
Copy link
Contributor

The upstream issue has little to no movement at the moment. Let's change this to weekly, please.

Copy link

melvin-bot bot commented Oct 10, 2024

@paultsimura @lakchote @muttmuure this issue is now 4 weeks old, please consider:

  • Finding a contributor to fix the bug
  • Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
  • If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@melvin-bot melvin-bot bot added the Overdue label Oct 10, 2024
@paultsimura
Copy link
Contributor

@muttmuure could we demote this to weekly while we're holding for the upstream PR?
Or add a HOLD label, please.

@melvin-bot melvin-bot bot removed the Overdue label Oct 11, 2024
@lakchote lakchote added Weekly KSv2 and removed Daily KSv2 labels Oct 14, 2024
@lakchote lakchote changed the title [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. [HOLD] [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. Oct 14, 2024
@lakchote
Copy link
Contributor

@muttmuure could we demote this to weekly while we're holding for the upstream PR? Or add a HOLD label, please.

@muttmuure is on parental leave. I've demoted this to weekly.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Oct 18, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Nov 11, 2024
Copy link

melvin-bot bot commented Nov 11, 2024

This issue has not been updated in over 15 days. @paultsimura, @lakchote, @muttmuure eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@muttmuure
Copy link
Contributor

Is this done?

@paultsimura
Copy link
Contributor

No, we're holding for an upstream fix. However, it had no movement in a month already. Maybe we should go back to considering a patch?

@lakchote
Copy link
Contributor

No, we're holding for an upstream fix. However, it had no movement in a month already. Maybe we should go back to considering a patch?

Yes, there are no movements whatsoever. Let's go the patch route. I'm reopening #52917

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Needs Reproduction Reproducible steps needed Reviewing Has a PR in review Weekly KSv2
Projects
Development

No branches or pull requests

7 participants