-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD] [Dev] Console Warning: TRenderEngineProvider: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. #49035
Comments
Triggered auto assignment to @muttmuure ( |
This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989 |
ProposalPlease re-state the problem that we are trying to solve in this issue.Console Warning: Support for defaultProps will be removed from function components in a future major release. Use JavaScript default parameters instead. What is the root cause of that problem?This problem happens after RN 0.74 when you use the old component's What changes do you think we should make in order to solve the problem?I see in the latest code base, they attempted removing In the meantime, we can apply a patch as suggested in this thread to solve the issue, not only in |
Unable to auto-create job on Upwork. The BZ team member should create it manually for this issue. |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @paultsimura ( |
@muttmuure Eep! 4 days overdue now. Issues have feelings too... |
The proposal by @mkzie2 looks OK, but it means adding a new patch, which we aim to avoid if possible. Seems like the
I'll let the assigned Engineer decide. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @lakchote, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@paultsimura, @lakchote, @muttmuure Huh... This is 4 days overdue. Who can take care of this? |
@lakchote bump on #49035 (comment), please |
@lakchote @paultsimura They found a new maintainer, potentially we can wait for it to be fixed upstream |
Alright, let's wait for it to be fixed directly from the upstream. |
Not overdue |
@paultsimura @lakchote @muttmuure this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks! |
Not overdue. Holding for meliorence/react-native-render-html#661 |
@paultsimura, @lakchote, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Not overdue, holding for meliorence/react-native-render-html#661 👀 |
The upstream issue has little to no movement at the moment. Let's change this to weekly, please. |
@paultsimura @lakchote @muttmuure this issue is now 4 weeks old, please consider:
Thanks! |
@muttmuure could we demote this to weekly while we're holding for the upstream PR? |
@muttmuure is on parental leave. I've demoted this to weekly. |
This issue has not been updated in over 15 days. @paultsimura, @lakchote, @muttmuure eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
Is this done? |
No, we're holding for an upstream fix. However, it had no movement in a month already. Maybe we should go back to considering a patch? |
Yes, there are no movements whatsoever. Let's go the patch route. I'm reopening #52917 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number:
Reproducible in staging?: Needs reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1726072125690969
Action Performed:
Expected Result:
No console warning
Actual Result:
Console Warning
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @paultsimuraThe text was updated successfully, but these errors were encountered: