Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections #49116

Closed
luacmartins opened this issue Sep 12, 2024 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@luacmartins
Copy link
Contributor

luacmartins commented Sep 12, 2024

Implement this section of the doc

cc @Kicu @289Adam289 @Guccio163 @SzymczakJ

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021834650319760395608
  • Upwork Job ID: 1834650319760395608
  • Last Price Increase: 2024-09-13
Issue OwnerCurrent Issue Owner: @Christinadobrzyn
@luacmartins luacmartins added Daily KSv2 NewFeature Something to build that is a new item. labels Sep 12, 2024
@luacmartins luacmartins self-assigned this Sep 12, 2024
@luacmartins luacmartins moved this to Release 3: Fall 2024 (Nov) in [#whatsnext] #expense Sep 12, 2024
Copy link

melvin-bot bot commented Sep 12, 2024

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Sep 12, 2024
@luacmartins luacmartins added Daily KSv2 and removed Weekly KSv2 labels Sep 12, 2024
@SzymczakJ
Copy link
Contributor

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

@luacmartins luacmartins added the External Added to denote the issue can be worked on by a contributor label Sep 13, 2024
Copy link

melvin-bot bot commented Sep 13, 2024

Job added to Upwork: https://www.upwork.com/jobs/~021834650319760395608

@melvin-bot melvin-bot bot changed the title [Search v2.4] [App] Add Recent Searches and Recent Chats sections [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections Sep 13, 2024
@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 13, 2024
Copy link

melvin-bot bot commented Sep 13, 2024

Current assignee @rayane-djouah is eligible for the External assigner, not assigning anyone new.

@luacmartins luacmartins removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Sep 16, 2024
Copy link

melvin-bot bot commented Sep 16, 2024

@luacmartins, @Christinadobrzyn, @rayane-djouah, @SzymczakJ Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Christinadobrzyn
Copy link
Contributor

hi @SzymczakJ do you have an update on this for the team? TY!

@melvin-bot melvin-bot bot removed the Overdue label Sep 16, 2024
@SzymczakJ
Copy link
Contributor

The draft PR should be ready tomorrow.

Copy link

melvin-bot bot commented Sep 20, 2024

@luacmartins, @Christinadobrzyn, @rayane-djouah, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added the Overdue label Sep 20, 2024
@luacmartins
Copy link
Contributor Author

luacmartins commented Sep 23, 2024

Draft PR up

@Christinadobrzyn
Copy link
Contributor

Monitoring - #49457

Copy link

melvin-bot bot commented Oct 3, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Oct 3, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@Christinadobrzyn
Copy link
Contributor

Hey @rayane-djouah and @SzymczakJ can you check these ^ deploy blocker messages to see if they apply here?

@Kicu
Copy link
Contributor

Kicu commented Oct 4, 2024

but @jasperhuangg removed the deploy blocker labels from the issue as they were not able to reproduce it.
So I don't think there is anything to verify here if there is no clear repro.

@luacmartins
Copy link
Contributor Author

luacmartins commented Oct 4, 2024

Those blockers apply here, but they were already fixed with this PR/CP, that's why the blocker label was removed

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 4, 2024
@melvin-bot melvin-bot bot changed the title [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections [HOLD for payment 2024-10-11] [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections Oct 4, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 4, 2024
Copy link

melvin-bot bot commented Oct 4, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Oct 4, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 4, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@rayane-djouah
Copy link
Contributor

Regression tests will be handled as part of the project wrap-up

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 7, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-10-11] [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections [HOLD for payment 2024-10-14] [HOLD for payment 2024-10-11] [$250] [Search v2.4] [App] Add Recent Searches and Recent Chats sections Oct 7, 2024
Copy link

melvin-bot bot commented Oct 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Oct 7, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rayane-djouah] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@rayane-djouah
Copy link
Contributor

Regression tests will be handled as part of the project wrap-up

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 11, 2024
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Oct 14, 2024

Payouts due:

@rayane-djouah
Copy link
Contributor

@Christinadobrzyn - Offer accepted, thank you!

Copy link

melvin-bot bot commented Oct 14, 2024

Payment Summary

Upwork Job

BugZero Checklist (@Christinadobrzyn)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1834650319760395608/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@Christinadobrzyn
Copy link
Contributor

It's payday - payment summary here - #49116 (comment)

No regression test so closing this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
Archived in project
Development

No branches or pull requests

5 participants