-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-10-10] [$250] NetSuite - "Please fix the errors" message persists when navigating back on the RHP #49266
Comments
Triggered auto assignment to @slafortune ( |
We think that this bug might be related to #wave-control |
@slafortune FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors |
ProposalPlease re-state the problem that we are trying to solve in this issue.NetSuite - "Please fix the errors" message persists when navigating back on the RHP What is the root cause of that problem?
What changes do you think we should make in order to solve the problem?
useImperativeHandle(forwardedRef, () => ({
resetForm,
validate: () => onValidate(inputValues),
}));
const formRef = useRef<FormRef | null>(null);
const prevScreenIndex = usePrevious(screenIndex);
useEffect(() => {
if (prevScreenIndex <= screenIndex) {
return;
}
formRef.current?.validate();
}, [screenIndex, prevScreenIndex]); What alternative solutions did you explore? (Optional)Result |
ProposalPlease re-state the problem that we are trying to solve in this issue."Please fix the errors" message persists when navigating back on the RHP What is the root cause of that problem?We don't clear errors when navigating back to the previous screen What changes do you think we should make in order to solve the problem?In FormProvider, we'll add a new function called resetError and include it in useImperativeHandle
we should invoke the new function when navigating back to the previous screen Line 73 in 025a630
We also need to add formRef to FormProvider Additionally, we should apply the same change to NetSuiteImportAddCustomListPage, as this bug occurs on that page as well What alternative solutions did you explore? (Optional) |
@slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick! |
Job added to Upwork: https://www.upwork.com/jobs/~021837224186168791982 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 ( |
@slafortune, @Pujan92 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@Pujan92 are either of the submitted proposals valid? |
I am more inclined towards resetting the errros on going back instead of validating again the already validated fields. With that, I like the @cretadn22's proposal and we can proceed with it. 🎀👀🎀 C+ reviewed |
Triggered auto assignment to @MarioExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
@cretadn22's proposal looks nice, let's move on with this. Thanks @Pujan92 |
📣 @cretadn22 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app! Offer link |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.43-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-10-10. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@Pujan92 can you please complete the checklist? |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
Regression Test Steps
|
@Pujan92 Role C+ is owned $250 via NewDot |
$250 approved for @Pujan92 |
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team
Action Performed:
Expected Result:
The message should disappear or it should remain and "fix the errors" should redirect me to the RHP step with the error.
Actual Result:
"Please fix the errors" message persists when navigating back on the RHP. The message disappears when I click on "fix the errors". The issue is also present in the "Custom list" flow.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6603604_1726326207704.bandicam_2024-09-14_16-47-55-422.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @slafortuneThe text was updated successfully, but these errors were encountered: