[HOLD for payment 2024-11-21] [$250] Workspace chat - Report header shows "0.00 for Pending... @1.00 / mi" when changing distance & rate offline

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4966766
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Workspace has at least two distance rates.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit a distance expense.
4. Go to transaction thread.
5. Go offline.
6. Click Distance.
7. Edit the distance by swapping the waypoints.
8. Save it.
9. Click Rate.
10. Select a different rate.

Expected Result:

Report header will display "Pending" after changing distance and rate offline (production behavior).

Actual Result:

Report header displays "0.00 for Pending... @1.00 / mi" after changing distance and rate offline.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6605378_1726486914062.20240916_193630.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021835712136231108969
• Upwork Job ID: 1835712136231108969
• Last Price Increase: 2024-11-11
• Automatic offers:
• paultsimura | Contributor | 104755241

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @francoisl (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021835712136231108969

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[mountiny]

This is very minor and edge case flow with no real burden to the user, demoting

[melvin-bot]

Upwork job price has been updated to $50

[mountiny]

$50 for finding the offending PR

[CyberAndrii]

Offending PR seems to be #47136

[s77rt]

cc @paultsimura Can you check this one please

[paultsimura]

Managed to reproduce. I'll take a look in the morning.
cc: @neil-marcellini

[paultsimura]

@neil-marcellini this is one of those edge cases that I wanted to fix holistically:

1. We should split the calculateAmountForUpdatedWaypointOrRate into 2 separate functions as the logic here is gradually growing apart with every new specific test case:
   • calculateModifiedFieldsForUpdatedWaypoints
   • calculateModifiedFieldsForUpdatedDistanceRate
2. Have a proper way to determine the current unit & rate – possibly hold for [$250] Distance - Inconsistency in showing unit in preview and transaction thread after updating unit #43588 to know what way we are going: updating the BE model or parsing the merchant.

[alexpensify]

@s77rt do you agree with this plan? Thanks!

[melvin-bot]

📣 @paultsimura 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[paultsimura]

Note to self: there were some changes to the existing logic in #51285, need to make sure it doesn't break after this GH.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[paultsimura]

The PR is ready for review: #52197

[paultsimura]

@francoisl could you please adjust the bounty here to a standard $250?

[melvin-bot]

⚠️ This issue has had its price increased by 4x or more. Please review the issue and ensure the price is correct.

[melvin-bot]

Upwork job price has been updated to $250

[CyberAndrii]

I think I should be paid $50 for finding the offending PR. Am I right?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.61-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: 0.00 for Pending... @1.00 / mi #52197

If no regressions arise, payment will be issued on 2024-11-21. 🎊

For reference, here are some details about the assignees on this issue:

• @paultsimura requires payment automatic offer (Contributor)
• @s77rt requires payment through NewDot Manual Requests

[melvin-bot]

@paultsimura / @s77rt @alexpensify @paultsimura / @s77rt The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[s77rt]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: Handle customUnitOutOfPolicy violation #47136 (comment) and Followup/23961 edit request headers #25399 (comment)

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: N/A

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[alexpensify]

Payouts due: 2024-11-21

• Contributor: $250 @paultsimura - Paid via Upwork
• Reviewer: $250 @s77rt - Please submit a request via Chat

Upwork job is here.

[alexpensify]

No regression test, so no action left here

[JmillsExpensify]

$250 approved for @s77rt