[HOLD for payment 2024-10-14] [$250] Categories - RBR appears next to workspace after selecting the deleted spend category offline

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.35-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Workspace settings > Categories.
3. Go offline.
4. Delete "Travel" category (because it is linked to "Airlines" spend).
5. Click Settings.
6. Click Airlines.
7. Click Uncategorized.
8. Go online.
9. Go back to workspace list.

Expected Result:

There will not be RBR next to the workspace.

Actual Result:

RBR appears next to the workspace after selecting the deleted spend category offline, but there is no error message anywhere.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6604548_1726420009054.20240916_010231.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021838337226742068992
• Upwork Job ID: 1838337226742068992
• Last Price Increase: 2024-09-23
• Automatic offers:
• Krishna2323 | Contributor | 104134153

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[Krishna2323]

Proposal


Please re-state the problem that we are trying to solve in this issue.

Categories - RBR appears next to workspace after selecting the deleted spend category offline.

What is the root cause of that problem?

• Before calling setWorkspaceDefaultSpendCategory we don't check if the new selected category is same as the current one.
• Because we don't check match updated and current category we call setWorkspaceDefaultSpendCategory with the deleted category and backend returns error.
  

  App/src/pages/workspace/categories/SpendCategorySelectorListItem.tsx

  Lines 25 to 30 in 1af8918

  	const setNewCategory = (selectedCategory: ListItem) => {
  	if (!selectedCategory.keyForList) {
  	return;
  	}
  	Policy.setWorkspaceDefaultSpendCategory(policyID, groupID, selectedCategory.keyForList);
  	};

What changes do you think we should make in order to solve the problem?


We should check the current category and the selected category and if they are the same then we shouldn't call setWorkspaceDefaultSpendCategory.

    const setNewCategory = (selectedCategory: ListItem) => {
        if (!selectedCategory.keyForList || selectedCategory.keyForList===categoryID) {
            return;
        }

        Policy.setWorkspaceDefaultSpendCategory(policyID, groupID, selectedCategory.keyForList);
    };

What alternative solutions did you explore? (Optional)

Result

[RachCHopkins]

Ok, so we are saying that if you set an MCC default, then delete the category you set, it shows as Uncategorised and has a red dot with no error message.

I would think that if we think that people will be deleting their categories offline, and causing the MCC default to break, the solution would be displaying an error of some variety.

I don't think this is a "real" problem that users will encounter, but hey, let's pretend they are working from somewhere with dodgy reception and they happen to be doing major surgery on their categories, then it should behave the same as it would if they were online.

Unfortunately I can't seem to work out what that is. @IuliiaHerets how are you seeing the MCC defaults? Is there a prerequisite that's not on the OP there? I can't see this on Collect or Control.

[RachCHopkins]

Asked in Slack.

[Krishna2323]

@RachCHopkins, the RBR occurs only if we selected the deleted category again, the RBR does not occur on initial deletion of the category.

[melvin-bot]

@RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[RachCHopkins]

Ok, I still can't replicate this. I'm going to have to assume that it's ok.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021838337226742068992

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@Krishna2323 Thanks for the proposal. The RCA and the solution makes sense to me.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @NikkiWines, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[NikkiWines]

Agreed, @Krishna2323's proposal looks good 👍

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@s77rt, PR ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Categories - RBR appears next to workspace after selecting the deleted spend category offline. #49895

If no regressions arise, payment will be issued on 2024-10-14. 🎊

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [OldDot Rules Migration] Category settings: Default categories #48391
• The offending PR has been commented on: [OldDot Rules Migration] Category settings: Default categories #48391 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[RachCHopkins]

Payment Summary:

• Contributor: @Krishna2323 to be paid $250 via Upwork
• Contributor+: @s77rt to be paid $250 via NewDot manual request

Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

[JmillsExpensify]

$250 approved for @s77rt