[HOLD for payment 2024-11-22] [HOLD FOR #52007] [$250] Search - Total amount does not auto update after changing the expense currency

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.38-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+kh010901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM.
3. Submit two expenses.
4. Go to Search.
5. Go to Outstanding.
6. Click View next to the submitted expense.
7. Click Amount.
8. Change the currency and save it.
9. Dismiss the RHP.

Expected Result:

The total amount should auto update after changing the expense currency.

Actual Result:

The total amount does not auto update after changing the expense currency.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6608678_1726739142065.bandicam_2024-09-19_17-41-06-770.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845906959284211554
• Upwork Job ID: 1845906959284211554
• Last Price Increase: 2024-10-29
• Automatic offers:
• situchan | Reviewer | 104685821
• huult | Contributor | 104685823

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[IuliiaHerets]

@CortneyOfstad FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[CyberAndrii]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Total amount does not auto update after changing the expense currency

What is the root cause of that problem?

We compute the total here

App/src/libs/SearchUtils.ts

Line 80 in 25450d9

const formattedTotal = TransactionUtils.getAmount(transactionItem, isExpenseReport);

However, this function (getTransactionItemCommonFormattedProperties) is only called if the route/query changes. When we change the currency the route/query doesn't change, and we read the outdated total value.

App/src/components/Search/index.tsx

Lines 96 to 98 in 25450d9

	const {type, status, sortBy, sortOrder, hash} = queryJSON;
	const [currentSearchResults] = useOnyx(`${ONYXKEYS.COLLECTION.SNAPSHOT}${hash}`);

What changes do you think we should make in order to solve the problem?

Instead of reading from the formattedTotal property, we can calculate the total based on the updated transaction list.

Replace this line

App/src/components/SelectionList/Search/TransactionListItemRow.tsx

Line 159 in 25450d9

let amount = CurrencyUtils.convertToDisplayString(transactionItem.formattedTotal, currency);

with the following code

const isExpenseReport = transactionItem.reportType === CONST.REPORT.TYPE.EXPENSE;
const total = TransactionUtils.getAmount(transactionItem, isExpenseReport);
let amount = CurrencyUtils.convertToDisplayString(total, currency);

A similar approach is already implemented for reports.

Finally, we can remove the formattedTotal property from here

App/src/libs/SearchUtils.ts

Line 80 in 25450d9

const formattedTotal = TransactionUtils.getAmount(transactionItem, isExpenseReport);

[melvin-bot]

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

So one aspect here is missing — the default currency in the workspace. If the default currency is set to MHR, then the total amount did update.

I am not able to recreate this as the expense converts to the home currency of the workspace.

Going to have this retested.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[melvin-bot]

@CortneyOfstad Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@CortneyOfstad 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[CortneyOfstad]

Still waiting for this to be retested!

[melvin-bot]

@CortneyOfstad this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[CortneyOfstad]

Not overdue as waiting for this to be retested!

[CortneyOfstad]

Again, still waiting for this to be retested!

[CyberAndrii]

This issue is still reproducible. To clarify as the title is a bit misleading - the total amount does update, but not to the correct value. It should be around 1500 but it's showing as 1212. Refreshing the page displays the correct amount.

[melvin-bot]

@CortneyOfstad Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

Thanks @CyberAndrii!

[melvin-bot]

@marcochavezf @CortneyOfstad @huult / @situchan The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[CortneyOfstad]

Payment is not due until next week, but in the meantime @situchan — can you confirm if this needs a regression test? Thanks!

[CortneyOfstad]

Payment Summary

@situchan — paid $250 via Upwork
@huult — paid $250 via Upwork

[CortneyOfstad]

Whoops! Forgot about the checklist! @situchan please complete the checklist below. Thank you!

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on both staging and production
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[luacmartins]

The issue was fixed already, it's only open to process the checklist

[melvin-bot]

@marcochavezf, @CortneyOfstad, @huult, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[CortneyOfstad]

@situchan please update the checklist ASAP so this GH can be closed/completed. Thanks!

[melvin-bot]

@marcochavezf, @CortneyOfstad, @huult, @situchan Huh... This is 4 days overdue. Who can take care of this?

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@marcochavezf, @CortneyOfstad, @huult, @situchan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[marcochavezf]

Friendly bump @situchan per #49493 (comment)

[melvin-bot]

@marcochavezf, @CortneyOfstad, @huult, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!

[CortneyOfstad]

@situchan bump on the comment here.

[CortneyOfstad]

@situchan bump please

[CortneyOfstad]

@situchan — please complete this ASAP.