[HOLD for payment 2024-10-11] Search - Expenses are not highlighted when selected

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh300901@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

• There are at least two expenses submitted to the other user.

1. Go to staging.new.expensify.com
2. Go to Search.
3. Select the expenses via checkbox.
4. Note that the selected expenses are not highlighted.
5. Go to Outstanding.
6. Select all expenses via checkbox.
7. Note that the report header for the group expenses is not highlighted.

Expected Result:

The expenses will be highlighted when selected (production behavior).

Actual Result:

In Step 4, the selected expenses in All tab are not highlighted.
In Step 7, the report header for the group expenses is not highlighted.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6622006_1727865495202.high.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @Christinadobrzyn

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 4, the selected expenses in All tab are not highlighted.
In Step 7, the report header for the group expenses is not highlighted.

What is the root cause of that problem?

We override the focused background and selected background style here and here

It's only applied when we hover over the report item.

What changes do you think we should make in order to solve the problem?

We should move the style here and here above the selected background and focused background style here and here

What alternative solutions did you explore? (Optional)

[Krishna2323]

Regression from #49192

cc: @ikevin127 @ishpaul777

[melvin-bot]

Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[ishpaul777]

Not worth blocking IMO, @ikevin127 or me can raise a follow up PR or handle in #50028

cc @luacmartins

[Julesssss]

Removing blocker label. I commented here and I'll await a response before moving forward.

[luacmartins]

Thanks! @ishpaul777 will work on a PR to address this.

[ikevin127]

@luacmartins ✅ I confirm that this issue is indeed a regression of PR #49192 and I'm working on a follow-up PR to fix it right now since this is still in the regression period.

Actually, looks like the offending PR's reviewer will open a follow-up with the fix and I will review (see comments below).

[ishpaul777]

https://github.com/Expensify/App/pull/50089/files I have a draft PR here just confirming the fix on all platforms

@ikevin127 Can you review ?

[ikevin127]

🟢 Sure, I can review since this is in the regression period and I think we'd like to keep it contained.

@ishpaul777 Sorry, didn't know you started working on the fix. This would've been my diff (added some comments for clarity), and I think your version with styles.bgTransparent is cleaner 👍

diff --git a/src/components/SelectionList/Search/ReportListItem.tsx b/src/components/SelectionList/Search/ReportListItem.tsx
index ea36ba44ccc..df196a8d4e3 100644
--- a/src/components/SelectionList/Search/ReportListItem.tsx
+++ b/src/components/SelectionList/Search/ReportListItem.tsx
@@ -75,11 +75,13 @@ function ReportListItem<TItem extends ListItem>({
         styles.pv1half,
         styles.ph0,
         styles.overflowHidden,
-        item.isSelected && styles.activeComponentBG,
-        isFocused && styles.sidebarLinkActive,
-        // Removing some of the styles because they are added to the parent OpacityView via animatedHighlightStyle
+        // We unset backgroundColor and reset marginHorizontal because the styles
+        // are handled by parent OpacityView via animatedHighlightStyle
         {backgroundColor: 'unset'},
         styles.mh0,
+        // These should be at the end because otherwise the item won't highlight when selected
+        item.isSelected && styles.activeComponentBG,
+        isFocused && styles.sidebarLinkActive,
     ];
 
     const handleOnButtonPress = () => {
diff --git a/src/components/SelectionList/Search/TransactionListItem.tsx b/src/components/SelectionList/Search/TransactionListItem.tsx
index 39172711516..bd9fceb5a5c 100644
--- a/src/components/SelectionList/Search/TransactionListItem.tsx
+++ b/src/components/SelectionList/Search/TransactionListItem.tsx
@@ -27,11 +27,13 @@ function TransactionListItem<TItem extends ListItem>({
         styles.selectionListPressableItemWrapper,
         styles.pv3,
         styles.ph3,
-        item.isSelected && styles.activeComponentBG,
-        isFocused && styles.sidebarLinkActive,
-        // Removing some of the styles because they are added to the parent OpacityView via animatedHighlightStyle
+        // We unset backgroundColor and reset marginHorizontal because the styles
+        // are handled by parent OpacityView via animatedHighlightStyle
         {backgroundColor: 'unset'},
         styles.mh0,
+        // These should be at the end because otherwise the item won't highlight when selected
+        item.isSelected && styles.activeComponentBG,
+        isFocused && styles.sidebarLinkActive,
     ];
 
     const listItemWrapperStyle = [

[luacmartins]

Thanks! I assigned you as reviewer @ikevin127

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.44-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Fix] Search - Expenses are not highlighted when selected #50089

If no regressions arise, payment will be issued on 2024-10-11. 🎊

For reference, here are some details about the assignees on this issue:

• @ikevin127 requires payment (Needs manual offer from BZ)
• @ishpaul777 requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ikevin127 / @ishpaul777] The PR that introduced the bug has been identified. Link to the PR:
• [@ikevin127 / @ishpaul777] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ikevin127 / @ishpaul777] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ikevin127 / @ishpaul777] Determine if we should create a regression test for this bug.
• [@ikevin127 / @ishpaul777] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[ikevin127]

• [@ikevin127] The PR that introduced the bug has been identified. Link to the PR: Search - Highlight newly added expense #49192.
• [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/49192/files#r1788391399.
• [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
• [@ikevin127] Determine if we should create a regression test for this bug.
• [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Navigate to the Search page.
2. Select expenses via the checkbox.
3. Verify that the selected expenses are highlighted.
4. Go to Outstanding expenses.
5. Select all expenses via checkbox.
6. Verify that the report header for the expense group is highlighted.

Do we agree 👍 or 👎.

[Julesssss]

I don't think we need a specific regression test for this small fix.

[Christinadobrzyn]

Payouts due in a few days

• Contributor: $250 @ishpaul777 (Upwork offer - https://www.upwork.com/nx/wm/offer/104334781)
• Contributor+: $250 @ikevin127 (Upwork offer - https://www.upwork.com/nx/wm/workroom/38646509/overview)

Let me know if anything needs to be changed about the payment summary.

[ishpaul777]

No payment here for C ad C+, this came from a PR under regression period

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ikevin127 paid $0 via Upwork
• ROLE: @ishpaul777 paid $0 via Upwork

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Ah, okay. Thanks for letting me know, @ishpaul777.

I closed the Upwork contracts for you and @ikevin127 without payment. No regression test based on this comment.

Closing this out as complete.