[HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN #50145

m-natarajan · 2024-10-03T12:18:04Z

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.44-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1727421902555249

Action Performed:

Open any report
Send a message with h1 tag and image tag. i.e. # Business? Personal? Now it's both. Are you here to track business expenses or personal spend? Or maybe both? Expensify lets you track it all together on a chat-based platform. Collaborate with colleagues, friends, or your accountant, and keep all your financial management needs in one app! [Try it now](https://new.expensify.com/track-expense) and see for yourself. ![1707757682096-1_ChatDM_v2_10fps_600w_256color.gif](https://s3-us-west-1.amazonaws.com/concierge-responses-expensify-com/uploads/1707757682096-1_ChatDM_v2_10fps_600w_256color.gif)
Notice the last message text in LHN
Click on the search icon in the top bar
Notice the last message text of the report in step 1

Expected Result:

In the finder page, the last message text should be the same that is displayed in LHN

Actual Result:

In the finder page, the last message text contains the HTML tag.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Screen.Recording.2024-09-27.at.14.20.28.mov

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021842318129015789184
Upwork Job ID: 1842318129015789184
Last Price Increase: 2024-10-04
Automatic offers:

dukenv0307 | Reviewer | 104302118
nkdengineer | Contributor | 104302120

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @adelekennedy

The text was updated successfully, but these errors were encountered:

melvin-bot · 2024-10-03T12:18:16Z

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

nkdengineer · 2024-10-03T14:12:10Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

The last message text in the finder page contains the HTML tag

What is the root cause of that problem?

When we send the message like the step, lastMessageText of the report contains HTML tag and we don't convert it to text here that cause the bug happens in the finder page

App/src/libs/OptionsListUtils.ts

Lines 545 to 580 in 9e72084

    
           function getAlternateText(option: ReportUtils.OptionData, {showChatPreviewLine = false, forcePolicyNamePreview = false}: PreviewConfig) { 
        
               const report = ReportUtils.getReportOrDraftReport(option.reportID); 
        
               const isAdminRoom = ReportUtils.isAdminRoom(report); 
        
               const isAnnounceRoom = ReportUtils.isAnnounceRoom(report); 
        
               const isGroupChat = ReportUtils.isGroupChat(report); 
        
               const isExpenseThread = ReportUtils.isMoneyRequest(report); 
        
               if (isExpenseThread || option.isMoneyRequestReport) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'iou.expense'); 
        
               } 
        
               if (option.isThread) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'threads.thread'); 
        
               } 
        
               if (option.isChatRoom && !isAdminRoom && !isAnnounceRoom) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : option.subtitle; 
        
               } 
        
               if ((option.isPolicyExpenseChat ?? false) || isAdminRoom || isAnnounceRoom) { 
        
                   return showChatPreviewLine && !forcePolicyNamePreview && option.lastMessageText ? option.lastMessageText : option.subtitle; 
        
               } 
        
               if (option.isTaskReport) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'task.task'); 
        
               } 
        
               if (isGroupChat) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'common.group'); 
        
               } 
        
               return showChatPreviewLine && option.lastMessageText 
        
                   ? option.lastMessageText 
        
                   : LocalePhoneNumber.formatPhoneNumber(option.participantsList && option.participantsList.length > 0 ? option.participantsList.at(0)?.login ?? '' : ''); 
        
           }

This doesn't happen in LHN because we've used htmlToText here and here

What changes do you think we should make in order to solve the problem?

We should create a new variable that is the converted message of the option. lastMessageText by using the same approach that we used in SidebarUtils. Then we can use this variable to replace the option. lastMessageText.

const formattedLastMessageText = ReportUtils.formatReportLastMessageText(Parser.htmlToText(option.lastMessageText ?? ''));

App/src/libs/OptionsListUtils.ts

Lines 545 to 580 in 9e72084

    
           function getAlternateText(option: ReportUtils.OptionData, {showChatPreviewLine = false, forcePolicyNamePreview = false}: PreviewConfig) { 
        
               const report = ReportUtils.getReportOrDraftReport(option.reportID); 
        
               const isAdminRoom = ReportUtils.isAdminRoom(report); 
        
               const isAnnounceRoom = ReportUtils.isAnnounceRoom(report); 
        
               const isGroupChat = ReportUtils.isGroupChat(report); 
        
               const isExpenseThread = ReportUtils.isMoneyRequest(report); 
        
               if (isExpenseThread || option.isMoneyRequestReport) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'iou.expense'); 
        
               } 
        
               if (option.isThread) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'threads.thread'); 
        
               } 
        
               if (option.isChatRoom && !isAdminRoom && !isAnnounceRoom) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : option.subtitle; 
        
               } 
        
               if ((option.isPolicyExpenseChat ?? false) || isAdminRoom || isAnnounceRoom) { 
        
                   return showChatPreviewLine && !forcePolicyNamePreview && option.lastMessageText ? option.lastMessageText : option.subtitle; 
        
               } 
        
               if (option.isTaskReport) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'task.task'); 
        
               } 
        
               if (isGroupChat) { 
        
                   return showChatPreviewLine && option.lastMessageText ? option.lastMessageText : Localize.translate(preferredLocale, 'common.group'); 
        
               } 
        
               return showChatPreviewLine && option.lastMessageText 
        
                   ? option.lastMessageText 
        
                   : LocalePhoneNumber.formatPhoneNumber(option.participantsList && option.participantsList.length > 0 ? option.participantsList.at(0)?.login ?? '' : ''); 
        
           }

What alternative solutions did you explore? (Optional)

dukenv0307 · 2024-10-03T14:25:49Z

@adelekennedy I report this bug so I can help take it as C+. Thanks

adelekennedy · 2024-10-04T21:37:10Z

I can replicate but again, more of a polish here so reducing the price

melvin-bot · 2024-10-04T21:37:26Z

Job added to Upwork: https://www.upwork.com/jobs/~021842318129015789184

melvin-bot · 2024-10-04T21:37:31Z

Current assignee @dukenv0307 is eligible for the External assigner, not assigning anyone new.

dukenv0307 · 2024-10-07T09:44:32Z

@nkdengineer's proposal LGTM

🎀👀🎀 C+ reviewed

melvin-bot · 2024-10-07T09:44:45Z

Triggered auto assignment to @MarioExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

MarioExpensify · 2024-10-07T13:08:26Z

@nkdengineer proposal looks good. Thank you @dukenv0307, let's move forward.

melvin-bot · 2024-10-07T13:08:45Z

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-10-07T13:08:49Z

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2024-10-15T03:17:57Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-10-15T03:18:01Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix: The finder page display last message text is different #50399

If no regressions arise, payment will be issued on 2024-10-22. 🎊

For reference, here are some details about the assignees on this issue:

@dukenv0307 requires payment automatic offer (Reviewer)
@nkdengineer requires payment automatic offer (Contributor)
@dukenv0307 requires payment automatic offer (Reviewer)

melvin-bot · 2024-10-15T03:18:02Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

nkdengineer · 2024-10-15T03:28:21Z

@adelekennedy Can you please update the price to 125 since the PR isn't a simple one-line change

adelekennedy · 2024-10-23T15:31:03Z

Payouts due:

Contributor: $125 @nkdengineer
Reviewer: $125 @dukenv0307

Upwork job is here.

tgolen · 2024-10-23T21:50:43Z

Reopening for @dukenv0307 and @adelekennedy to complete the regression checklist

dukenv0307 · 2024-10-24T18:11:03Z

BugZero Checklist:

The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test:

Open any report
Send a message with h1 tag and image tag. i.e. # Business? Personal? Now it's both. Are you here to track business expenses or personal spend? Or maybe both? Expensify lets you track it all together on a chat-based platform. Collaborate with colleagues, friends, or your accountant, and keep all your financial management needs in one app! [Try it now](https://new.expensify.com/track-expense) and see for yourself. ![1707757682096-1_ChatDM_v2_10fps_600w_256color.gif](https://s3-us-west-1.amazonaws.com/concierge-responses-expensify-com/uploads/1707757682096-1_ChatDM_v2_10fps_600w_256color.gif)
Notice the last message text in LHN
Click on the search icon in the top bar
Notice the last message text of the report in step 2
Verify that: In the finder page, the last message text should be the same that is displayed in LHN

Do we 👍 or 👎

dukenv0307 · 2024-10-24T18:11:23Z

@adelekennedy I completed the checklists

adelekennedy · 2024-10-28T04:01:03Z

QA issue created!

m-natarajan added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 3, 2024

melvin-bot bot assigned adelekennedy Oct 3, 2024

adelekennedy assigned dukenv0307 Oct 4, 2024

adelekennedy added the External Added to denote the issue can be worked on by a contributor label Oct 4, 2024

melvin-bot bot changed the title ~~The finder page display last message text is different from LHN~~ [$250] The finder page display last message text is different from LHN Oct 4, 2024

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 4, 2024

adelekennedy changed the title ~~[$250] The finder page display last message text is different from LHN~~ [$62.50] The finder page display last message text is different from LHN Oct 4, 2024

melvin-bot bot added the Overdue label Oct 7, 2024

melvin-bot bot removed the Overdue label Oct 7, 2024

melvin-bot bot assigned MarioExpensify Oct 7, 2024

MarioExpensify assigned nkdengineer Oct 7, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 7, 2024

nkdengineer mentioned this issue Oct 8, 2024

fix: The finder page display last message text is different #50399

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 Weekly KSv2 labels Oct 8, 2024

melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 15, 2024

melvin-bot bot changed the title ~~[$62.50] The finder page display last message text is different from LHN~~ [HOLD for payment 2024-10-22] [$62.50] The finder page display last message text is different from LHN Oct 15, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Oct 15, 2024

adelekennedy changed the title ~~[HOLD for payment 2024-10-22] [$62.50] The finder page display last message text is different from LHN~~ [HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN Oct 15, 2024

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 21, 2024

adelekennedy closed this as completed Oct 23, 2024

tgolen reopened this Oct 23, 2024

adelekennedy closed this as completed Oct 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN #50145

[HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN #50145

m-natarajan commented Oct 3, 2024 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 3, 2024

nkdengineer commented Oct 3, 2024

dukenv0307 commented Oct 3, 2024

adelekennedy commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

dukenv0307 commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

MarioExpensify commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

melvin-bot bot commented Oct 15, 2024

melvin-bot bot commented Oct 15, 2024

melvin-bot bot commented Oct 15, 2024

nkdengineer commented Oct 15, 2024

adelekennedy commented Oct 23, 2024 •

edited

Loading

tgolen commented Oct 23, 2024

dukenv0307 commented Oct 24, 2024

dukenv0307 commented Oct 24, 2024

adelekennedy commented Oct 28, 2024

[HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN #50145

[HOLD for payment 2024-10-22] [$125.00] The finder page display last message text is different from LHN #50145

Comments

m-natarajan commented Oct 3, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 3, 2024

nkdengineer commented Oct 3, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

dukenv0307 commented Oct 3, 2024

adelekennedy commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

melvin-bot bot commented Oct 4, 2024

dukenv0307 commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

MarioExpensify commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

melvin-bot bot commented Oct 7, 2024

melvin-bot bot commented Oct 15, 2024

melvin-bot bot commented Oct 15, 2024

melvin-bot bot commented Oct 15, 2024

nkdengineer commented Oct 15, 2024

adelekennedy commented Oct 23, 2024 • edited Loading

tgolen commented Oct 23, 2024

dukenv0307 commented Oct 24, 2024

dukenv0307 commented Oct 24, 2024

adelekennedy commented Oct 28, 2024

m-natarajan commented Oct 3, 2024 •

edited by melvin-bot bot

Loading

adelekennedy commented Oct 23, 2024 •

edited

Loading