[HOLD for payment 2021-09-20] The label of the field is lost after typing something

[aldo-expensify]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Action Performed:

1. Navigate to /bank-account/
2. Click "Connect manually"
3. Type anything any of the two text inputs

Expected Result:

The label should become smaller an move up, just like the text fields in the Company step:

Actual Result:

The label disappeared

Workaround:

The user can delete the content of the input to see the label again (in case he forgets)

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @sonialiap (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[akshayasalvi]

Proposed Solution

In the BankAccountStep, we should be updating props from placeholder to label.

// Rename prop placeholder ---> label

<ExpensiTextInput
      label={this.props.translate('bankAccount.routingNumber')}

<ExpensiTextInput
      label={this.props.translate('bankAccount.accountNumber')}

In addition to this, the current fields don't have any margin between them:

So we should add bottom margin as well

<ExpensiTextInput
      label={this.props.translate('bankAccount.routingNumber')}
      style={[styles.mb5]}

[Santhosh-Sellavel]

@akshayasalvi
Note: Space between routing number and account number is already handled in discussed in #4834 & Handled in PR #4991

[MelvinBot]

Triggered auto assignment to @TomatoToaster (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @kevinksullivan (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[MelvinBot]

Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[kevinksullivan]

Posted - https://www.upwork.com/jobs/~017df793db7d6ebcfe

[MelvinBot]

Triggered auto assignment to @Jag96 (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Jag96]

@akshayasalvi good find, your proposal (without updating the margin since it's already in progress) looks good to me! @kevinksullivan we're good to hire @akshayasalvi for this job, @akshayasalvi feel free to get started on a PR once you're hired in Upwork!

[akshayasalvi]

I've applied for the Upwork job post too. If the issue is assigned in Github, do I still need to wait to get hired on Upwork before I start working on the PR?

[kevinksullivan]

@akshayasalvi hired on upwork.

[botify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[botify]

🚀 Deployed to staging by @Jag96 in version: 1.0.96-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[botify]

🚀 Deployed to production by @francoisl in version: 1.0.97-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[Jag96]

Paid!

[akshayasalvi]

Thank you!