Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added spacing between Routing & Account Number #4991

Conversation

Santhosh-Sellavel
Copy link
Collaborator

@Santhosh-Sellavel Santhosh-Sellavel commented Sep 1, 2021

@puneetlath

Details

Just added a space between the Routing Number & Account Number input in Add Bank Account Step.

Fixed Issues

$ #4834

Tests & QA Steps

  1. Add account to free plan beta
  2. Go to new.expensify.com
  3. Create a workspace
  4. Select Get Started in Expensify Card tab of the workspace
  5. Choose the "Connect Manually" option

Fix:
Ensure space is added between Routing Number & Account Number input.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot 2021-09-01 at 10 54 30 PM

Mobile Web

Simulator Screen Shot - iPhone 12 - 2021-09-01 at 22 55 59

Desktop

Screenshot 2021-09-01 at 10 54 05 PM

iOS

Simulator Screen Shot - iPhone 12 - 2021-09-01 at 22 57 16

Android

Screenshot_1630517457

@Santhosh-Sellavel Santhosh-Sellavel requested a review from a team as a code owner September 1, 2021 17:46
@MelvinBot MelvinBot requested review from puneetlath and removed request for a team September 1, 2021 17:46
@Santhosh-Sellavel Santhosh-Sellavel marked this pull request as draft September 1, 2021 17:49
@puneetlath
Copy link
Contributor

@shawnborton would love your eyes on this form. There seems to be a mix of mb5, mt5, and mt4 in this form. It looks fine to me after @Santhosh-Sellavel's changes, but would love for a second pair of eyes before merging.

@Santhosh-Sellavel
Copy link
Collaborator Author

@puneetlath
@shawnborton might be OOO until Sep 7. Can we wait until then or can we loop someone else?

@puneetlath
Copy link
Contributor

Good point. It looks good to me and @michelle-thompson. So I'm going to go ahead and merge it.

@shawnborton if you want to clean up these form styles at all when you're back, we can open a new issue.

@puneetlath puneetlath merged commit 7de992e into Expensify:main Sep 2, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Sep 2, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Sep 3, 2021

🚀 Deployed to staging by @puneetlath in version: 1.0.92-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@shawnborton
Copy link
Contributor

shawnborton commented Sep 3, 2021 via email

@botify
Copy link

botify commented Sep 3, 2021

This has been deployed to production and is now subject to a 7-day regression period.
If no regressions arise, payment will be issued on 2021-09-10. 🎊

@OSBotify
Copy link
Contributor

OSBotify commented Sep 4, 2021

🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants