-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added spacing between Routing & Account Number #4991
Added spacing between Routing & Account Number #4991
Conversation
@shawnborton would love your eyes on this form. There seems to be a mix of mb5, mt5, and mt4 in this form. It looks fine to me after @Santhosh-Sellavel's changes, but would love for a second pair of eyes before merging. |
@puneetlath |
Good point. It looks good to me and @michelle-thompson. So I'm going to go ahead and merge it. @shawnborton if you want to clean up these form styles at all when you're back, we can open a new issue. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @puneetlath in version: 1.0.92-1 🚀
|
Sounds good, but I trust you and Michelle so if it works for you all, it
works for me!
…On Fri, Sep 3, 2021 at 3:32 AM OSBotify ***@***.***> wrote:
🚀 Deployed <https://github.com/Expensify/App/actions/runs/1196336036> to
staging by @puneetlath <https://github.com/puneetlath> in version:
1.0.92-1 🚀
platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4991 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARWH5ULWPMTCSGRVIXUYTLUAAQRLANCNFSM5DHAD2MA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
This has been deployed to production and is now subject to a 7-day regression period. |
🚀 Deployed to production by @roryabraham in version: 1.0.93-1 🚀
|
@puneetlath
Details
Just added a space between the
Routing Number
&Account Number
input in Add Bank Account Step.Fixed Issues
$ #4834
Tests & QA Steps
Fix:
Ensure space is added between
Routing Number
&Account Number
input.Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android