[$250] Finder - Concierge chat preview is displayed with code in chat finder

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.45-0
Reproducible in staging?: Y
Reproducible in production?: Y
Issue reported by: Applause Internal Team

Action Performed:

1. Open the staging.new.expensify.com website.
2. Sign in with any account.
3. Tap on the search icon on LHN.
4. Verify the preview of Concierge chat is displayed without any code or content issue.

Expected Result:

The preview of the Cocnierge chat in chat finder, should display the beggining of the last message without any difference with the message in chat.

Actual Result:

The preview of Concierge chat in chat finder, displays the beggining of the last message, with "

>/h1>" code in the middle of it.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6626663_1728280381573.Concierge.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021845626651629289152
• Upwork Job ID: 1845626651629289152
• Last Price Increase: 2024-11-11

Issue Owner

Current Issue Owner: @rojiphil

[melvin-bot]

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[IuliiaHerets]

We think that this bug might be related to #wave-collect - Release 1

[IuliiaHerets]

@VictoriaExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[VictoriaExpensify]

Unable to reproduce this, posted in #QA - https://expensify.slack.com/archives/C9YU7BX5M/p1728458635539589

[kavimuru]

The issue is reproducible when the concierge chat updates with new information.

screen-20241009-090642.mp4

[VictoriaExpensify]

Yup we should fix this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021845626651629289152

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[huult]

Can we still reproduce this issue on version 9.0.48-0?

[huult]

Edited by proposal-police: This proposal was edited at 2024-10-15 15:21:07 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Finder - Concierge chat preview is displayed with code in chat finder

What is the root cause of that problem?

The alternateText is returned as an HTML string in the report data.

Example: item.alternateText: "<h1>Let's scan your first receipt</h1>"

When rendering alternateText in the chat finder, it only removes the SMS domain but does not parse the HTML into plain text. As a result, this issue occurs for report items where the alternateText contains an HTML string.

App/src/components/SelectionList/UserListItem.tsx

Lines 141 to 147 in 4a3f2da

	{!!item.alternateText && (
	<TextWithTooltip
	shouldShowTooltip={showTooltip}
	text={Str.removeSMSDomain(item.alternateText ?? '')}
	style={[styles.textLabelSupporting, styles.lh16, styles.pre]}
	/>
	)}

What changes do you think we should make in order to solve the problem?

To resolve this case, we should parse alternateText from an HTML string to text before removing the SMS domain. We will use Parser.htmlToText, which is used in other places to parse alternateText. The code change will look like this:

//.src/components/SelectionList/UserListItem.tsx#L144
- text={Str.removeSMSDomain(item.alternateText ?? '')}
+ text={Str.removeSMSDomain(Parser.htmlToText(item.alternateText).replace(/\s*\n\s*/g, ' ') ?? '')}

POC

[melvin-bot]

@rojiphil, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[VictoriaExpensify]

@rojiphil - can you please review @huult's proposal when you have the chance?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rojiphil]

Sorry for the delay here. I will review this my day tomorrow and update.

[melvin-bot]

@rojiphil @VictoriaExpensify this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[rojiphil]

The issue is reproducible when the concierge chat updates with new information.

I am unable to reproduce the problem.
@kavimuru How can we make the concierge chat to send this new information?

[rojiphil]

The alternateText is returned as an HTML string in the report data.

@huult While I figure out a way to reproduce this, can you please investigate why the alternateText is populated with HTML string instead of text?
In my test as demonstrated below, it is showing correctly.

50350-not-reproduced.mp4

[huult]

@rojiphil Maybe this issue was resolved by another pull request. Can you ask @kavimuru if she can reproduce the issue? If not, we can close it

[rojiphil]

Maybe this issue was resolved by another pull request. Can you ask @kavimuru if she can reproduce the issue? If not, we can close it

Thanks @huult. That makes sense.
@kavimuru Can you please try to reproduce this again? It looks like this should be fixed in production.

[rojiphil]

@VictoriaExpensify Can you please apply the Retest Weekly label for Applause to check this? Thanks

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[VictoriaExpensify]

Applied the retest label

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[melvin-bot]

@rojiphil, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@rojiphil @VictoriaExpensify this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[melvin-bot]

@rojiphil, @VictoriaExpensify Still overdue 6 days?! Let's take care of this!

[rojiphil]

@VictoriaExpensify I think we can close this issue as this is not reproducible as mentioned here

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[melvin-bot]

@rojiphil, @VictoriaExpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[rojiphil]

@VictoriaExpensify, I think we can close this issue as it is not reproducible for the second week also.
What do you think?

[VictoriaExpensify]

I agree with you @rojiphil - let's close it out!